-
Notifications
You must be signed in to change notification settings - Fork 1
header and footer #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welldone @vkguru
Please attend to the following issues
/tmp/build_93e7df2046c8565d78b4e80f59553ab1/src/Component/Header.js
40:13 error Unknown property 'class' found, use 'className' instead react/no-unknown-property
46:14 error Unknown property 'class' found, use 'className' instead react/no-unknown-property
Issue resolved. I thought I added the changes to the commit. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Please make the header fixed
Add fixed-top
class
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
develop
branch has been updated with approved PRs from other branches
Please update header-footer
branch
I have fixed all issues locally but I am having difficulty pushing it to the remote branch. The error says
I have also done |
Try this
|
Did that already, I still had same error after adding a commit message and tried to push |
Done |
Done |
Description
Please include a summary of the change and relevant motivation and context.
List any dependencies that are required for this change.
All pull requests should be related to open issues. Indicate the issue(s) bellow and remove this line:
Fixes #6 Fixes #7
How Has This Been Tested?
I tested for lint errors.
I also used jest and enzyme, shallow and mount test that the app rendered without crashing
Checklist: