Skip to content

header and footer #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

header and footer #17

wants to merge 16 commits into from

Conversation

vkguru
Copy link

@vkguru vkguru commented May 26, 2020

Description

Please include a summary of the change and relevant motivation and context.
List any dependencies that are required for this change.

All pull requests should be related to open issues. Indicate the issue(s) bellow and remove this line:
Fixes #6 Fixes #7

How Has This Been Tested?

I tested for lint errors.
I also used jest and enzyme, shallow and mount test that the app rendered without crashing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added necessary inline code documentation
  • I have added tests that prove my fix is effective and that this feature works
  • New and existing unit tests pass locally with my changes

@amjedidiah amjedidiah temporarily deployed to edukolab-header-footer-c2mjkfn May 26, 2020 17:56 Inactive
Copy link
Contributor

@amjedidiah amjedidiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welldone @vkguru

Please attend to the following issues

/tmp/build_93e7df2046c8565d78b4e80f59553ab1/src/Component/Header.js
        40:13  error  Unknown property 'class' found, use 'className' instead  react/no-unknown-property
        46:14  error  Unknown property 'class' found, use 'className' instead  react/no-unknown-property

@amjedidiah amjedidiah temporarily deployed to edukolab-header-footer-obdltdo May 26, 2020 18:25 Inactive
@vkguru
Copy link
Author

vkguru commented May 26, 2020

Welldone @vkguru

Please attend to the following issues

/tmp/build_93e7df2046c8565d78b4e80f59553ab1/src/Component/Header.js
        40:13  error  Unknown property 'class' found, use 'className' instead  react/no-unknown-property
        46:14  error  Unknown property 'class' found, use 'className' instead  react/no-unknown-property

Issue resolved. I thought I added the changes to the commit. Thanks.

@vkguru vkguru closed this May 26, 2020
@vkguru vkguru reopened this May 26, 2020
@vkguru vkguru added client feature New feature or request component React component labels May 26, 2020
@amjedidiah amjedidiah temporarily deployed to edukolab-header-footer-yetbdit May 26, 2020 18:58 Inactive
Copy link
Contributor

@amjedidiah amjedidiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice
Please make the header fixed
Add fixed-top class

@amjedidiah amjedidiah temporarily deployed to edukolab-header-footer-yetbdit May 26, 2020 19:21 Inactive
@vkguru
Copy link
Author

vkguru commented May 26, 2020

Nice
Please make the header fixed
Add fixed-top class

Done.

@vkguru vkguru requested a review from amjedidiah May 26, 2020 19:25
@amjedidiah amjedidiah temporarily deployed to edukolab-header-footer-yetbdit May 26, 2020 19:32 Inactive
@amjedidiah amjedidiah self-requested a review May 27, 2020 11:16
@okonwanjiphillip okonwanjiphillip self-requested a review May 27, 2020 11:17
Copy link
Contributor

@amjedidiah amjedidiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop branch has been updated with approved PRs from other branches
Please update header-footer branch

@vkguru
Copy link
Author

vkguru commented May 28, 2020

develop branch has been updated with approved PRs from other branches
Please update header-footer branch

I have fixed all issues locally but I am having difficulty pushing it to the remote branch. The error says

To https://github.com/BuildForSDG/EduKolab-Frontend.git
 ! [rejected]        header-footer -> header-footer (non-fast-forward)
error: failed to push some refs to 'https://github.com/BuildForSDG/EduKolab-Frontend.git'

I have also done git pull but I still have the same issue. I am still looking into it, you can provide any assistance that can help clear this too.

@amjedidiah
Copy link
Contributor

Try this

git pull origin <YOUR_BRANCH_NAME>
Grabs online updates and merges them with your local work

@vkguru
Copy link
Author

vkguru commented May 30, 2020

Try this

git pull origin <YOUR_BRANCH_NAME>
Grabs online updates and merges them with your local work

Did that already, I still had same error after adding a commit message and tried to push

@vkguru
Copy link
Author

vkguru commented Jun 1, 2020

develop branch has been updated with approved PRs from other branches
Please update header-footer branch

Done

@amjedidiah amjedidiah temporarily deployed to edukolab-cli-header-foo-52hjaz June 1, 2020 12:28 Inactive
@amjedidiah amjedidiah had a problem deploying to edukolab-cli-header-foo-52hjaz June 1, 2020 12:30 Failure
@amjedidiah amjedidiah temporarily deployed to edukolab-cli-header-foo-52hjaz June 1, 2020 12:38 Inactive
@vkguru
Copy link
Author

vkguru commented Jun 1, 2020

develop branch has been updated with approved PRs from other branches
Please update header-footer branch

Done

@amjedidiah amjedidiah had a problem deploying to edukolab-cli-header-foo-52hjaz June 1, 2020 15:09 Failure
@amjedidiah amjedidiah temporarily deployed to edukolab-cli-header-foo-52hjaz June 1, 2020 15:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client component React component feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Design and Implementation of Footer component [FEATURE] Design and Implementation of Header component
4 participants