Skip to content

Avoid type cast error on custom cemuhook port #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

git-developer
Copy link

I once contributed kozec#727 and just found out that it does not work in the python3 branch of Ryochan's fork: when the daemon is started with a custom UDP port, an error message is repeated on the command line:

$ SCC_SERVER_PORT=26768 ./sc-controller-v0.4.8.13-lunar-x86_64.AppImage daemon debug
...
E SCCDaemon     Failed to initialize CemuHookUDP Motion Provider: 'str' object cannot be interpreted as an integer
E SCCDaemon     Failed to initialize CemuHookUDP Motion Provider: 'str' object cannot be interpreted as an integer
E SCCDaemon     Failed to initialize CemuHookUDP Motion Provider: 'str' object cannot be interpreted as an integer
...

This error may be caused by the move from python2 to python3, and should be fixed by this PR.

I read that @Ryochan7 does no longer maintain the sc-controller project, and that you may be interested in taking over the repo. Please let me know if you're not interested in accepting this PR, I will close it then.

@Ryochan7
Copy link

Maybe the Python 2 implementation for socket allowed for a string as a valid port argument for the bind method. That does not seem to work in Python 3 as it expects the port number to be passed as an integer. It looks like this change should fix that issue.

@git-developer
Copy link
Author

@Ryochan7 Thanks for getting in touch here! Is there a new maintainer for sc-controller, or a "recommended" fork for PRs against the python3 branch? I'd like to contribute the port fix and a feature to configure the server ip.

@Ryochan7
Copy link

AFAIK, there is no actively maintained fork of the Python 3 version of SC Controller. I was hoping this fork would be active. Things have not really changed for me. Still burnt out from the DS4Windows drama.

@git-developer
Copy link
Author

I don't know about that. Please take care about yourself. After all, these projects should be for fun and not for stress. Thanks for all the work and good luck for you. Maybe @C0rn3j or someone else will take over some day.

@C0rn3j
Copy link
Owner

C0rn3j commented May 10, 2024

Upstream is actually down for pulling the entire changeset, it's just that the maintainer has account trouble to do so, I pinged him again and will see what happens - kozec#367 (comment)

@C0rn3j C0rn3j merged commit ccde45f into C0rn3j:python3 Jun 11, 2024
@C0rn3j
Copy link
Owner

C0rn3j commented Jun 12, 2024

I've pulled this and some other small things and made the AUR packages point to this repo, as kozec still hasn't gotten around to pulling in even the older changes upstream.

@chewi
Copy link

chewi commented Jun 22, 2024

@C0rn3j, many thanks for keeping this alive. Gentoo is grateful.

@git-developer git-developer deleted the fix/udp-port branch June 24, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants