Skip to content

rvgl: add hash checking and persists #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 24, 2024
Merged

Conversation

superusercode
Copy link
Contributor

Closes #181

@superusercode superusercode marked this pull request as draft May 15, 2023 03:10
@superusercode
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

Your changes do not pass checks.

rvgl

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@superusercode
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

Your changes do not pass checks.

rvgl

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@superusercode
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

Your changes do not pass checks.

rvgl

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@superusercode
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

Your changes do not pass checks.

rvgl

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@superusercode
Copy link
Contributor Author

/verify

@superusercode
Copy link
Contributor Author

note to self: change regex back to \d{2}\.\d{4}[a-z]-?\d* if it fails

@github-actions
Copy link
Contributor

Your changes do not pass checks.

rvgl

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@superusercode
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

Your changes do not pass checks.

rvgl

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@superusercode
Copy link
Contributor Author

@Calinou am i canceling my regex wrong? because i can verify it works on the sites i've attempt even though the checkver script can't find anything
image

@superusercode
Copy link
Contributor Author

in #933 's case it's more like checkver hates certain sites and has a limit to what it can see in page source, so i'm stumped

@superusercode
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

Your changes do not pass checks.

rvgl

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@superusercode
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

Your changes do not pass checks.

rvgl

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@superusercode
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

Your changes do not pass checks.

rvgl

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@superusercode
Copy link
Contributor Author

superusercode commented May 15, 2023

I don't know what the checkver script is seeing, but it's definitely not using the whole page source

@superusercode superusercode reopened this May 16, 2023
Co-authored-by: Zarin <[email protected]>
@superusercode
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

rvgl

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@superusercode superusercode marked this pull request as ready for review May 16, 2023 02:48
@superusercode
Copy link
Contributor Author

@kazzarin thank you

@superusercode
Copy link
Contributor Author

bump

@Calinou Calinou added the enhancement New feature or request label Oct 24, 2024
Copy link
Owner

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 69bef90 into Calinou:master Oct 24, 2024
@superusercode superusercode deleted the patch-5 branch October 24, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to update "nightly" rvgl?
3 participants