Skip to content

feat: track async validation delay from first seen #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Jun 13, 2023

Motivation
We want to know how long does it take to validate a message with async validation

Description

  • Use firstSeen field in MessageDeliveries
  • Add new metrics:
    • asyncValidationDelayFromFirstSeenSec
    • asyncValidationUnknownFirstSeen

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 18.96% and project coverage change: -0.19 ⚠️

Comparison is base (acf304f) 82.70% compared to head (dc16c5a) 82.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
- Coverage   82.70%   82.52%   -0.19%     
==========================================
  Files          48       48              
  Lines       11931    11968      +37     
  Branches     1278     1279       +1     
==========================================
+ Hits         9867     9876       +9     
- Misses       2064     2092      +28     
Impacted Files Coverage Δ
src/metrics.ts 19.05% <0.00%> (-0.62%) ⬇️
src/index.ts 70.10% <12.50%> (+0.10%) ⬆️
src/score/peer-score.ts 85.53% <28.57%> (-0.42%) ⬇️
src/score/message-deliveries.ts 97.89% <66.66%> (-2.11%) ⬇️
src/message-cache.ts 78.06% <100.00%> (+0.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@twoeths twoeths marked this pull request as ready for review June 19, 2023 03:34
@twoeths twoeths requested a review from a team as a code owner June 19, 2023 03:34
@dapplion dapplion merged commit e2505d6 into master Jun 19, 2023
@dapplion dapplion deleted the metrics-async branch June 19, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants