fix: parameter to _onPeerDisconnected #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_onPeerDisconnected` is expecting a `PeerInfo` but it was being passed a pubsub `Peer`.
I'm not sure if this is the correct fix but it resolves this error for me:
```
(node:77189) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'toB58String' of undefined
at GossipSub._onPeerDisconnected (/Users/alan/Code/pl/ipfs/js-ipfs/node_modules/libp2p-pubsub/src/index.js:190:34)
at GossipSub._processMessages (/Users/alan/Code/pl/ipfs/js-ipfs/node_modules/libp2p-gossipsub/src/pubsub.js:120:12)
at runMicrotasks (<anonymous>)
at processTicksAndRejections (internal/process/task_queues.js:94:5)
```
alanshaw
requested review from
wemeetagain and
vasco-santos
and removed request for
wemeetagain
|
|
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=========================================
+ Coverage 83.6% 83.81% +0.2%
=========================================
Files 8 8
Lines 482 482
=========================================
+ Hits 403 404 +1
+ Misses 79 78 -1
Continue to review full report at Codecov.
|
alanshaw
pushed a commit
to libp2p/js-libp2p-floodsub
that referenced
this pull request
Jan 16, 2020
vasco-santos
previously requested changes
Jan 16, 2020
jacobheun
approved these changes
Jan 22, 2020
There was a problem hiding this comment.
This LGTM! I went ahead and created a PR at libp2p-pubsub to correct the jsdocs there for _processMessage, libp2p/js-libp2p-pubsub#35.
|
@wemeetagain can this fix be merged and released? 🙏 |
wemeetagain
dismissed
vasco-santos’s stale review
test has been added as requested
|
@wemeetagain any chance this can get released under the "beta" tag? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_onPeerDisconnectedis expecting aPeerInfobut it was being passed a pubsubPeer.I'm not sure if this is the correct fix but it resolves this error for me: