feat: add option to only remove exact duplicate property/values #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed a useless adition of const twice in the script which I added in my previous commit
ChristianMurphy
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
Thanks @MoltenCoffee! 🙇
Looks good, it could be nice to have another test case for a custom property/css variable.
Other than that this looks good to me 👍
Add test for CSS custom properties and fix spelling mistakes
ChristianMurphy
approved these changes
Sep 10, 2020
|
released in 9.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in 2017, aldebaran798 added the
removeDuplicatedPropertiesfeature. I propose to add a "soft" version of this, which I named (at least for now)removeDuplicatedValues.The difference in function is, that it will only remove duplicate properties when the values are equal as well. This way, it cleans up equal properties that came from duplicates of the same selector but allows for conscious duplicates like fallbacks for custom properties, as these have different values and thus won't be removed.