SIMPLE-7569 API changes for RBAC #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmikuska
commented
Mar 10, 2025
virl2_client/models/group.py
Outdated
| - members: The members of the group. | ||
| - labs: DEPRECATED: replaced by 'associations'. | ||
| The labs associated with the group. | ||
| - associations: The lab associations for the group. |
There was a problem hiding this comment.
"associations" are working name and I'm open to changes, "labs" didn't work because we already have "labs" in users for owned labs (it shouldn't be difficult to change that but this is easier and more clean to deprecate)
tmikuska
force-pushed
the
SIMPLE-7569-api-changes
branch
from
b8c4283 to
f6b87b3
Compare
tmikuska
force-pushed
the
SIMPLE-7569-api-changes
branch
from
f6b87b3 to
332ffcb
Compare
virlos
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.