Skip to content
This repository was archived by the owner on Apr 13, 2024. It is now read-only.

turn on objcopy by default for all targets #141

Merged
merged 2 commits into from
May 13, 2019
Merged

turn on objcopy by default for all targets #141

merged 2 commits into from
May 13, 2019

Conversation

nickdesaulniers
Copy link
Member

No description provided.

@nickdesaulniers nickdesaulniers added the WIP Work in progress label Mar 27, 2019
@nickdesaulniers
Copy link
Member Author

rerunning, as I think ClangBuiltLinux/linux#435 is now resolved.

@nathanchance
Copy link
Member

I don't think we don't have that patch in our clang build yet (version string says r360126, the patch is r360233). It should be there on the next refresh.

@nickdesaulniers nickdesaulniers removed the WIP Work in progress label May 9, 2019
@nickdesaulniers
Copy link
Member Author

@nathanchance I think we can merge this. Pre-existing failures are related to lld.

@nathanchance
Copy link
Member

Hmmm interesting, how did this pass? Clang wasn't refreshed last night according to apt.llvm.org so nothing should have changed...

@nickdesaulniers
Copy link
Member Author

oh, we probably fail the -n lld check for arm64 before we hit the objcopy issue.

Copy link
Member

@nathanchance nathanchance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, the LLVM toolchain has been refreshed so this should pass when -n is added to lld. I should write a script to do our Travis builds locally...

@nickdesaulniers nickdesaulniers merged commit d671e7d into master May 13, 2019
@nickdesaulniers nickdesaulniers deleted the objcopy branch May 13, 2019 20:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants