driver: Enable llvm-objcopy and llvm-strip #253
Conversation
except for s390, which does not appear to have any support for it in the LLVM tools. Tested locally with build-all.sh. [skip ci] Closes: ClangBuiltLinux#212 Closes: ClangBuiltLinux#249 Signed-off-by: Nathan Chancellor <[email protected]>
|
For s390 you set |
|
Yes and no. I intentionally left it out because it does not appear to be used during a build (I have not seen an error). I can add it if you feel it necessary. |
|
If it's not used during the build, no need to add it. I was just concerned because this pull request doesn't mention objdump anywhere else. |
|
Ah, gotcha. The objdump one is ClangBuiltLinux/linux#859 and it has been there since we added s390 support. |
There was a problem hiding this comment.
cool, so we'll still need to turn this on in the travis yaml? Also, I might prefer to just fail the build if we're using an old binutils. Kbuild doesn't have that fallback behavior, and I worry that things might be broken with the llvm utils and we don't notice because no alarms go off, because we've just been falling back. Basically, it's a vote against supporting older versions. But that doesn't need to block this patch. 🚅
Nope, it is enabled by default now.
Sure, I can push a patch after I merge this. |
rereads code got it, just not s390, I see. |
except for s390, which does not appear to have any support for it in
the LLVM tools.
Tested locally with build-all.sh.
Closes: #212
Closes: #249