Skip to content

Add some distribution configurations #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 8, 2021

Conversation

nathanchance
Copy link
Member

Arch, Fedora, and OpenSUSE to start because their configurations are easily accessible from the web.

This is currently blocked on https://gitlab.com/Linaro/tuxsuite/-/issues/124 in its current form, I am just pushing for early review.

@nathanchance nathanchance force-pushed the distro-configs branch 2 times, most recently from 3c0fda4 to f4ac98e Compare July 30, 2021 20:06
@nathanchance nathanchance marked this pull request as ready for review July 30, 2021 20:14
@nathanchance
Copy link
Member Author

https://gitlab.com/Linaro/tuxsuite/-/issues/124 has been resolved so we can do this now.

Certain builds are broken in -next but that is just -next for ya :^)

Copy link
Member

@nickdesaulniers nickdesaulniers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we boot test these too, please? Or don't they boot?

@nathanchance
Copy link
Member Author

can we boot test these too, please? Or don't they boot?

They should boot fine as I boot test these locally but I will have to modify the logic in get_cbl_name() to account for these. Let me think about how to do that.

@nathanchance
Copy link
Member Author

Alright, I believe this should work fine, as get_cbl_name() returns what I would expect it to.

Rather than checking if the entry exists in the map and using the value
of the architecture in the URL if not, just add the entries to the map
and always return from the map. This is a little bit more verbose but
there will be a more obvious error if we add an architecture without
supporting it here.

Suggested-by: Nick Desaulniers <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
@nathanchance
Copy link
Member Author

I am going to merge this without explicit approval after our conversation offline. Please scream if you see anything wrong after the fact and I am more than happy to push subsequent fixups.

@nathanchance nathanchance merged commit 16571e4 into ClangBuiltLinux:main Aug 8, 2021
@nathanchance nathanchance deleted the distro-configs branch August 8, 2021 19:39
@nathanchance
Copy link
Member Author

I pushed f9f368d to make the build green. I am not sure it warrants an investigation on our part given it happens with GCC but I can open a follow up issue if you feel it is worth looking into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants