-
Notifications
You must be signed in to change notification settings - Fork 8
Add some distribution configurations #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some distribution configurations #172
Conversation
3c0fda4
to
f4ac98e
Compare
https://gitlab.com/Linaro/tuxsuite/-/issues/124 has been resolved so we can do this now. Certain builds are broken in -next but that is just -next for ya :^) |
…ith clang 11+ Closes: ClangBuiltLinux#25 Signed-off-by: Nathan Chancellor <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
f4ac98e
to
0fc784b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we boot test these too, please? Or don't they boot?
They should boot fine as I boot test these locally but I will have to modify the logic in |
…ance Signed-off-by: Nathan Chancellor <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
Alright, I believe this should work fine, as |
Signed-off-by: Nathan Chancellor <[email protected]>
Rather than checking if the entry exists in the map and using the value of the architecture in the URL if not, just add the entries to the map and always return from the map. This is a little bit more verbose but there will be a more obvious error if we add an architecture without supporting it here. Suggested-by: Nick Desaulniers <[email protected]> Signed-off-by: Nathan Chancellor <[email protected]>
I am going to merge this without explicit approval after our conversation offline. Please scream if you see anything wrong after the fact and I am more than happy to push subsequent fixups. |
I pushed f9f368d to make the build green. I am not sure it warrants an investigation on our part given it happens with GCC but I can open a follow up issue if you feel it is worth looking into. |
Arch, Fedora, and OpenSUSE to start because their configurations are easily accessible from the web.
This is currently blocked on https://gitlab.com/Linaro/tuxsuite/-/issues/124 in its current form, I am just pushing for early review.