Split GitHub Actions and TuxSuite by toolchain version #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to run |
nathanchance
force-pushed
the
split-by-clang-version
branch
from
68c4cfb to
1c38e1f
Compare
|
Thank you for the review! I have gone ahead and addressed all your comments via |
nathanchance
force-pushed
the
split-by-clang-version
branch
from
281fbff to
cde0fca
Compare
We are going to be writing the workflows via write() eventually so we
might as well read from generator.yml as well to simplify running
generate_{tuxsuite,workflow}.py.
Signed-off-by: Nathan Chancellor <[email protected]>
…stdout We are going to be splitting up the GitHub Actions and TuxSuite files per tree + toolchain, rather than just tree. To make this easier, move the writing of the generated files into the Python files, rather than the shell script, to make this logic easier. Signed-off-by: Nathan Chancellor <[email protected]>
Currently, the GitHub Actions and TuxSuite files are per tree, which causes issues for a couple of reasons: 1. We are running out of jobs on the mainline and next matrices, as GitHub Actions only allows 256 jobs per one workflow matrix. 2. It makes triaging failures a little more difficult, as we have to navigate GitHub Actions' UI for over two hundred builds. For example, the recent arm64 assertion failure on clang-nightly caused all the trees to appear red, even though it was just a clang-nightly failure. By splitting these files up by tree plus toolchain version, we can more accurately see the health of all the trees and we won't hit the GitHub Actions limit. Signed-off-by: Nathan Chancellor <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
nathanchance
force-pushed
the
split-by-clang-version
branch
from
cde0fca to
89bcbbb
Compare
nathanchance
added a commit
to nathanchance/containers
that referenced
this pull request
Feb 17, 2022
I added a yaml import to utils.py in ClangBuiltLinux/continuous-integration2#302. utils.py is used within check_logs.py, which runs in this container so we need this package there. Link: https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1855945810 Signed-off-by: Nathan Chancellor <[email protected]>
This was referenced Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series changes how our GitHub Actions and TuxSuite files are structured to make it easier to triage build failures and see the overall health of the trees we test and to avoid hitting GitHub Actions' job limit in our matrices.
The first two patches move the reading of generator.yml and writing of the GitHub Actions workflow and TuxSuite files into the Python scripts, rather than using stdin and stdout so that we can easily write to multiple files.
The third patch does the actual split by checking what LLVM versions the tree is being tested with and generating a file based on just those builds.
generate.shandcheck-patches.share adjusted to account for this.Finally, the fourth and fifth patch does the regeneration and updates the README.