-
Notifications
You must be signed in to change notification settings - Fork 8
Add support for ARCH=um
#337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you remove the closes tag, then in a follow up, we can work on boot testing this?
Probably want to update some docs. Homepage and kernel docs? |
Sure, I can remove the closes tag. I don't think that we can boot test this with our current flow, as UML is a virtual machine within itself, so we would not use QEMU for testing. I'll look into that tomorrow. |
Right, I'm pretty sure it's just an ELF executable. You just run the image and pass it command line parameters. |
Yup, I have this working locally:
I will wire this up into boot-utils shortly as |
5595c39
to
627cc21
Compare
Alright, this now depends on ClangBuiltLinux/boot-utils#59. Once that is good to go, I'll bump |
Signed-off-by: Nathan Chancellor <[email protected]>
Closes: ClangBuiltLinux#332 Signed-off-by: Nathan Chancellor <[email protected]>
627cc21
to
87dedc8
Compare
Alright, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! consider dropping all the intermediary regen patches that just churn the dotfiles. 🛡️ 🚢
Signed-off-by: Nathan Chancellor <[email protected]>
This will allow us to fetch the UML image for boot testing. Signed-off-by: Nathan Chancellor <[email protected]>
ARCH=um does not use QEMU for booting, as it is designed to run as a regular binary in user space. Use the newly created boot-uml.sh to allow us to test booting ARCH=um kernels in CI. Signed-off-by: Nathan Chancellor <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
412a497
to
1003132
Compare
Thanks for the review as always! |
Now that
ARCH=um
builds with clang, let's make sure it stays working!NOTE: This PR depends on this PR for mainline; once it is merged, this one can be too.