Add ruff.toml and clean up warnings #519
Conversation
Yeah, sorry, that should read and the |
Can we just disable that check and drop the commit that added trailing commas? They make sense IMO when defining members of an array, so that additions in later commits don't modify the |
|
Sure, I figured it was a useful check that would result in some churn up front and not too much latter but I do not care too much. |
This is an opinionated set of warnings from the full list that ruff supports. Link: https://beta.ruff.rs/docs/rules/ Signed-off-by: Nathan Chancellor <[email protected]>
Fixes a ruff warning: generate.py:25:17: RUF005 [*] Consider `[*trees, 'all']` instead of concatenation Signed-off-by: Nathan Chancellor <[email protected]>
Fixes new ruff warning: check_logs.py:148:13: PLW2901 Outer for loop variable `line` overwritten by inner assignment target This warning is in pylint as well, but it is not enabled under the default configuration. Additionally, simplify the check for an empty line. We can use the walrus operator plus the truthiness of the empty string instead of assigning and checking the length separately. Signed-off-by: Nathan Chancellor <[email protected]>
Signed-off-by: Nathan Chancellor <[email protected]>
ruffis a fast Python linter written in Rust. Add aruff.tomlfile to turn on several classes of warnings that are useful and fix them up.