-
Notifications
You must be signed in to change notification settings - Fork 8
Combine certain YAML files further #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine certain YAML files further #692
Conversation
These two are tightly coupled, so keep them together in the same file. Signed-off-by: Nathan Chancellor <[email protected]>
The ChromeOS and KASAN config definitions are tightly coupled to the main configs file, so keep them together in the same file. If more config sections need to be added, this makes it quite easy to do so. Signed-off-by: Nathan Chancellor <[email protected]>
Now that some files have been combined, rename the files to fill the numeric gaps. Signed-off-by: Nathan Chancellor <[email protected]>
Taking a look at the repo as a whole, maybe these I think it may also be worth combining all the |
Yeah I was just think that as I am writing out documentation. I think I will push a restructuring as part of that pull request.
Having separate files for each LLVM version in the matrix was the main desire from breaking apart |
I'm now thinking of some new system where we don't have to specify every single build for each llvm version. Maybe some syntax like: {<< : *arm32_v5, << : *mainline, << : *llvm, boot: true, << : *llvm_all} # specifies all supported llvm versions
{<< : *arm32_v7, << : *mainline, << : *llvm_full, boot: true, << : *llvm_13, *llvm_14, *llvm_15} # only do builds for 13, 14, 15 We could reduce our file sizes by a lot and more easily see at a glance what versions a build runs on (and it'd all be one file). I have NO idea if yml supports this type of thing or if we would need to invent another system. Thoughts? edit: I realize there may be some issues with granularity when setting other options like |
This is tentatively what I have as the structure I am writing documentation around now:
|
I think
tree_schedules
should be a part oftrees
and thechromeos_configs
andkasan_configs
should be a part ofconfigs
. This slims up the number of overall files and puts things that should be updated together in the same file.