Skip to content

EXPORT_SYMBOL warnings in vmlinux #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ms178 opened this issue Jul 30, 2019 · 3 comments
Closed

EXPORT_SYMBOL warnings in vmlinux #623

ms178 opened this issue Jul 30, 2019 · 3 comments
Labels
[ARCH] x86_64 This bug impacts ARCH=x86_64 wontfix This will not be worked on

Comments

@ms178
Copy link

ms178 commented Jul 30, 2019

Testing with -O2, linux-next-next-20190730 and clang version 10.0.0 (366783) revealed this issue.

buildlog_o2.txt

The build now errors out at the end with:

WARNING: "phys_base" [vmlinux] is the static EXPORT_SYMBOL
WARNING: "ahci_em_messages" [vmlinux] is the static EXPORT_SYMBOL_GPL
WARNING: "ftrace_set_clr_event" [vmlinux] is the static EXPORT_SYMBOL_GPL
WARNING: "empty_zero_page" [vmlinux] is the static EXPORT_SYMBOL
WARNING: "hypercall_page" [vmlinux] is the static EXPORT_SYMBOL_GPL
MODINFO modules.builtin.modinfo

Here is the config used:
config.txt

Originally posted by @ms178 in #621 (comment)
@ms178 ms178 added the [ARCH] x86_64 This bug impacts ARCH=x86_64 label Jul 30, 2019
@ms178
Copy link
Author

ms178 commented Jul 30, 2019 •
edited
Loading

Testing with -O2, linux-next-next-20190730, the same config and lld instead of GNU ld shows the same error.

MODPOST vmlinux.o
WARNING: "phys_base" [vmlinux] is the static EXPORT_SYMBOL
WARNING: "ahci_em_messages" [vmlinux] is the static EXPORT_SYMBOL_GPL
WARNING: "ftrace_set_clr_event" [vmlinux] is the static EXPORT_SYMBOL_GPL
WARNING: "empty_zero_page" [vmlinux] is the static EXPORT_SYMBOL
WARNING: "hypercall_page" [vmlinux] is the static EXPORT_SYMBOL_GPL
MODINFO modules.builtin.modinfo

buildlog_lld.txt

@ms178 ms178 mentioned this issue Jul 30, 2019
Closed
@nathanchance
Copy link
Member

This is not a clang issue: https://git.kernel.org/next/linux-next/c/1a288d0d920dfb9747bbefc8d601a971885f470f

@ms178
Copy link
Author

ms178 commented Jul 31, 2019 •
edited
Loading

Thanks Nathan, l will close both issues then.

@ms178 ms178 closed this as completed Jul 31, 2019
@ms178 ms178 added the wontfix This will not be worked on label Jul 31, 2019
nathanchance pushed a commit that referenced this issue Jul 18, 2020
@TaeheeYoo @davem330
hsr: fix interface leak in error path of hsr_dev_finalize()
ccfc9df 
To release hsr(upper) interface, it should release
its own lower interfaces first.
Then, hsr(upper) interface can be released safely.
In the current code of error path of hsr_dev_finalize(), it releases hsr
interface before releasing a lower interface.
So, a warning occurs, which warns about the leak of lower interfaces.
In order to fix this problem, changing the ordering of the error path of
hsr_dev_finalize() is needed.

Test commands:
    ip link add dummy0 type dummy
    ip link add dummy1 type dummy
    ip link add dummy2 type dummy
    ip link add hsr0 type hsr slave1 dummy0 slave2 dummy1
    ip link add hsr1 type hsr slave1 dummy2 slave2 dummy0

Splat looks like:
[  214.923127][    C2] WARNING: CPU: 2 PID: 1093 at net/core/dev.c:8992 rollback_registered_many+0x986/0xcf0
[  214.923129][    C2] Modules linked in: hsr dummy openvswitch nsh nf_conncount nf_nat nf_conntrack nf_defrag_ipx
[  214.923154][    C2] CPU: 2 PID: 1093 Comm: ip Not tainted 5.8.0-rc2+ #623
[  214.923156][    C2] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006
[  214.923157][    C2] RIP: 0010:rollback_registered_many+0x986/0xcf0
[  214.923160][    C2] Code: 41 8b 4e cc 45 31 c0 31 d2 4c 89 ee 48 89 df e8 e0 47 ff ff 85 c0 0f 84 cd fc ff ff 5
[  214.923162][    C2] RSP: 0018:ffff8880c5156f28 EFLAGS: 00010287
[  214.923165][    C2] RAX: ffff8880d1dad458 RBX: ffff8880bd1b9000 RCX: ffffffffb929d243
[  214.923167][    C2] RDX: 1ffffffff77e63f0 RSI: 0000000000000008 RDI: ffffffffbbf31f80
[  214.923168][    C2] RBP: dffffc0000000000 R08: fffffbfff77e63f1 R09: fffffbfff77e63f1
[  214.923170][    C2] R10: ffffffffbbf31f87 R11: 0000000000000001 R12: ffff8880c51570a0
[  214.923172][    C2] R13: ffff8880bd1b90b8 R14: ffff8880c5157048 R15: ffff8880d1dacc40
[  214.923174][    C2] FS:  00007fdd257a20c0(0000) GS:ffff8880da200000(0000) knlGS:0000000000000000
[  214.923175][    C2] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  214.923177][    C2] CR2: 00007ffd78beb038 CR3: 00000000be544005 CR4: 00000000000606e0
[  214.923179][    C2] Call Trace:
[  214.923180][    C2]  ? netif_set_real_num_tx_queues+0x780/0x780
[  214.923182][    C2]  ? dev_validate_mtu+0x140/0x140
[  214.923183][    C2]  ? synchronize_rcu.part.79+0x85/0xd0
[  214.923185][    C2]  ? synchronize_rcu_expedited+0xbb0/0xbb0
[  214.923187][    C2]  rollback_registered+0xc8/0x170
[  214.923188][    C2]  ? rollback_registered_many+0xcf0/0xcf0
[  214.923190][    C2]  unregister_netdevice_queue+0x18b/0x240
[  214.923191][    C2]  hsr_dev_finalize+0x56e/0x6e0 [hsr]
[  214.923192][    C2]  hsr_newlink+0x36b/0x450 [hsr]
[  214.923194][    C2]  ? hsr_dellink+0x70/0x70 [hsr]
[  214.923195][    C2]  ? rtnl_create_link+0x2e4/0xb00
[  214.923197][    C2]  ? __netlink_ns_capable+0xc3/0xf0
[  214.923198][    C2]  __rtnl_newlink+0xbdb/0x1270
[ ... ]

Fixes: e0a4b99 ("hsr: use upper/lower device infrastructure")
Reported-by: [email protected]
Signed-off-by: Taehee Yoo <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[ARCH] x86_64 This bug impacts ARCH=x86_64 wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nathanchance @ms178