bug: fix choosing an out of list bounds selecting the last entry #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple bug fix that changes the behaviour of a scroll select (and column select) to only update if the updated position is _within_ the bounds of the list (0 to the max index, inclusive). Prior to this, all the implementations but the disk implementation would just bound the change. This was both inconsistent with the disk scroll state, but also jarring since this meant a user could click on seemingly empty space but it would somehow click on the very last entry. This change also unifies the scroll calculation function between all the scroll select functions. Ideally we get rid of the intermediary functions but that might require more refactoring than I want for this fairly simple bug fix. The column select scroll calculation was also changed to fit this behaviour, but it does not use the same logic as the other scroll states. What could be done in the future is a generic implementation for direction (or maybe just "increment vs. decrement") to share it all.
ClementTsang
force-pushed
the
fix_click_bug
branch
from
81a3fc5 to
ad0aeed
Compare
Codecov Report
@@ Coverage Diff @@
## master #717 +/- ##
==========================================
+ Coverage 17.14% 17.55% +0.40%
==========================================
Files 52 52
Lines 13215 13217 +2
==========================================
+ Hits 2266 2320 +54
+ Misses 10949 10897 -52
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:
This is a simple bug fix that changes the behaviour of a scroll select (and column select) to only update if the updated position is within the bounds of the list (0 to the max index, inclusive). Prior to this, all the implementations but the disk implementation would just bound the change. This was both inconsistent with the disk scroll state, but also jarring since this meant a user could click on seemingly empty space but it would somehow click on the very last entry.
This change also unifies the scroll calculation function between all the scroll select functions. Ideally we get rid of the intermediary functions but that might require more refactoring than I want for this fairly simple bug fix.
The column select scroll calculation was also changed to fit this behaviour, but it does not use the same logic as the other scroll
states. What could be done in the future is a generic implementation for direction (or maybe just "increment vs. decrement") to share it all.
Issue
If applicable, what issue does this address?
Closes: #
Testing
If relevant, please state how this was tested. All changes must be tested to work:
Please also indicate which platforms were tested. All platforms directly affected by the change must be tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, etc.)