Skip to content

other: change non-normalized shortcut #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Nov 22, 2022

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

p -> n to reflect the name change

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang marked this pull request as ready for review November 22, 2022 09:36
@ClementTsang ClementTsang force-pushed the change_unnormalized_shortcut branch from 5f5391c to 260fcfd Compare November 22, 2022 09:37
@codecov-commenter
Copy link

Codecov Report

Base: 19.46% // Head: 19.45% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (260fcfd) compared to base (a0eebf3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
- Coverage   19.46%   19.45%   -0.02%     
==========================================
  Files          74       74              
  Lines       13923    13921       -2     
==========================================
- Hits         2710     2708       -2     
  Misses      11213    11213              
Impacted Files Coverage Δ
src/clap.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang force-pushed the change_unnormalized_shortcut branch from 260fcfd to 415349a Compare November 22, 2022 09:44
@ClementTsang ClementTsang changed the title other: disable unnormalized short name for now other: change non-normalized shortcut Nov 22, 2022
@ClementTsang ClementTsang merged commit 27fc7a7 into master Nov 22, 2022
@ClementTsang ClementTsang deleted the change_unnormalized_shortcut branch November 22, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants