Skip to content

task(SDK-4889): Ignore UI related classes from unit test coverage #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
268 changes: 268 additions & 0 deletions .run/All Tests.run.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,268 @@
<component name="ProjectRunConfigurationManager">
<configuration default="false" name="All Tests" type="GradleRunConfiguration" factoryName="Gradle">
<ExternalSystemSettings>
<option name="executionName" />
<option name="externalProjectPath" value="$PROJECT_DIR$" />
<option name="externalSystemIdString" value="GRADLE" />
<option name="scriptParameters" value="" />
<option name="taskDescriptions">
<list />
</option>
<option name="taskNames">
<list>
<option value=":clevertap-core:testDebugUnitTest" />
<option value="--tests" />
<option value="&quot;com.clevertap.android.sdk.*&quot;" />
<option value=":clevertap-geofence:testDebugUnitTest" />
<option value="--tests" />
<option value="&quot;com.clevertap.android.geofence.*&quot;" />
<option value=":clevertap-hms:testDebugUnitTest" />
<option value="--tests" />
<option value="&quot;com.clevertap.android.hms.*&quot;" />
<option value=":clevertap-pushtemplates:testDebugUnitTest" />
<option value="--tests" />
<option value="&quot;com.clevertap.android.pushtemplates.*&quot;" />
</list>
</option>
<option name="vmOptions" />
</ExternalSystemSettings>
<ExternalSystemDebugServerProcess>false</ExternalSystemDebugServerProcess>
<ExternalSystemReattachDebugProcess>true</ExternalSystemReattachDebugProcess>
<EXTENSION ID="com.intellij.execution.ExternalSystemRunConfigurationJavaExtension">
<extension name="coverage">
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.customviews.*" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.geofence.BuildConfig" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.hms.BuildConfig" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.pushtemplates.BuildConfig" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.BuildConfig" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.shared.test.BuildConfig" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.geofence.Logger" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.Logger" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.pushtemplates.content.*" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.pushtemplates.styles.*" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.InAppNotificationActivity" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inbox.CTInboxActivity" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.InAppWebViewClient" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppHtmlFooterFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppHtmlHeaderFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppHtmlInterstitialFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppHtmlHalfInterstitialFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppBasePartialFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppHtmlCoverFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppNativeCoverFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppBaseFullNativeFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppBasePartialNativeFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppNativeHeaderFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppNativeFooterFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppNativeInterstitialImageFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppNativeCoverFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppNativeHalfInterstitialImageFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppBasePartialHtmlFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppBaseFullHtmlFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppBaseFullFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppWebView" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppNativeHalfInterstitialFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppNativeInterstitialFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inapp.CTInAppNativeCoverImageFragment" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inbox.CTInboxTabAdapter" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inbox.CTCarouselViewPager" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inbox.CTInboxMessageAdapter" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inbox.CTCarouselViewPagerAdapter" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inbox.CTInboxButtonClickListener" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inbox.CTCarouselImageViewHolder" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inbox.CTCarouselMessageViewHolder" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inbox.CTInboxBaseMessageViewHolder" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inbox.CTSimpleMessageViewHolder" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.sdk.inbox.CTIconMessageViewHolder" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.hms.CTHmsMessageService" />
<option name="ENABLED" value="true" />
<option name="INCLUDE" value="false" />
</pattern>
<pattern>
<option name="PATTERN" value="com.clevertap.android.*" />
<option name="ENABLED" value="true" />
</pattern>
Comment on lines +259 to +261
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Missing INCLUDE flag on final coverage pattern
The last pattern for com.clevertap.android.* only specifies ENABLED but omits <option name="INCLUDE" value="false"/>, which is required to exclude it.

🤖 Prompt for AI Agents
In the file .run/All Tests.run.xml around lines 259 to 261, the final coverage
pattern for com.clevertap.android.* is missing the INCLUDE flag. Add the option
<option name="INCLUDE" value="false"/> inside the pattern element to explicitly
exclude this pattern as intended.

</extension>
</EXTENSION>
<DebugAllEnabled>false</DebugAllEnabled>
<RunAsTest>true</RunAsTest>
<method v="2" />
</configuration>
</component>
60 changes: 41 additions & 19 deletions gradle-scripts/jacoco_root.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -20,37 +20,59 @@ ext.excludes = [
'**/android/databinding/*Binding.class',
'**/android/databinding/*',
'**/androidx/databinding/*',
'**/BR.*',
// android
'**/R.class',
'**/R$*.class',
'**/BuildConfig.*',
'**/Manifest*.*',
'**/*Test*.*',
'android/**/*.*',
// kotlin
'**/*MapperImpl*.*',
'**/*$ViewInjector*.*',
'**/*$ViewBinder*.*',
'**/BuildConfig.*',
'**/*Component*.*',
'**/*BR*.*',
'**/Manifest*.*',
'**/*$Lambda$*.*',
'**/*Companion*.*',
'**/*Module*.*',
'**/*Dagger*.*',
'**/*Hilt*.*',
'**/*MembersInjector*.*',
'**/*_MembersInjector.class',
'**/*_Factory*.*',
'**/*_Provide*Factory*.*',
'**/*Extensions*.*',
// sealed and data classes
'**/*$Result.*',
'**/*$Result$*.*',
// adapters generated by moshi
'**/*JsonAdapter.*',
// CT ignore
'com/clevertap/android/sdk/customviews/**',
'com/clevertap/android/geofence/Logger*.*',
'com/clevertap/android/sdk/Logger*.*',
'com/clevertap/android/pushtemplates/content/**',
'com/clevertap/android/pushtemplates/styles/**',
'com/clevertap/android/sdk/InAppNotificationActivity*.*',
'com/clevertap/android/sdk/inbox/CTInboxActivity*.*',
'com/clevertap/android/sdk/inapp/InAppWebViewClient*.*',
'com/clevertap/android/sdk/inapp/CTInAppHtmlFooterFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppHtmlHeaderFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppHtmlInterstitialFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppHtmlHalfInterstitialFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppBasePartialFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppHtmlCoverFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppNativeCoverFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppBaseFullNativeFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppBasePartialNativeFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppNativeHeaderFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppNativeFooterFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppNativeInterstitialImageFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppNativeCoverFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppNativeHalfInterstitialImageFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppBasePartialHtmlFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppBaseFullHtmlFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppBaseFullFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppWebView*.*',
'com/clevertap/android/sdk/inapp/CTInAppNativeHalfInterstitialFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppNativeInterstitialFragment*.*',
'com/clevertap/android/sdk/inapp/CTInAppNativeCoverImageFragment*.*',
'com/clevertap/android/sdk/inbox/CTInboxTabAdapter*.*',
'com/clevertap/android/sdk/inbox/CTCarouselViewPager*.*',
'com/clevertap/android/sdk/inbox/CTInboxMessageAdapter*.*',
'com/clevertap/android/sdk/inbox/CTCarouselViewPagerAdapter*.*',
'com/clevertap/android/sdk/inbox/CTInboxButtonClickListener*.*',
'com/clevertap/android/sdk/inbox/CTCarouselImageViewHolder*.*',
'com/clevertap/android/sdk/inbox/CTCarouselMessageViewHolder*.*',
'com/clevertap/android/sdk/inbox/CTInboxBaseMessageViewHolder*.*',
'com/clevertap/android/sdk/inbox/CTSimpleMessageViewHolder*.*',
'com/clevertap/android/sdk/inbox/CTIconMessageViewHolder*.*',
'com/clevertap/android/hms/CTHmsMessageService*.*'
]
def createVariantCoverage(variant) {
def variantName = variant.name
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ android.defaults.buildfeatures.buildconfig=true
android.nonFinalResIds=false
android.nonTransitiveRClass=false
android.useAndroidX=true
org.gradle.jvmargs=-Xmx4g
org.gradle.jvmargs=-Xmx8g
Loading