-
Notifications
You must be signed in to change notification settings - Fork 55
Update master with release 3.0.0 #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SDK-4159-Add-File-Vars
- wip commit - detailed message in following
- fixes map passed as arg and uses string templatename instead as we have all utils around templateName - adds dep for open File to check file open - revamps sample app to show correct build - uses lambdas to call ct methods - all methods testing using Example Template https://sk1-dashboard-staging-30.dashboard.clevertap.com/67Z-RRK-696Z/campaigns/campaign/1733746830/report/stats/trend
- lists were not needed for handlers. - addresses minor naming methods/fields
- Adds kotlin support in clevertap plugin - Uses EventEmitter+ClevertapEvent+CleverTapListenerProxy from RN project - plugs middleware classes to flutter framework callbacks - Breaks down legacy class of clevertap flutter plugin → it implements too many interfaces and no SOC - Plugin callback and setup Clevertap in one single place - Split out native to dart callers - Split out dart to native callers
- plugs eventemitter methods to clevertap plugin class - cleans redundant code - creates static handler and single instead of creating new one all the time - moves variables map to refactored class
- Adds a nul check before .toString
- makes changes to plugin class to attach and remove buffers - makes changes to build to include correct core-ktx version - formatting in some cases
- method call names are used correctly - validates the same from plugin file - adds todo for beforeshow
Fix/git 275/npe for map to bundle
* feat(SDK-4217): Flushing logic changed for buffers - flushing and disable buffer is done once the client is setting the listener - emits event in setters to invoke dart -> native code which clears buffer flag and flushes - adds enum entry unknown for clean code handling - adds safety check in emitter to not send unknown events - changes main.dart to introduce constants for startup delays - changes order of listeners in example app just to make it more readable * feat(SDK-4217): Uses 5 seconds delay to rest buffers + comments - resets all buffers after 5 seconds on delay. - addresses pr comments by @vasko regarding redundant logs * feat(SDK-4217): Removes redundant method - invoke method on ui thread had overrides and not sure why they were needed * feat(SDK-4217): uses jvmstatic * feat(SDK-4217): fixes pr comments and todos - addresses todos - unused fields removal - naming changes - makes push amp bufferable
- removes creds - fixes mismatch in kotlin versions
- moves java to kotlin
feat(SDK-4200): Adds changes for custom code templates
Updated clevertap_plugin file for custom templates
Add file type support and update core to 7.0.3
Create CustomCodeTemplates.md documentation
task(SDK-4198) - Release v3.0.0
- adds file vars defs - adds no downloads pending calls stuff
Docs/file vars changes
Anush-Shand
approved these changes
Dec 19, 2024
kushCT
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wizrocket.atlassian.net/browse/SDK-4198