Skip to content

Remove raredisease adapter QC check #4325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

Remove raredisease adapter QC check #4325

merged 2 commits into from
Apr 23, 2025

Conversation

peterpru
Copy link
Member

@peterpru peterpru commented Apr 4, 2025

Description

As discussed with @karlnyr and @ramprasadn . Production has decided that adapter content should not fail an analysis and be tracked in a different way instead. This PR removes the current nf/raredisease adapter contamination QC check. This in essence removes the adapter additions found in PR #4183.

Added

Changed

  • remove raredisease adapter QC check

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@peterpru peterpru added production raredisease Issues related to nextflow raredisease pipeline labels Apr 4, 2025
@peterpru peterpru self-assigned this Apr 4, 2025
@peterpru peterpru marked this pull request as ready for review April 4, 2025 10:12
@peterpru peterpru requested a review from a team as a code owner April 4, 2025 10:12
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@peterpru peterpru merged commit b7d7583 into master Apr 23, 2025
10 checks passed
@peterpru peterpru deleted the prod-remove-adapter-QC branch April 23, 2025 11:22
@peterpru
Copy link
Member Author

stage:
image

@peterpru
Copy link
Member Author

Prod:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
production raredisease Issues related to nextflow raredisease pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants