add Raredisease order type to database

[diitaz93]

Description

Closes #4364

Added

• Raredisease to the OrderType Strenum
• Alembic migration to allow new ordertype in the order_type_application table

How to prepare for test

• Ssh to relevant server (depending on type of change)
• Use stage: us
• Paxa the environment: paxa
• Deploy on CGVS-stage
• Install on stage (example for Hasta):

  bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b add-raredisease-ordertype -a

How to test

• Do alembic -c $ALEMBIC_CG_STAGE upgrade 039dbdf8af01
• Add an entry containing RAREDISEASE to the order_type_application table
• Do alembic -c $ALEMBIC_CG_STAGE downgrade -1 head

Expected test outcome

• Check that the upgrade went without errors

jsdiazboada@juasebmbp cg % alembic -c $ALEMBIC_CG_STAGE upgrade 039dbdf8af01                   
INFO  [alembic.runtime.migration] Context impl MySQLImpl.
INFO  [alembic.runtime.migration] Will assume non-transactional DDL.
INFO  [alembic.runtime.migration] Running upgrade 6362cfd4c61f -> 039dbdf8af01, add Raredisease ordertype
(cg-py3.11) (base) jsdiazboada@juasebmbp cg % 

• In admin view in statusdb the new entry appears

• Check that the downgrade went without errors and deletes the new entries

 jsdiazboada@juasebmbp cg % alembic -c $ALEMBIC_CG_STAGE downgrade -1
INFO  [alembic.runtime.migration] Context impl MySQLImpl.
INFO  [alembic.runtime.migration] Will assume non-transactional DDL.
INFO  [alembic.runtime.migration] Running downgrade 039dbdf8af01 -> 6362cfd4c61f, add Raredisease ordertype
(cg-py3.11) (base) jsdiazboada@juasebmbp cg %

Review

• Tests executed by SD
• "Merge and deploy" approved by IO
  Thanks for filling in who performed the code review and the test!

This version is a

• MINOR - when you add functionality in a backwards compatible manner

Implementation Plan

• Deployed to stage:

• Deployed to production:

[islean]

Looks good to me!

[islean]

Just out of curiosity - the primary key of the OrderTypeApplication table is a composite key over both order type and application. Should order_type be marked as primary?

[diitaz93]

The key is defined as primary in the definition of the store model, so I would say so:

class OrderTypeApplication(Base):
    """Maps an order type to its allowed applications"""

    __tablename__ = "order_type_application"

    order_type: Mapped[OrderType] = mapped_column(sqlalchemy.Enum(OrderType), primary_key=True)
    application_id: Mapped[int] = mapped_column(
        ForeignKey("application.id", ondelete="CASCADE"), primary_key=True
    )
    application: Mapped[Application] = orm.relationship(
        "Application", back_populates="order_type_applications"
    )

but not sure if I should include the application in the migration model. I assumed not as I don't need it

[islean]

If it works it works! Just surprised me a bit

[diitaz93]

it works!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud