Skip to content

Update RML form to v20 #4371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 8, 2025
Merged

Update RML form to v20 #4371

merged 9 commits into from
May 8, 2025

Conversation

islean
Copy link
Contributor

@islean islean commented Apr 29, 2025

Description

We have a new version of the RML/Fluffy order form. This PR bumps the version, adds the new index sequence and adds an endpoint for fetching the index sequences.

Added

  • Endpoint /orders/index_sequences for fetching index sequences

Changed

  • RML and Fluffy orders need to use v20 of the order form

Fixed

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean islean marked this pull request as ready for review April 29, 2025 12:15
@islean islean requested a review from a team as a code owner April 29, 2025 12:15
Copy link
Contributor

@Vince-janv Vince-janv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to remove this from the FE 👍

Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 👍

@clingen-sthlm clingen-sthlm temporarily deployed to stage May 7, 2025 13:06 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage May 7, 2025 14:43 Inactive
@islean
Copy link
Contributor Author

islean commented May 7, 2025

Tested with https://github.com/Clinical-Genomics/clinical-genomics-ui/pull/756:

Upload successful:
image

New indices parsed:
image

Order submitted:
image

Copy link

sonarqubecloud bot commented May 8, 2025

@islean islean merged commit 6126722 into master May 8, 2025
10 checks passed
@islean islean deleted the update-rml-form branch May 8, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants