fix: properly read docker task config from service props & task props #1616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #1251 an issue regarding docker configs was resolved. The docker configuration was only read from the service props which is not used by default. The properties are only present in the task and not the service. This PR now fixes the issue and brings support to resolve the config from service & task properties.
Modification
Added a three step process to figure out which configuration to use when resolving properties that might be task / service specific.
The order is now:
Service -> Task (if present) -> Module Config
Result
The configuration is read correctly