Additional tests for login endpoint (fixes #199) #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magul
approved these changes
Nov 9, 2019
| ) | ||
|
|
||
| response = rv.get_json() | ||
| assert rv.status_code == HTTPStatus.UNAUTHORIZED |
There was a problem hiding this comment.
I'm going probably to merge this pull request as tests are passing but I would propose to consider if that's the best status code semantically speaking.
What do you think about 403 FORBIDDEN as user is authorized to the system but forbidden to use this particular resource twice? We can also send more generic 400 BAD REQUEST or even 200 OK with proper authorization secrets as that doesn't look like a big deal here).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.