[2][8]Login, Logout and JWT authorization #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislawK
reviewed
Feb 20, 2019
| except ValidationError as error: | ||
| return jsonify({"msg": "Wrong input data", | ||
| "errors": error.messages}), 400 | ||
|
|
There was a problem hiding this comment.
It returns two separate error messages at once. Is it intended?
{
"errors": {
"username": [
"Shorter than minimum length 5."
]
},
"msg": "Wrong input data"
}
stanislawK
reviewed
Feb 20, 2019
| return jsonify(ret), 201 | ||
| else: | ||
| return jsonify({"msg": "Not authorized"}), 401 | ||
|
|
There was a problem hiding this comment.
We maybe should create separate issue for refresh_token, and all related to it things like refreshing endpoint, and refresh logout?
stanislawK
approved these changes
Feb 27, 2019
OtisRed
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added login and logout endpoints.Created new db table for JWT tokens blacklisting.