[42] participant and hacknight model relationship #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislawK
reviewed
May 8, 2019
backend/models.py
Outdated
| hacknights = db.relationship("Hacknight", | ||
| secondary=participant_hacknight, | ||
| lazy='subquery', | ||
| backref=db.backref('participants', lazy=True)) | ||
|
|
There was a problem hiding this comment.
This looks like bidirectional many to many relationship. So either you should remove one relationship (from child class), or use back_populates instead of backref if you would like to keep this two directions.
stanislawK
reviewed
May 8, 2019
backend/models.py
Outdated
| 'participant_hacknight', | ||
| db.Column('participant_id', db.Integer, db.ForeignKey('participant.id')), | ||
| db.Column('hacknight.id', db.Integer, db.ForeignKey('hacknight.id')) | ||
| ) | ||
|
|
There was a problem hiding this comment.
Association table should be before participant and hacknight models
OtisRed
changed the title
OtisRed
changed the title
kristhina
changed the title
w1stler
reviewed
May 22, 2019
| participants = db.relationship("Participant", | ||
| secondary=participant_hacknight, | ||
| lazy='subquery', | ||
| backref=db.backref('hacknights', lazy=True)) |
There was a problem hiding this comment.
I'm going to fix it in #43
stanislawK
approved these changes
May 22, 2019
| participants = db.relationship("Participant", | ||
| secondary=participant_hacknight, | ||
| lazy='subquery', | ||
| backref=db.backref('hacknights', lazy=True)) |
There was a problem hiding this comment.
I'm going to fix it in #43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.