Remote image download throws exception

[patrickcarlohickman]

If the url for a remote image does not contain a "proper" extension (e.g. seo formatted urls or urls with query strings), the remote file download functionality throws an exception:

Imagine \ Exception \ InvalidArgumentException
Saving image in "0?lm=20130905t051456" format is not supported,
please use one of the following extension: "gif", "jpeg", "png", "wbmp", "xbm"

One workaround to get the file downloaded is to add a dummy query string to the end of the file to download, such as "&x=file.jpeg". This lets the download work correctly, but then the query string and everything is part of the file name of the file on the server (file on server is "0?lm=20130905t051456&x=x.jpeg"). Additionally, the file is not accessible from the browser, as far as I have been able to tell.

Two options I see:

• Have the IOWrapper->createFromUrl() method try to come up with a sensible filename and extension based on the curlinfo data.
• Allow some way to set the desired file name for remotely downloaded files. This may be part of implementing proposal [Proposal] rename attachments #36 (though you'd need to be able to set the file name before downloading), or could be completely separate.

[patrickcarlohickman]

I was able to come up with a workable solution, using a combination of two separate workarounds.

1. As mentioned above, add a dummy query string to the url to get the file to download.
2. As described in issue Filename Slug #34, modify the final file name inside a "saving" event on the model.

While this gets the job done, it would be nice to have formal functionality to address these issues. Or, barring that, maybe a mention in the documentation.

Issues aside, I do want to mention that I very much enjoy and appreciate this package (in addition to the asset pipeline)!

[pryley]

This pull request fixes the problem: #88

[andycaramba]

Still have this problem with urls like
https://fbexternal-a.akamaihd.net/safe_image.php?d=AQABM6nNJG_Jk7MT&url=https%3A%2F%2Ffbcdn-profile-a.akamaihd.net%2Fhprofile-ak-ash2%2Fv%2Ft1.0-1%2F531597_10151474349056108_968452843_n.jpg%3Foh%3D861b1bcfbf2cc08f3b0857be6796790b%26oe%3D560EC8E3%26__gda__%3D1444883590_425f86ded7d4cbcf607652407eb65eb7

[andycaramba]

Fixed my issue with adding

'convert_options' => [
    'format' => 'jpeg'
],

to styles option and forcibly saving image as :filename.jpg