Skip to content

fix(Card): remove extra transition from shadow variant #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

linseyjayne
Copy link
Contributor

@linseyjayne linseyjayne commented Jun 12, 2025

Overview

in firefox our path cards have come alive with a heartbeat! ( i think due to an extra transition attribute )
https://github.com/user-attachments/assets/1da679e7-f526-49d1-a283-4dac7bd6e4b4

removes extra transition from shadow variant of card to fix firefox animation

PR Checklist

  • Related to designs: n/a
  • Related to JIRA ticket: DOT-978
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to isInteractive card story[link here soon]
  2. Hover over the cards in firefox, make sure they animate as expected
  3. Do the same in chrome
  4. Do the same in dark mode
  5. Check it with VO
  6. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

Copy link

nx-cloud bot commented Jun 12, 2025

View your CI Pipeline Execution ↗ for commit da48c9e.


☁️ Nx Cloud last updated this comment at 2025-06-13 17:22:49 UTC

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://684c5e7ea9c0d25793e36e78--gamut-preview.netlify.app

Deploy Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants