Skip to content

Add dynamic support for more levels of approval #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Hipska
Copy link

@Hipska Hipska commented Apr 2, 2021

This was discussed earlier with Combodo support. One of our customers wanted to be more flexible, so we came up with this dynamic approach.

image
image
image

@Hipska Hipska marked this pull request as draft April 3, 2021 05:50
@Hipska
Copy link
Author

Hipska commented Apr 3, 2021

If you approve or accept this PR, I will improve more by adding the dicts and migration steps.

@Hipska
Copy link
Author

Hipska commented May 26, 2021

@piRGoif any update on this?

@piRGoif
Copy link
Contributor

piRGoif commented May 28, 2021

Sorry, 2 months since you submitted this PR and we didn't planned a review with the product team yet. I'll see with them !

@piRGoif
Copy link
Contributor

piRGoif commented Jun 24, 2021

Hello,
We just did a review with the product team !
Sorry it took us so long :/

Well, this is a datamodel change, it implies migration for existing users... and this extension is bundled with Combodo's professional & essential packages.
Plus our clients didn't ask for such flexibility for now...
Sometimes we had to give just one more approval level, but this can be done easily with a small customization.

For all of these reasons, we are not willing to integrate this in the default extension.

Many thanks though for sharing your work and offers us the possibility to merge it !

@piRGoif piRGoif closed this Jun 24, 2021
@piRGoif piRGoif self-assigned this Jun 24, 2021
@piRGoif piRGoif added enhancement New feature or request rejected and removed Products team review needed labels Jun 24, 2021
@Hipska
Copy link
Author

Hipska commented Jun 24, 2021

Indeed a datamodel change, but as said, it can done by an automatic migration. It's just not added to the PR yet.

But, no problems, we released it as module as wel. So if you have customers wanting this, you can forward them to us, we are happy to help them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants