[BARX-661] remove --use-release-entries and release_version from everywhere #36143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabrina-datadog
force-pushed
the
sabrina/remove-release-entries
branch
from
190d15a to
353f4bf
Compare
Gitlab CI Configuration Changes
|
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 1 | 77 | 0 | 0 |
ℹ️ Diff available in the job log.
Uncompressed package size comparisonComparison with ancestor Size reduction summary
Diff per package
Decision✅ Passed |
Static quality checks ✅Please find below the results from static quality gates Successful checksInfo
|
sabrina-datadog
force-pushed
the
sabrina/remove-release-entries
branch
from
353f4bf to
b80a69b
Compare
github-actions
bot
added
team/agent-delivery
long review
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 8add1e0 ❌ Experiments with missing or malformed dataThis is a critical error. No usable optimization goal data was produced by the listed experiments. This may be a result of misconfiguration. Ping #single-machine-performance and we can help out. Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.58 | [+0.53, +0.63] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.46 | [+0.31, +0.62] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.36 | [+0.25, +0.48] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.30 | [+0.19, +0.42] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.28 | [+0.20, +0.37] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.08 | [-0.86, +1.02] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.03 | [-0.18, +0.24] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.00 | [-0.94, +0.95] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.01 | [-0.85, +0.84] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.02 | [-0.92, +0.89] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.02 | [-0.80, +0.77] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.31, +0.27] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.02 | [-0.11, +0.06] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.03 | [-0.89, +0.83] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.03 | [-0.79, +0.73] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -0.43 | [-4.12, +3.25] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.75 | [-0.82, -0.68] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.81 | [-3.57, +1.94] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | -1.11 | [-1.30, -0.92] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -1.28 | [-1.44, -1.12] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.51 | [-2.35, -0.68] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -1.94 | [-2.07, -1.81] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
sabrina-datadog
force-pushed
the
sabrina/remove-release-entries
branch
2 times, most recently
from
c9e912b to
6d01a98
Compare
sabrina-datadog
commented
Apr 18, 2025
| @@ -199,6 +198,9 @@ def build( | |||
| Build the Agent packages with Omnibus Installer. | |||
| """ | |||
|
|
|||
| if release_version: | |||
There was a problem hiding this comment.
keeping the release_version parameter in this function for now because it's still used in the datadog-agent-macos-buildrepo (here). Although it's no longer needed, we're preserving it temporarily to maintain compatibility/no downtime between the two repositories.
The plan is to:
- first merge this PR with the parameter left in place
- open a PR in the
macos-buildrepo to remove release_version there - once that change is merged, we'll follow up with a third PR to remove the
release_versionparameter and the print statement from this file
sabrina-datadog
commented
Apr 18, 2025
sabrina-datadog
added
changelog/no-changelog
qa/no-code-change
sabrina-datadog
changed the title
clarkb7
approved these changes
Apr 18, 2025
sabrina-datadog
commented
Apr 21, 2025
spencergilbert
approved these changes
Apr 22, 2025
sabrina-datadog
force-pushed
the
sabrina/remove-release-entries
branch
from
e4c762b to
0b18e48
Compare
chouetz
approved these changes
Apr 23, 2025
sabrina-datadog
force-pushed
the
sabrina/remove-release-entries
branch
from
0b18e48 to
ad69d50
Compare
sabrina-datadog
added
the
backport/6.53.x
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
[email protected] cancelled this merge request build |
|
/remove |
|
View all feedbacks in Devflow UI.
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-6.53.x 6.53.x
# Navigate to the new working tree
cd .worktrees/backport-6.53.x
# Create a new branch
git switch --create backport-36143-to-6.53.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 59cb01a091355f736dcd8225a91c5b06d3a9db74
# Push it to GitHub
git push --set-upstream origin backport-36143-to-6.53.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-6.53.xThen, create a pull request where the |
grantseltzer
pushed a commit
that referenced
this pull request
Apr 24, 2025
This was referenced Apr 24, 2025
sabrina-datadog
added
the
backport/7.66.x
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.66.x 7.66.x
# Navigate to the new working tree
cd .worktrees/backport-7.66.x
# Create a new branch
git switch --create backport-36143-to-7.66.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 59cb01a091355f736dcd8225a91c5b06d3a9db74
# Push it to GitHub
git push --set-upstream origin backport-36143-to-7.66.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.66.xThen, create a pull request where the |
StephenWakely
pushed a commit
that referenced
this pull request
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
RELEASE_VERSIONenvironment variable from all the build related jobs--use-release-entriesflag from everywhere*note:
keeping the
release_versionparameter in theomnibus.buildfunction for now because it's still used in thedatadog-agent-macos-buildrepo (here). Although it's no longer needed, we're preserving it temporarily to maintain compatibility/no downtime between the two repositories (they rely on each other).The plan is to:
macos-buildrepo to remove release_version thererelease_versionparameter and the print statement from this fileMotivation
since we now only support Agent 7 and always build release versions from the release branch, we no longer need to have two separate entries for nightly and release. main branch will always have the "nightly" version and the release branch will always have the "release" version.
Describe how you validated your changes
made sure CI passes --> successful pipeline example
Possible Drawbacks / Trade-offs
Additional Notes