Revert "Stop reporting fake Ready status in WLM based on AD annotation"

[sblumenthal]

Reverts #36253

It would appear that this PR exposed an issue when a pod fails a probe for an extended period of time, but recovers. This manifests as the container being unscheduled from the AD scheduler, and in the container_name tag missing for short periods of time.

This behavior would have always been in place, but could have been avoided with the ad.datadoghq.com/tolerate-unready: "true" pod annotation. The mentioned PR removed this workaround.

More details:
https://app.datadoghq.com/incidents/38767
https://datadoghq.atlassian.net/wiki/x/wwKTNAE

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 11a0f566-2138-4059-9d49-968e9e9ef136

Baseline: d51f461
Comparison: 536ef34
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+4.38	[+1.55, +7.20]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+1.28	[+0.38, +2.18]	1	Logs
➖	docker_containers_cpu	% cpu utilization	+0.54	[-2.53, +3.62]	1	Logs
➖	ddot_logs	memory utilization	+0.42	[+0.28, +0.56]	1	Logs
➖	otlp_ingest_metrics	memory utilization	+0.35	[+0.19, +0.51]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.14	[-0.45, +0.72]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.09	[-0.46, +0.64]	1	Logs
➖	ddot_metrics	memory utilization	+0.05	[-0.07, +0.17]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.25, +0.27]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.02, +0.03]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.02	[-0.60, +0.57]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.04	[-0.65, +0.57]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.04	[-0.62, +0.55]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.05	[-0.28, +0.19]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.05	[-0.63, +0.53]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.05	[-0.63, +0.53]	1	Logs
➖	quality_gate_idle	memory utilization	-0.06	[-0.13, +0.00]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	-0.09	[-0.22, +0.04]	1	Logs
➖	docker_containers_memory	memory utilization	-0.15	[-0.23, -0.06]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.28	[-0.35, -0.21]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.73	[-0.86, -0.60]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.77	[-0.82, -0.72]	1	Logs
➖	file_tree	memory utilization	-1.69	[-1.93, -1.46]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	docker_containers_memory	memory_usage	0/10
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor d51f461

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${-0}$$	$${696.03}$$ < $${752.99}$$	$${+0.03}$$	$${176.04}$$ < $${187.44}$$
✅	agent_deb_amd64_fips	$${0}$$	$${694.26}$$ < $${751.36}$$	$${-0.02}$$	$${175.44}$$ < $${187.06}$$
✅	agent_heroku_amd64	$${-0}$$	$${358.55}$$ < $${369.68}$$	$${-0}$$	$${96.49}$$ < $${99.55}$$
✅	agent_msi	$${-0}$$	$${959.83}$$ < $${987.01}$$	$${-0.02}$$	$${146.43}$$ < $${150.72}$$
✅	agent_rpm_amd64	$${-0}$$	$${696.01}$$ < $${752.98}$$	$${-0.03}$$	$${177.52}$$ < $${190.03}$$
✅	agent_rpm_amd64_fips	$${0}$$	$${694.25}$$ < $${751.35}$$	$${-0}$$	$${177.41}$$ < $${189.81}$$
✅	agent_rpm_arm64	$${-0}$$	$${685.97}$$ < $${739.42}$$	$${-0.02}$$	$${160.98}$$ < $${171.23}$$
✅	agent_rpm_arm64_fips	$${0}$$	$${684.32}$$ < $${737.91}$$	$${-0.01}$$	$${160.08}$$ < $${170.22}$$
✅	agent_suse_amd64	$${-0}$$	$${696.01}$$ < $${752.98}$$	$${-0.03}$$	$${177.52}$$ < $${190.03}$$
✅	agent_suse_amd64_fips	$${0}$$	$${694.25}$$ < $${751.35}$$	$${-0}$$	$${177.41}$$ < $${189.81}$$
✅	agent_suse_arm64	$${-0}$$	$${685.97}$$ < $${739.42}$$	$${-0.02}$$	$${160.98}$$ < $${171.23}$$
✅	agent_suse_arm64_fips	$${0}$$	$${684.32}$$ < $${737.91}$$	$${-0.01}$$	$${160.08}$$ < $${170.22}$$
✅	docker_agent_amd64	$${-0}$$	$${779.81}$$ < $${849.39}$$	$${-0.01}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_arm64	$${-0}$$	$${793.22}$$ < $${858.97}$$	$${-0.01}$$	$${255.95}$$ < $${274.36}$$
✅	docker_agent_jmx_amd64	$${-0}$$	$${779.81}$$ < $${849.39}$$	$${-0.01}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_jmx_arm64	$${-0}$$	$${793.22}$$ < $${858.97}$$	$${-0.01}$$	$${255.95}$$ < $${274.36}$$
✅	docker_agent_windows1809	$${-0}$$	$${779.81}$$ < $${849.39}$$	$${-0.01}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows1809_core	$${-0}$$	$${779.81}$$ < $${849.39}$$	$${-0.01}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows1809_core_jmx	$${-0}$$	$${779.81}$$ < $${849.39}$$	$${-0.01}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows1809_jmx	$${-0}$$	$${779.81}$$ < $${849.39}$$	$${-0.01}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022	$${-0}$$	$${779.81}$$ < $${849.39}$$	$${-0.01}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022_core	$${-0}$$	$${779.81}$$ < $${849.39}$$	$${-0.01}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022_core_jmx	$${-0}$$	$${779.81}$$ < $${849.39}$$	$${-0.01}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022_jmx	$${-0}$$	$${779.81}$$ < $${849.39}$$	$${-0.01}$$	$${268.58}$$ < $${288.34}$$
✅	docker_cluster_agent_amd64	$${-0}$$	$${259.16}$$ < $${259.73}$$	$${+0}$$	$${102.87}$$ < $${103.68}$$
✅	docker_cluster_agent_arm64	$${-0}$$	$${273.57}$$ < $${274.24}$$	$${+0}$$	$${97.58}$$ < $${98.45}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.08}$$ < $${7.12}$$	$${+0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${-0}$$	$${38.93}$$ < $${39.57}$$	$${-0}$$	$${14.95}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.52}$$ < $${38.2}$$	$${-0.01}$$	$${13.96}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${+0}$$	$${8.03}$$ < $${8.97}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${29.16}$$ < $${30.08}$$	$${+0}$$	$${6.98}$$ < $${7.92}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${-0}$$	$${8.04}$$ < $${8.98}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${-0}$$	$${8.04}$$ < $${8.98}$$
✅	iot_agent_deb_amd64	$${0}$$	$${50.47}$$ < $${60.17}$$	$${+0}$$	$${12.85}$$ < $${15.82}$$
✅	iot_agent_deb_arm64	$${0}$$	$${47.93}$$ < $${56.94}$$	$${-0}$$	$${11.14}$$ < $${13.86}$$
✅	iot_agent_deb_armhf	$${0}$$	$${47.51}$$ < $${56.41}$$	$${-0.01}$$	$${11.21}$$ < $${13.86}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${50.47}$$ < $${60.18}$$	$${-0}$$	$${12.87}$$ < $${15.84}$$
✅	iot_agent_rpm_arm64	$${0}$$	$${47.93}$$ < $${56.94}$$	$${-0}$$	$${11.16}$$ < $${13.76}$$
✅	iot_agent_suse_amd64	$${0}$$	$${50.47}$$ < $${60.18}$$	$${-0}$$	$${12.87}$$ < $${15.84}$$

[sblumenthal]

/merge

[dd-devflow]

View all feedbacks in Devflow UI.

2025-06-06 17:24:54 UTC ℹ️ Start processing command /merge

---

2025-06-06 17:25:04 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 47m (p90).

---

2025-06-06 17:25:26 UTC ❌ MergeQueue: This merge request is not mergeable, blocked by github

PR can't be merged according to github policy. It's probably because:

• some mandatory checkruns are failing:
  • release-note-check
  • skip-qa-check

[sblumenthal]

/merge

[dd-devflow]

View all feedbacks in Devflow UI.

2025-06-06 17:39:09 UTC ℹ️ Start processing command /merge

---

2025-06-06 17:39:18 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 47m (p90).

---

2025-06-06 18:17:23 UTC ℹ️ MergeQueue: This merge request was merged