APM: wait to shutdown trace-agent components

[ajgajg1134]

Wait to shutdown until we've processed everything - otherwise we can lose data during the shutdown process and even panic due to trying to use the obfuscation cache concurrently while it's being closed

What does this PR do?

Add coordination so that we wait for active Process calls to complete before shutting down all the rest of the agent components.

Motivation

Ideally we don't want to lose data, and we definitely don't want to panic (even if it only happens during shutdown)

Describe how you validated your changes

New unit test here catches this failure quite well

Possible Drawbacks / Trade-offs

This could potentially lengthen the shutdown process, however this is in an effort to reduce lost data / panics so it seems worthwhile.

Additional Notes

[jhgilbert]

Approved with a minor suggestion for style, thanks!

[jhgilbert]

Suggested change

	APM: Fix an issue where the trace-agent could panic during shutdown trying to obfuscate a sql payload.
	APM: Fix an issue where the trace-agent could panic during shutdown trying to obfuscate a SQL payload.

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 1616b97d-b8df-48cc-a43e-e8a944aec28a

Baseline: 87af075
Comparison: 3105f24
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	ddot_logs	memory utilization	+0.64	[+0.50, +0.78]	1	Logs
➖	ddot_metrics	memory utilization	+0.57	[+0.46, +0.69]	1	Logs
➖	quality_gate_idle	memory utilization	+0.54	[+0.47, +0.61]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	+0.48	[+0.32, +0.64]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.29	[+0.21, +0.37]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.26	[-0.61, +1.14]	1	Logs
➖	otlp_ingest_logs	memory utilization	+0.16	[+0.03, +0.28]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.09	[-0.50, +0.68]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.04	[-0.01, +0.09]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.03	[-0.55, +0.62]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.03	[-0.55, +0.61]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.02	[-0.59, +0.62]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.02, +0.02]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.00	[-0.57, +0.57]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.29, +0.28]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.02	[-0.26, +0.22]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.12	[-0.76, +0.52]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.16	[-0.78, +0.46]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.33	[-0.41, -0.25]	1	Logs
➖	file_tree	memory utilization	-0.68	[-0.83, -0.53]	1	Logs
➖	docker_containers_memory	memory utilization	-0.76	[-0.83, -0.70]	1	Logs
➖	quality_gate_logs	% cpu utilization	-1.42	[-4.15, +1.30]	1	Logs bounds checks dashboard
➖	docker_containers_cpu	% cpu utilization	-4.03	[-7.04, -1.02]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	docker_containers_memory	memory_usage	0/10
✅	docker_containers_cpu	simple_check_run	10/10
✅	docker_containers_memory	simple_check_run	10/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[agent-platform-auto-pr]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 87af075

Successful checks

Info

	Quality gate	Delta	On disk size (MiB)	Delta	On wire size (MiB)
✅	agent_deb_amd64	$${0}$$	$${696.04}$$ < $${752.99}$$	$${+0.06}$$	$${176.03}$$ < $${187.44}$$
✅	agent_deb_amd64_fips	$${0}$$	$${694.26}$$ < $${751.36}$$	$${+0.02}$$	$${175.5}$$ < $${187.06}$$
✅	agent_heroku_amd64	$${0}$$	$${358.56}$$ < $${369.68}$$	$${+0}$$	$${96.5}$$ < $${99.55}$$
✅	agent_msi	$${+0}$$	$${959.85}$$ < $${987.01}$$	$${-0.02}$$	$${146.43}$$ < $${150.72}$$
✅	agent_rpm_amd64	$${0}$$	$${696.03}$$ < $${752.98}$$	$${-0.01}$$	$${177.51}$$ < $${190.03}$$
✅	agent_rpm_amd64_fips	$${0}$$	$${694.25}$$ < $${751.35}$$	$${-0.03}$$	$${177.38}$$ < $${189.81}$$
✅	agent_rpm_arm64	$${0}$$	$${685.98}$$ < $${739.42}$$	$${+0.02}$$	$${161.02}$$ < $${171.23}$$
✅	agent_rpm_arm64_fips	$${0}$$	$${684.33}$$ < $${737.91}$$	$${+0.02}$$	$${160.08}$$ < $${170.22}$$
✅	agent_suse_amd64	$${0}$$	$${696.03}$$ < $${752.98}$$	$${-0.01}$$	$${177.51}$$ < $${190.03}$$
✅	agent_suse_amd64_fips	$${0}$$	$${694.25}$$ < $${751.35}$$	$${-0.03}$$	$${177.38}$$ < $${189.81}$$
✅	agent_suse_arm64	$${0}$$	$${685.98}$$ < $${739.42}$$	$${+0.02}$$	$${161.02}$$ < $${171.23}$$
✅	agent_suse_arm64_fips	$${0}$$	$${684.33}$$ < $${737.91}$$	$${+0.02}$$	$${160.08}$$ < $${170.22}$$
✅	docker_agent_amd64	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${+0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_arm64	$${+0}$$	$${793.23}$$ < $${858.97}$$	$${-0}$$	$${255.96}$$ < $${274.36}$$
✅	docker_agent_jmx_amd64	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${+0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_jmx_arm64	$${+0}$$	$${793.23}$$ < $${858.97}$$	$${-0}$$	$${255.96}$$ < $${274.36}$$
✅	docker_agent_windows1809	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${+0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows1809_core	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${+0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows1809_core_jmx	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${+0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows1809_jmx	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${+0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${+0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022_core	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${+0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022_core_jmx	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${+0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_agent_windows2022_jmx	$${+0}$$	$${779.82}$$ < $${849.39}$$	$${+0}$$	$${268.58}$$ < $${288.34}$$
✅	docker_cluster_agent_amd64	$${-0}$$	$${259.18}$$ < $${259.73}$$	$${-0}$$	$${102.88}$$ < $${103.68}$$
✅	docker_cluster_agent_arm64	$${0}$$	$${273.58}$$ < $${274.24}$$	$${-0}$$	$${97.59}$$ < $${98.45}$$
✅	docker_cws_instrumentation_amd64	$${0}$$	$${7.08}$$ < $${7.12}$$	$${+0}$$	$${2.95}$$ < $${3.29}$$
✅	docker_cws_instrumentation_arm64	$${0}$$	$${6.69}$$ < $${6.92}$$	$${+0}$$	$${2.7}$$ < $${3.07}$$
✅	docker_dogstatsd_amd64	$${0}$$	$${38.93}$$ < $${39.57}$$	DataNotFound	$${14.95}$$ < $${15.76}$$
✅	docker_dogstatsd_arm64	$${0}$$	$${37.52}$$ < $${38.2}$$	DataNotFound	$${13.96}$$ < $${14.83}$$
✅	dogstatsd_deb_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${-0}$$	$${8.03}$$ < $${8.97}$$
✅	dogstatsd_deb_arm64	$${0}$$	$${29.16}$$ < $${30.08}$$	$${-0}$$	$${6.97}$$ < $${7.92}$$
✅	dogstatsd_rpm_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${+0}$$	$${8.04}$$ < $${8.98}$$
✅	dogstatsd_suse_amd64	$${0}$$	$${30.61}$$ < $${31.52}$$	$${+0}$$	$${8.04}$$ < $${8.98}$$
✅	iot_agent_deb_amd64	$${0}$$	$${50.48}$$ < $${60.17}$$	$${+0}$$	$${12.85}$$ < $${15.82}$$
✅	iot_agent_deb_arm64	$${0}$$	$${47.93}$$ < $${56.94}$$	$${+0}$$	$${11.14}$$ < $${13.86}$$
✅	iot_agent_deb_armhf	$${0}$$	$${47.51}$$ < $${56.41}$$	$${-0}$$	$${11.2}$$ < $${13.86}$$
✅	iot_agent_rpm_amd64	$${0}$$	$${50.48}$$ < $${60.18}$$	$${-0}$$	$${12.86}$$ < $${15.84}$$
✅	iot_agent_rpm_arm64	$${0}$$	$${47.94}$$ < $${56.94}$$	$${-0}$$	$${11.16}$$ < $${13.76}$$
✅	iot_agent_suse_amd64	$${0}$$	$${50.48}$$ < $${60.18}$$	$${-0}$$	$${12.86}$$ < $${15.84}$$