-
Notifications
You must be signed in to change notification settings - Fork 48
Update events intake specs for v2 events post endpoint #2546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update events intake specs for v2 events post endpoint #2546
Conversation
37d9e54
to
86c542a
Compare
5a4a483
to
8177967
Compare
aaf4842
to
680587b
Compare
88fd562
to
98d3ca4
Compare
98d3ca4
to
6703c2c
Compare
|
||
|
||
class AlertEventCustomAttributesCustom(ModelNormal): | ||
def __init__(self_, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, **kwargs): | |
def __init__(self, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
type: Union[EventCreateRequestType, UnsetType] = unset, | ||
**kwargs, | ||
): | ||
def __init__(self_, attributes: EventPayload, type: EventCreateRequestType, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, attributes: EventPayload, type: EventCreateRequestType, **kwargs): | |
def __init__(self, attributes: EventPayload, type: EventCreateRequestType, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
"self": "self", | ||
} | ||
|
||
def __init__(self_, self: Union[str, UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, self: Union[str, UnsetType] = unset, **kwargs): | |
def __init__(self, self: Union[str, UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__(self_, data: Union[EventCreateResponse, UnsetType] = unset, **kwargs): | ||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
@@ -30,13 +28,13 @@ def openapi_types(_): | |||
"data": "data", | |||
} | |||
|
|||
def __init__(self_, data: Union[EventCreateRequest, UnsetType] = unset, **kwargs): | |||
def __init__(self_, data: EventCreateRequest, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, data: EventCreateRequest, **kwargs): | |
def __init__(self, data: EventCreateRequest, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__( | ||
self_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
self_, | |
self, |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
} | ||
|
||
def __init__(self_, id: Union[str, UnsetType] = unset, **kwargs): | ||
def __init__(self_, id: Union[str, UnsetType] = unset, uid: Union[str, UnsetType] = unset, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Code Quality Violation
def __init__(self_, id: Union[str, UnsetType] = unset, uid: Union[str, UnsetType] = unset, **kwargs): | |
def __init__(self, id: Union[str, UnsetType] = unset, uid: Union[str, UnsetType] = unset, **kwargs): |
first parameter of a class function should be self (...read more)
In a class method (that is not a class method nor a static method), the first argument must be self
by convention.
Learn More
e62148a
to
d1348e2
Compare
d1348e2
to
b7653ad
Compare
See DataDog/datadog-api-spec#3833
Test branch datadog-api-spec/test/yuqing.bian/update-events-intake-specs