Disable muzzle in gitlab #8475
Merged
Disable muzzle in gitlab #8475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
randomanderson
force-pushed
the
landerson/disable-muzzle-gitlab
branch
from
eb1729b to
61a22a4
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 68 metrics, 3 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~61a22a43e8, baseline=1.47.0-SNAPSHOT~dceca289e9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.134 s) : 0, 1134104
Total [baseline] (11.478 s) : 0, 11478476
Agent [candidate] (1.134 s) : 0, 1134482
Total [candidate] (11.465 s) : 0, 11464766
section appsec
Agent [baseline] (1.272 s) : 0, 1272091
Total [baseline] (11.667 s) : 0, 11667393
Agent [candidate] (1.272 s) : 0, 1271746
Total [candidate] (11.696 s) : 0, 11696126
section iast
Agent [baseline] (1.265 s) : 0, 1265340
Total [baseline] (11.993 s) : 0, 11992914
Agent [candidate] (1.259 s) : 0, 1258528
Total [candidate] (11.915 s) : 0, 11914888
section profiling
Agent [baseline] (1.39 s) : 0, 1390095
Total [baseline] (11.917 s) : 0, 11916723
Agent [candidate] (1.382 s) : 0, 1382071
Total [candidate] (11.809 s) : 0, 11809030
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~61a22a43e8, baseline=1.47.0-SNAPSHOT~dceca289e9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.88 ms) : 0, 716880
BytebuddyAgent [candidate] (716.741 ms) : 0, 716741
GlobalTracer [baseline] (239.012 ms) : 0, 239012
GlobalTracer [candidate] (238.869 ms) : 0, 238869
AppSec [baseline] (55.785 ms) : 0, 55785
AppSec [candidate] (55.545 ms) : 0, 55545
Debugger [baseline] (94.458 ms) : 0, 94458
Debugger [candidate] (95.478 ms) : 0, 95478
Remote Config [baseline] (578.57 µs) : 0, 579
Remote Config [candidate] (585.787 µs) : 0, 586
Telemetry [baseline] (12.426 ms) : 0, 12426
Telemetry [candidate] (12.343 ms) : 0, 12343
section appsec
BytebuddyAgent [baseline] (735.21 ms) : 0, 735210
BytebuddyAgent [candidate] (734.546 ms) : 0, 734546
GlobalTracer [baseline] (236.329 ms) : 0, 236329
GlobalTracer [candidate] (236.091 ms) : 0, 236091
IAST [baseline] (21.66 ms) : 0, 21660
IAST [candidate] (21.519 ms) : 0, 21519
AppSec [baseline] (176.979 ms) : 0, 176979
AppSec [candidate] (178.049 ms) : 0, 178049
Debugger [baseline] (84.84 ms) : 0, 84840
Debugger [candidate] (84.369 ms) : 0, 84369
Remote Config [baseline] (630.69 µs) : 0, 631
Remote Config [candidate] (617.376 µs) : 0, 617
Telemetry [baseline] (12.314 ms) : 0, 12314
Telemetry [candidate] (12.313 ms) : 0, 12313
section iast
BytebuddyAgent [baseline] (842.513 ms) : 0, 842513
BytebuddyAgent [candidate] (837.115 ms) : 0, 837115
GlobalTracer [baseline] (230.887 ms) : 0, 230887
GlobalTracer [candidate] (230.059 ms) : 0, 230059
IAST [baseline] (22.93 ms) : 0, 22930
IAST [candidate] (22.836 ms) : 0, 22836
AppSec [baseline] (57.347 ms) : 0, 57347
AppSec [candidate] (57.325 ms) : 0, 57325
Debugger [baseline] (83.853 ms) : 0, 83853
Debugger [candidate] (83.378 ms) : 0, 83378
Remote Config [baseline] (520.913 µs) : 0, 521
Remote Config [candidate] (519.449 µs) : 0, 519
Telemetry [baseline] (12.184 ms) : 0, 12184
Telemetry [candidate] (12.272 ms) : 0, 12272
section profiling
BytebuddyAgent [baseline] (716.974 ms) : 0, 716974
BytebuddyAgent [candidate] (710.631 ms) : 0, 710631
GlobalTracer [baseline] (350.749 ms) : 0, 350749
GlobalTracer [candidate] (351.757 ms) : 0, 351757
AppSec [baseline] (55.612 ms) : 0, 55612
AppSec [candidate] (54.857 ms) : 0, 54857
Debugger [baseline] (88.686 ms) : 0, 88686
Debugger [candidate] (88.613 ms) : 0, 88613
Remote Config [baseline] (611.334 µs) : 0, 611
Remote Config [candidate] (619.493 µs) : 0, 619
Telemetry [baseline] (12.564 ms) : 0, 12564
Telemetry [candidate] (12.709 ms) : 0, 12709
ProfilingAgent [baseline] (124.256 ms) : 0, 124256
ProfilingAgent [candidate] (122.618 ms) : 0, 122618
Profiling [baseline] (124.277 ms) : 0, 124277
Profiling [candidate] (122.639 ms) : 0, 122639
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~61a22a43e8, baseline=1.47.0-SNAPSHOT~dceca289e9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.133 s) : 0, 1133305
Total [baseline] (9.256 s) : 0, 9256122
Agent [candidate] (1.134 s) : 0, 1134408
Total [candidate] (9.279 s) : 0, 9279287
section iast
Agent [baseline] (1.252 s) : 0, 1251770
Total [baseline] (9.849 s) : 0, 9848599
Agent [candidate] (1.275 s) : 0, 1274688
Total [candidate] (9.945 s) : 0, 9945467
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.259 s) : 0, 1258630
Total [baseline] (9.903 s) : 0, 9903380
Agent [candidate] (1.259 s) : 0, 1259235
Total [candidate] (9.9 s) : 0, 9900051
section iast_TELEMETRY_OFF
Agent [baseline] (1.25 s) : 0, 1250487
Total [baseline] (9.878 s) : 0, 9878204
Agent [candidate] (1.254 s) : 0, 1254119
Total [candidate] (9.957 s) : 0, 9956931
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~61a22a43e8, baseline=1.47.0-SNAPSHOT~dceca289e9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.812 ms) : 0, 715812
BytebuddyAgent [candidate] (715.641 ms) : 0, 715641
GlobalTracer [baseline] (238.834 ms) : 0, 238834
GlobalTracer [candidate] (239.251 ms) : 0, 239251
AppSec [baseline] (55.624 ms) : 0, 55624
AppSec [candidate] (56.026 ms) : 0, 56026
Debugger [baseline] (95.144 ms) : 0, 95144
Debugger [candidate] (95.392 ms) : 0, 95392
Remote Config [baseline] (582.852 µs) : 0, 583
Remote Config [candidate] (578.515 µs) : 0, 579
Telemetry [baseline] (12.396 ms) : 0, 12396
Telemetry [candidate] (12.526 ms) : 0, 12526
section iast
BytebuddyAgent [baseline] (833.013 ms) : 0, 833013
BytebuddyAgent [candidate] (849.248 ms) : 0, 849248
GlobalTracer [baseline] (228.6 ms) : 0, 228600
GlobalTracer [candidate] (232.232 ms) : 0, 232232
IAST [baseline] (22.67 ms) : 0, 22670
IAST [candidate] (23.238 ms) : 0, 23238
AppSec [baseline] (57.074 ms) : 0, 57074
AppSec [candidate] (57.802 ms) : 0, 57802
Debugger [baseline] (82.914 ms) : 0, 82914
Debugger [candidate] (84.106 ms) : 0, 84106
Remote Config [baseline] (516.205 µs) : 0, 516
Remote Config [candidate] (526.358 µs) : 0, 526
Telemetry [baseline] (12.074 ms) : 0, 12074
Telemetry [candidate] (12.299 ms) : 0, 12299
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.01 ms) : 0, 836010
BytebuddyAgent [candidate] (835.265 ms) : 0, 835265
GlobalTracer [baseline] (230.098 ms) : 0, 230098
GlobalTracer [candidate] (231.231 ms) : 0, 231231
IAST [baseline] (22.768 ms) : 0, 22768
IAST [candidate] (23.264 ms) : 0, 23264
AppSec [baseline] (57.643 ms) : 0, 57643
AppSec [candidate] (57.641 ms) : 0, 57641
Debugger [baseline] (84.297 ms) : 0, 84297
Debugger [candidate] (84.057 ms) : 0, 84057
Remote Config [baseline] (528.601 µs) : 0, 529
Remote Config [candidate] (520.113 µs) : 0, 520
Telemetry [baseline] (12.246 ms) : 0, 12246
Telemetry [candidate] (12.279 ms) : 0, 12279
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (830.663 ms) : 0, 830663
BytebuddyAgent [candidate] (833.888 ms) : 0, 833888
GlobalTracer [baseline] (229.177 ms) : 0, 229177
GlobalTracer [candidate] (229.62 ms) : 0, 229620
IAST [baseline] (23.057 ms) : 0, 23057
IAST [candidate] (23.999 ms) : 0, 23999
AppSec [baseline] (56.323 ms) : 0, 56323
AppSec [candidate] (55.642 ms) : 0, 55642
Debugger [baseline] (83.743 ms) : 0, 83743
Debugger [candidate] (83.35 ms) : 0, 83350
Remote Config [baseline] (538.85 µs) : 0, 539
Remote Config [candidate] (517.44 µs) : 0, 517
Telemetry [baseline] (12.071 ms) : 0, 12071
Telemetry [candidate] (12.107 ms) : 0, 12107
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~61a22a43e8, baseline=1.47.0-SNAPSHOT~dceca289e9
dateFormat X
axisFormat %s
section baseline
no_agent (378.42 µs) : 357, 400
. : milestone, 378,
iast (511.946 µs) : 490, 534
. : milestone, 512,
iast_FULL (730.128 µs) : 708, 752
. : milestone, 730,
iast_GLOBAL (564.716 µs) : 541, 588
. : milestone, 565,
iast_HARDCODED_SECRET_DISABLED (511.92 µs) : 490, 534
. : milestone, 512,
iast_INACTIVE (457.482 µs) : 436, 479
. : milestone, 457,
iast_TELEMETRY_OFF (501.093 µs) : 479, 523
. : milestone, 501,
tracing (451.115 µs) : 430, 472
. : milestone, 451,
section candidate
no_agent (387.278 µs) : 367, 407
. : milestone, 387,
iast (508.213 µs) : 486, 530
. : milestone, 508,
iast_FULL (724.908 µs) : 703, 747
. : milestone, 725,
iast_GLOBAL (568.69 µs) : 546, 592
. : milestone, 569,
iast_HARDCODED_SECRET_DISABLED (512.793 µs) : 491, 534
. : milestone, 513,
iast_INACTIVE (459.11 µs) : 438, 481
. : milestone, 459,
iast_TELEMETRY_OFF (500.95 µs) : 479, 523
. : milestone, 501,
tracing (456.982 µs) : 436, 478
. : milestone, 457,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~61a22a43e8, baseline=1.47.0-SNAPSHOT~dceca289e9
dateFormat X
axisFormat %s
section baseline
no_agent (1.38 ms) : 1361, 1400
. : milestone, 1380,
appsec (1.725 ms) : 1701, 1749
. : milestone, 1725,
appsec_no_iast (1.722 ms) : 1698, 1745
. : milestone, 1722,
code_origins (1.695 ms) : 1663, 1728
. : milestone, 1695,
iast (1.526 ms) : 1500, 1551
. : milestone, 1526,
profiling (1.508 ms) : 1484, 1532
. : milestone, 1508,
tracing (1.503 ms) : 1479, 1527
. : milestone, 1503,
section candidate
no_agent (1.368 ms) : 1348, 1389
. : milestone, 1368,
appsec (1.724 ms) : 1698, 1749
. : milestone, 1724,
appsec_no_iast (1.738 ms) : 1715, 1762
. : milestone, 1738,
code_origins (1.684 ms) : 1651, 1717
. : milestone, 1684,
iast (1.498 ms) : 1473, 1523
. : milestone, 1498,
profiling (1.565 ms) : 1539, 1590
. : milestone, 1565,
tracing (1.486 ms) : 1463, 1509
. : milestone, 1486,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~61a22a43e8, baseline=1.47.0-SNAPSHOT~dceca289e9
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1482
. : milestone, 1471,
appsec (2.331 ms) : 2288, 2375
. : milestone, 2331,
iast (2.114 ms) : 2059, 2170
. : milestone, 2114,
iast_GLOBAL (2.154 ms) : 2099, 2210
. : milestone, 2154,
profiling (1.993 ms) : 1948, 2039
. : milestone, 1993,
tracing (1.962 ms) : 1920, 2004
. : milestone, 1962,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.346 ms) : 2302, 2389
. : milestone, 2346,
iast (2.119 ms) : 2063, 2174
. : milestone, 2119,
iast_GLOBAL (2.164 ms) : 2108, 2219
. : milestone, 2164,
profiling (2.439 ms) : 2220, 2658
. : milestone, 2439,
tracing (1.941 ms) : 1899, 1983
. : milestone, 1941,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~61a22a43e8, baseline=1.47.0-SNAPSHOT~dceca289e9
dateFormat X
axisFormat %s
section baseline
no_agent (15.0 s) : 15000000, 15000000
. : milestone, 15000000,
appsec (14.853 s) : 14853000, 14853000
. : milestone, 14853000,
iast (18.936 s) : 18936000, 18936000
. : milestone, 18936000,
iast_GLOBAL (18.09 s) : 18090000, 18090000
. : milestone, 18090000,
profiling (14.894 s) : 14894000, 14894000
. : milestone, 14894000,
tracing (14.885 s) : 14885000, 14885000
. : milestone, 14885000,
section candidate
no_agent (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
appsec (14.83 s) : 14830000, 14830000
. : milestone, 14830000,
iast (18.738 s) : 18738000, 18738000
. : milestone, 18738000,
iast_GLOBAL (17.951 s) : 17951000, 17951000
. : milestone, 17951000,
profiling (14.935 s) : 14935000, 14935000
. : milestone, 14935000,
tracing (14.807 s) : 14807000, 14807000
. : milestone, 14807000,
|
manuel-alvarez-alvarez
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
LGTM, but not sure if we should put in place a proxy before disabling muzzle
CC: @PerfectSlayer
There was a problem hiding this comment.
Overall, is that an issue having muzzle to fail? Should we keep it failing until we fix the infra, or does it block the migration and your tests? -- I can get the worker IP rated limited and cause issue with other builds / projects.
Let's merge it now to limit the impact and we will revisit it later.
About the optional, isn't weird having optional tasks that are always expected to run? Not sure what the good practice between commenting job requirements versus setting it optional? 🤷
PerfectSlayer
approved these changes
Mar 3, 2025
PerfectSlayer
added
type: bug
PerfectSlayer
added
tag: no release notes
|
@PerfectSlayer The change didn't have to be in this PR, but it was needed generally. |
|
I were to read the GitLab doc. But all the checks that are mark optional are always expected to run, whatever the phase / build type 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Disables the muzzle jobs from running in Gitlab. Additional, the
requiredjob uses "optional" so that jobs missing because of rules are non-blocking/Motivation
Muzzle is cause rate limits to be hit with Sonatype.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]