-
Notifications
You must be signed in to change notification settings - Fork 304
Fix NPE when calculating code coverage for Gradle projects with non-standard directory layout #8521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nikita-tkachenko-datadog
merged 2 commits into
master
from
nikita-tkachenko/module-layout-npe-fix
Mar 10, 2025
Merged
Fix NPE when calculating code coverage for Gradle projects with non-standard directory layout #8521
nikita-tkachenko-datadog
merged 2 commits into
master
from
nikita-tkachenko/module-layout-npe-fix
Mar 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tandard directory layout
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~0e4df36055, baseline=1.48.0-SNAPSHOT~2575c713ad
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041715
Total [baseline] (10.46 s) : 0, 10459695
Agent [candidate] (1.051 s) : 0, 1050991
Total [candidate] (10.462 s) : 0, 10461693
section appsec
Agent [baseline] (1.183 s) : 0, 1183427
Total [baseline] (10.759 s) : 0, 10759014
Agent [candidate] (1.182 s) : 0, 1182438
Total [candidate] (10.759 s) : 0, 10759328
section iast
Agent [baseline] (1.179 s) : 0, 1179189
Total [baseline] (11.077 s) : 0, 11077313
Agent [candidate] (1.17 s) : 0, 1169895
Total [candidate] (10.933 s) : 0, 10932618
section profiling
Agent [baseline] (1.26 s) : 0, 1260127
Total [baseline] (10.906 s) : 0, 10906049
Agent [candidate] (1.258 s) : 0, 1257742
Total [candidate] (10.84 s) : 0, 10839816
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~0e4df36055, baseline=1.48.0-SNAPSHOT~2575c713ad
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.137 ms) : 0, 719137
BytebuddyAgent [candidate] (723.822 ms) : 0, 723822
GlobalTracer [baseline] (239.979 ms) : 0, 239979
GlobalTracer [candidate] (241.787 ms) : 0, 241787
AppSec [baseline] (55.541 ms) : 0, 55541
AppSec [candidate] (55.52 ms) : 0, 55520
Remote Config [baseline] (696.122 µs) : 0, 696
Remote Config [candidate] (689.255 µs) : 0, 689
Telemetry [baseline] (11.32 ms) : 0, 11320
Telemetry [candidate] (14.13 ms) : 0, 14130
section appsec
BytebuddyAgent [baseline] (735.506 ms) : 0, 735506
BytebuddyAgent [candidate] (734.641 ms) : 0, 734641
GlobalTracer [baseline] (236.267 ms) : 0, 236267
GlobalTracer [candidate] (236.321 ms) : 0, 236321
IAST [baseline] (21.74 ms) : 0, 21740
IAST [candidate] (21.383 ms) : 0, 21383
AppSec [baseline] (176.89 ms) : 0, 176890
AppSec [candidate] (176.872 ms) : 0, 176872
Remote Config [baseline] (662.642 µs) : 0, 663
Remote Config [candidate] (658.938 µs) : 0, 659
Telemetry [baseline] (8.326 ms) : 0, 8326
Telemetry [candidate] (8.258 ms) : 0, 8258
section iast
BytebuddyAgent [baseline] (843.583 ms) : 0, 843583
BytebuddyAgent [candidate] (836.513 ms) : 0, 836513
GlobalTracer [baseline] (231.362 ms) : 0, 231362
GlobalTracer [candidate] (230.165 ms) : 0, 230165
IAST [baseline] (22.866 ms) : 0, 22866
IAST [candidate] (22.709 ms) : 0, 22709
AppSec [baseline] (56.909 ms) : 0, 56909
AppSec [candidate] (56.375 ms) : 0, 56375
Remote Config [baseline] (617.243 µs) : 0, 617
Remote Config [candidate] (606.335 µs) : 0, 606
Telemetry [baseline] (8.741 ms) : 0, 8741
Telemetry [candidate] (8.563 ms) : 0, 8563
section profiling
BytebuddyAgent [baseline] (709.128 ms) : 0, 709128
BytebuddyAgent [candidate] (708.639 ms) : 0, 708639
GlobalTracer [baseline] (349.499 ms) : 0, 349499
GlobalTracer [candidate] (349.219 ms) : 0, 349219
AppSec [baseline] (55.046 ms) : 0, 55046
AppSec [candidate] (53.697 ms) : 0, 53697
Remote Config [baseline] (681.264 µs) : 0, 681
Remote Config [candidate] (672.114 µs) : 0, 672
Telemetry [baseline] (9.036 ms) : 0, 9036
Telemetry [candidate] (8.945 ms) : 0, 8945
ProfilingAgent [baseline] (96.357 ms) : 0, 96357
ProfilingAgent [candidate] (96.087 ms) : 0, 96087
Profiling [baseline] (96.382 ms) : 0, 96382
Profiling [candidate] (96.114 ms) : 0, 96114
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~0e4df36055, baseline=1.48.0-SNAPSHOT~2575c713ad
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050805
Total [baseline] (8.724 s) : 0, 8723951
Agent [candidate] (1.048 s) : 0, 1047836
Total [candidate] (8.702 s) : 0, 8701909
section iast
Agent [baseline] (1.172 s) : 0, 1172331
Total [baseline] (9.257 s) : 0, 9257204
Agent [candidate] (1.172 s) : 0, 1171807
Total [candidate] (9.243 s) : 0, 9242731
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.185 s) : 0, 1185308
Total [baseline] (9.202 s) : 0, 9201541
Agent [candidate] (1.17 s) : 0, 1169613
Total [candidate] (9.178 s) : 0, 9177673
section iast_TELEMETRY_OFF
Agent [baseline] (1.164 s) : 0, 1164068
Total [baseline] (9.228 s) : 0, 9228154
Agent [candidate] (1.168 s) : 0, 1168135
Total [candidate] (9.223 s) : 0, 9223331
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~0e4df36055, baseline=1.48.0-SNAPSHOT~2575c713ad
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (727.216 ms) : 0, 727216
BytebuddyAgent [candidate] (721.054 ms) : 0, 721054
GlobalTracer [baseline] (241.93 ms) : 0, 241930
GlobalTracer [candidate] (241.449 ms) : 0, 241449
AppSec [baseline] (55.752 ms) : 0, 55752
AppSec [candidate] (55.933 ms) : 0, 55933
Remote Config [baseline] (726.056 µs) : 0, 726
Remote Config [candidate] (700.954 µs) : 0, 701
Telemetry [baseline] (10.137 ms) : 0, 10137
Telemetry [candidate] (13.704 ms) : 0, 13704
section iast
BytebuddyAgent [baseline] (837.855 ms) : 0, 837855
BytebuddyAgent [candidate] (838.023 ms) : 0, 838023
GlobalTracer [baseline] (230.543 ms) : 0, 230543
GlobalTracer [candidate] (230.201 ms) : 0, 230201
IAST [baseline] (22.627 ms) : 0, 22627
IAST [candidate] (22.839 ms) : 0, 22839
AppSec [baseline] (57.061 ms) : 0, 57061
AppSec [candidate] (56.574 ms) : 0, 56574
Remote Config [baseline] (606.333 µs) : 0, 606
Remote Config [candidate] (602.87 µs) : 0, 603
Telemetry [baseline] (8.658 ms) : 0, 8658
Telemetry [candidate] (8.608 ms) : 0, 8608
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (848.256 ms) : 0, 848256
BytebuddyAgent [candidate] (834.968 ms) : 0, 834968
GlobalTracer [baseline] (232.116 ms) : 0, 232116
GlobalTracer [candidate] (230.586 ms) : 0, 230586
IAST [baseline] (23.076 ms) : 0, 23076
IAST [candidate] (23.556 ms) : 0, 23556
AppSec [baseline] (57.175 ms) : 0, 57175
AppSec [candidate] (56.239 ms) : 0, 56239
Remote Config [baseline] (623.572 µs) : 0, 624
Remote Config [candidate] (618.703 µs) : 0, 619
Telemetry [baseline] (8.728 ms) : 0, 8728
Telemetry [candidate] (8.704 ms) : 0, 8704
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (831.266 ms) : 0, 831266
BytebuddyAgent [candidate] (833.824 ms) : 0, 833824
GlobalTracer [baseline] (229.648 ms) : 0, 229648
GlobalTracer [candidate] (230.487 ms) : 0, 230487
IAST [baseline] (23.099 ms) : 0, 23099
IAST [candidate] (22.387 ms) : 0, 22387
AppSec [baseline] (56.061 ms) : 0, 56061
AppSec [candidate] (57.082 ms) : 0, 57082
Remote Config [baseline] (594.697 µs) : 0, 595
Remote Config [candidate] (620.598 µs) : 0, 621
Telemetry [baseline] (8.486 ms) : 0, 8486
Telemetry [candidate] (8.762 ms) : 0, 8762
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~0e4df36055, baseline=1.48.0-SNAPSHOT~2575c713ad
dateFormat X
axisFormat %s
section baseline
no_agent (1.353 ms) : 1334, 1371
. : milestone, 1353,
appsec (1.739 ms) : 1714, 1763
. : milestone, 1739,
appsec_no_iast (1.757 ms) : 1733, 1781
. : milestone, 1757,
code_origins (1.689 ms) : 1655, 1722
. : milestone, 1689,
iast (1.516 ms) : 1491, 1541
. : milestone, 1516,
profiling (1.555 ms) : 1530, 1580
. : milestone, 1555,
tracing (1.496 ms) : 1471, 1522
. : milestone, 1496,
section candidate
no_agent (1.379 ms) : 1359, 1398
. : milestone, 1379,
appsec (1.723 ms) : 1699, 1746
. : milestone, 1723,
appsec_no_iast (1.75 ms) : 1726, 1774
. : milestone, 1750,
code_origins (1.686 ms) : 1653, 1720
. : milestone, 1686,
iast (1.526 ms) : 1502, 1550
. : milestone, 1526,
profiling (1.565 ms) : 1532, 1597
. : milestone, 1565,
tracing (1.496 ms) : 1471, 1522
. : milestone, 1496,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~0e4df36055, baseline=1.48.0-SNAPSHOT~2575c713ad
dateFormat X
axisFormat %s
section baseline
no_agent (384.584 µs) : 365, 404
. : milestone, 385,
iast (513.314 µs) : 491, 536
. : milestone, 513,
iast_FULL (731.245 µs) : 709, 753
. : milestone, 731,
iast_GLOBAL (566.009 µs) : 543, 589
. : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (517.918 µs) : 496, 540
. : milestone, 518,
iast_INACTIVE (467.383 µs) : 446, 489
. : milestone, 467,
iast_TELEMETRY_OFF (510.742 µs) : 488, 534
. : milestone, 511,
tracing (457.684 µs) : 437, 479
. : milestone, 458,
section candidate
no_agent (387.75 µs) : 368, 408
. : milestone, 388,
iast (512.953 µs) : 490, 536
. : milestone, 513,
iast_FULL (728.938 µs) : 707, 751
. : milestone, 729,
iast_GLOBAL (557.923 µs) : 536, 580
. : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (507.054 µs) : 485, 529
. : milestone, 507,
iast_INACTIVE (469.61 µs) : 448, 491
. : milestone, 470,
iast_TELEMETRY_OFF (500.02 µs) : 478, 522
. : milestone, 500,
tracing (467.511 µs) : 445, 490
. : milestone, 468,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~0e4df36055, baseline=1.48.0-SNAPSHOT~2575c713ad
dateFormat X
axisFormat %s
section baseline
no_agent (15.58 s) : 15580000, 15580000
. : milestone, 15580000,
appsec (14.893 s) : 14893000, 14893000
. : milestone, 14893000,
iast (18.903 s) : 18903000, 18903000
. : milestone, 18903000,
iast_GLOBAL (18.148 s) : 18148000, 18148000
. : milestone, 18148000,
profiling (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
tracing (14.999 s) : 14999000, 14999000
. : milestone, 14999000,
section candidate
no_agent (15.563 s) : 15563000, 15563000
. : milestone, 15563000,
appsec (14.957 s) : 14957000, 14957000
. : milestone, 14957000,
iast (18.876 s) : 18876000, 18876000
. : milestone, 18876000,
iast_GLOBAL (18.169 s) : 18169000, 18169000
. : milestone, 18169000,
profiling (15.686 s) : 15686000, 15686000
. : milestone, 15686000,
tracing (14.897 s) : 14897000, 14897000
. : milestone, 14897000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~0e4df36055, baseline=1.48.0-SNAPSHOT~2575c713ad
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.332 ms) : 2289, 2376
. : milestone, 2332,
iast (2.107 ms) : 2052, 2161
. : milestone, 2107,
iast_GLOBAL (2.153 ms) : 2097, 2208
. : milestone, 2153,
profiling (1.959 ms) : 1916, 2002
. : milestone, 1959,
tracing (1.938 ms) : 1895, 1980
. : milestone, 1938,
section candidate
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.317 ms) : 2273, 2360
. : milestone, 2317,
iast (2.106 ms) : 2051, 2162
. : milestone, 2106,
iast_GLOBAL (2.151 ms) : 2096, 2206
. : milestone, 2151,
profiling (1.951 ms) : 1908, 1994
. : milestone, 1951,
tracing (1.947 ms) : 1905, 1990
. : milestone, 1947,
|
daniel-mohedano
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fixes a
NullPointerException
in code coverage calculation logic, that occurs when the tracer cannot infer the directory structure of the instrumented Gradle project.Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]