-
Notifications
You must be signed in to change notification settings - Fork 304
Implement tests reordering for JUnit 4 #8650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
daniel-mohedano
merged 14 commits into
master
from
daniel.mohedano/junit4-test-reordering
Apr 4, 2025
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6c9a354
add junit4 test ordering
daniel-mohedano 1d3c394
add maven-surefire instrumentation for junit4 class ordering
daniel-mohedano 06ead3b
add gradle-8.0 instrumentation for junit4 class ordering
daniel-mohedano 5640387
update gradle junit instrumentation to support starting on 5.1
daniel-mohedano e295114
remove withEnvironment in smoke tests in favor of build.gradle setup
daniel-mohedano 3a452f9
fix spotless and codenarc
daniel-mohedano f2a78b3
PR fixes
daniel-mohedano fe09e0d
fix muzzle checks
daniel-mohedano 4c3e430
Update system-tests to 2799fa982318da14c9d3e5f722abdc670d2802c3
daniel-mohedano e0b7a1f
Merge branch 'master' into daniel.mohedano/junit4-test-reordering
daniel-mohedano f59331e
update gradle-testing dependency to implementation
daniel-mohedano df417bd
Revert "update gradle-testing dependency to implementation"
daniel-mohedano 0c2e77f
Do not use strict write with latest lettuce
amarziali 5a77c30
Merge branch 'andrea.marziali/lettuce-latest-tests' into daniel.mohed…
daniel-mohedano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| apply from: "$rootDir/gradle/java.gradle" | ||
|
|
||
| repositories { | ||
| maven { | ||
| url "https://repo.gradle.org/artifactory/libs-releases-local" | ||
| } | ||
| } | ||
|
|
||
| // gradle >= v5.1 | ||
| dependencies { | ||
| compileOnly gradleApi() | ||
| compileOnly project(":dd-java-agent:instrumentation:junit-4.10") | ||
| } | ||
|
|
||
| forbiddenApisMain { | ||
| failOnMissingClasses = false | ||
| } | ||
156 changes: 156 additions & 0 deletions
156
dd-java-agent/instrumentation/gradle-testing/gradle.lockfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,156 @@ | ||
| # This is a Gradle generated file for dependency locking. | ||
| # Manual edits can break the build and are not advised. | ||
| # This file is expected to be part of source control. | ||
| cafe.cryptography:curve25519-elisabeth:0.1.0=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| cafe.cryptography:ed25519-elisabeth:0.1.0=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| ch.qos.logback:logback-classic:1.2.3=testCompileClasspath,testRuntimeClasspath | ||
| ch.qos.logback:logback-core:1.2.3=testCompileClasspath,testRuntimeClasspath | ||
| com.beust:jcommander:1.78=testRuntimeClasspath | ||
| com.blogspot.mydailyjava:weak-lock-free:0.17=compileClasspath,instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.datadoghq.okhttp3:okhttp:3.12.15=compileClasspath,instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.datadoghq.okio:okio:1.17.6=compileClasspath,instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.datadoghq:dd-javac-plugin-client:0.2.2=compileClasspath,instrumentPluginClasspath,muzzleBootstrap,muzzleTooling,runtimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.datadoghq:java-dogstatsd-client:4.4.3=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| com.datadoghq:sketches-java:0.8.3=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| com.github.javaparser:javaparser-core:3.25.1=testCompileClasspath,testRuntimeClasspath | ||
| com.github.jnr:jffi:1.3.13=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| com.github.jnr:jnr-a64asm:1.0.0=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| com.github.jnr:jnr-constants:0.10.4=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| com.github.jnr:jnr-enxio:0.32.17=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| com.github.jnr:jnr-ffi:2.2.16=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| com.github.jnr:jnr-posix:3.1.19=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| com.github.jnr:jnr-unixsocket:0.38.22=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| com.github.jnr:jnr-x86asm:1.0.2=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| com.github.spotbugs:spotbugs-annotations:4.2.0=compileClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.github.spotbugs:spotbugs-annotations:4.7.3=spotbugs | ||
| com.github.spotbugs:spotbugs:4.7.3=spotbugs | ||
| com.github.stefanbirkner:system-rules:1.19.0=testCompileClasspath,testRuntimeClasspath | ||
| com.google.auto.service:auto-service-annotations:1.0-rc7=annotationProcessor,compileClasspath,testAnnotationProcessor,testCompileClasspath | ||
| com.google.auto.service:auto-service:1.0-rc7=annotationProcessor,testAnnotationProcessor | ||
| com.google.auto:auto-common:0.10=annotationProcessor,testAnnotationProcessor | ||
| com.google.code.findbugs:jsr305:3.0.2=annotationProcessor,compileClasspath,spotbugs,testAnnotationProcessor,testCompileClasspath,testRuntimeClasspath | ||
| com.google.code.gson:gson:2.9.1=spotbugs | ||
| com.google.errorprone:error_prone_annotations:2.2.0=annotationProcessor,testAnnotationProcessor | ||
| com.google.guava:failureaccess:1.0.1=annotationProcessor,testAnnotationProcessor | ||
| com.google.guava:guava:20.0=testCompileClasspath,testRuntimeClasspath | ||
| com.google.guava:guava:27.0.1-jre=annotationProcessor,testAnnotationProcessor | ||
| com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava=annotationProcessor,testAnnotationProcessor | ||
| com.google.j2objc:j2objc-annotations:1.1=annotationProcessor,testAnnotationProcessor | ||
| com.google.re2j:re2j:1.7=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| com.squareup.moshi:moshi:1.11.0=compileClasspath,instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.squareup.okhttp3:logging-interceptor:3.12.12=testCompileClasspath,testRuntimeClasspath | ||
| com.squareup.okhttp3:okhttp:3.12.12=testCompileClasspath,testRuntimeClasspath | ||
| com.squareup.okio:okio:1.17.5=compileClasspath,instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.thoughtworks.qdox:qdox:1.12.1=testRuntimeClasspath | ||
| commons-codec:commons-codec:1.15=spotbugs | ||
| commons-fileupload:commons-fileupload:1.5=testCompileClasspath,testRuntimeClasspath | ||
| commons-io:commons-io:2.11.0=testCompileClasspath,testRuntimeClasspath | ||
| de.thetaphi:forbiddenapis:3.8=compileClasspath | ||
| info.picocli:picocli:4.6.3=testRuntimeClasspath | ||
| io.sqreen:libsqreen:12.0.0=testRuntimeClasspath | ||
| javax.servlet:javax.servlet-api:3.1.0=testCompileClasspath,testRuntimeClasspath | ||
| jaxen:jaxen:1.2.0=spotbugs | ||
| jline:jline:2.14.6=testRuntimeClasspath | ||
| junit:junit-dep:4.11=testCompileClasspath,testRuntimeClasspath | ||
| junit:junit:4.13.2=testCompileClasspath,testRuntimeClasspath | ||
| net.bytebuddy:byte-buddy-agent:1.14.18=compileClasspath,instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| net.bytebuddy:byte-buddy:1.14.18=compileClasspath,instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| net.java.dev.jna:jna-platform:5.8.0=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| net.java.dev.jna:jna:5.8.0=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| net.jcip:jcip-annotations:1.0=compileClasspath,spotbugs,testCompileClasspath,testRuntimeClasspath | ||
| net.sf.saxon:Saxon-HE:11.4=spotbugs | ||
| org.apache.ant:ant-antlr:1.10.12=testRuntimeClasspath | ||
| org.apache.ant:ant-antlr:1.9.15=codenarc | ||
| org.apache.ant:ant-junit:1.10.12=testRuntimeClasspath | ||
| org.apache.ant:ant-junit:1.9.15=codenarc | ||
| org.apache.ant:ant-launcher:1.10.12=testRuntimeClasspath | ||
| org.apache.ant:ant:1.10.12=testCompileClasspath,testRuntimeClasspath | ||
| org.apache.bcel:bcel:6.5.0=spotbugs | ||
| org.apache.commons:commons-lang3:3.12.0=spotbugs | ||
| org.apache.commons:commons-text:1.10.0=spotbugs | ||
| org.apache.httpcomponents.client5:httpclient5:5.1.3=spotbugs | ||
| org.apache.httpcomponents.core5:httpcore5-h2:5.1.3=spotbugs | ||
| org.apache.httpcomponents.core5:httpcore5:5.1.3=spotbugs | ||
| org.apache.logging.log4j:log4j-api:2.19.0=spotbugs | ||
| org.apache.logging.log4j:log4j-core:2.19.0=spotbugs | ||
| org.apiguardian:apiguardian-api:1.1.2=testCompileClasspath | ||
| org.checkerframework:checker-qual:2.5.2=annotationProcessor,testAnnotationProcessor | ||
| org.codehaus.groovy:groovy-all:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-ant:2.5.14=codenarc | ||
| org.codehaus.groovy:groovy-ant:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-astbuilder:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-cli-picocli:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-console:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-datetime:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-docgenerator:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-groovydoc:2.5.14=codenarc | ||
| org.codehaus.groovy:groovy-groovydoc:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-groovysh:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-jmx:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-json:2.5.14=codenarc | ||
| org.codehaus.groovy:groovy-json:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-jsr223:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-macro:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-nio:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-servlet:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-sql:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-swing:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-templates:2.5.14=codenarc | ||
| org.codehaus.groovy:groovy-templates:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-test-junit5:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-test:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-testng:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-xml:2.5.14=codenarc | ||
| org.codehaus.groovy:groovy-xml:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy:2.5.14=codenarc | ||
| org.codehaus.groovy:groovy:3.0.17=testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.mojo:animal-sniffer-annotations:1.17=annotationProcessor,testAnnotationProcessor | ||
| org.codenarc:CodeNarc:2.2.0=codenarc | ||
| org.dom4j:dom4j:2.1.3=spotbugs | ||
| org.eclipse.jetty:jetty-http:9.4.56.v20240826=testCompileClasspath,testRuntimeClasspath | ||
| org.eclipse.jetty:jetty-io:9.4.56.v20240826=testCompileClasspath,testRuntimeClasspath | ||
| org.eclipse.jetty:jetty-server:9.4.56.v20240826=testCompileClasspath,testRuntimeClasspath | ||
| org.eclipse.jetty:jetty-util:9.4.56.v20240826=testCompileClasspath,testRuntimeClasspath | ||
| org.gmetrics:GMetrics:1.1=codenarc | ||
| org.hamcrest:hamcrest-core:1.3=testCompileClasspath,testRuntimeClasspath | ||
| org.hamcrest:hamcrest:2.2=testCompileClasspath,testRuntimeClasspath | ||
| org.jctools:jctools-core:3.3.0=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| org.junit.jupiter:junit-jupiter-api:5.9.2=testCompileClasspath,testRuntimeClasspath | ||
| org.junit.jupiter:junit-jupiter-engine:5.9.2=testRuntimeClasspath | ||
| org.junit.platform:junit-platform-commons:1.9.2=testCompileClasspath,testRuntimeClasspath | ||
| org.junit.platform:junit-platform-engine:1.9.2=testCompileClasspath,testRuntimeClasspath | ||
| org.junit.platform:junit-platform-launcher:1.9.2=testRuntimeClasspath | ||
| org.junit.platform:junit-platform-runner:1.9.2=testRuntimeClasspath | ||
| org.junit.platform:junit-platform-suite-api:1.9.2=testRuntimeClasspath | ||
| org.junit.platform:junit-platform-suite-commons:1.9.2=testRuntimeClasspath | ||
| org.junit:junit-bom:5.9.1=spotbugs | ||
| org.junit:junit-bom:5.9.2=testCompileClasspath,testRuntimeClasspath | ||
| org.objenesis:objenesis:3.3=testCompileClasspath,testRuntimeClasspath | ||
| org.opentest4j:opentest4j:1.2.0=testCompileClasspath,testRuntimeClasspath | ||
| org.ow2.asm:asm-analysis:9.2=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| org.ow2.asm:asm-analysis:9.4=spotbugs | ||
| org.ow2.asm:asm-commons:9.2=instrumentPluginClasspath,muzzleTooling,runtimeClasspath | ||
| org.ow2.asm:asm-commons:9.4=spotbugs | ||
| org.ow2.asm:asm-commons:9.7.1=testRuntimeClasspath | ||
| org.ow2.asm:asm-tree:9.2=instrumentPluginClasspath,muzzleTooling,runtimeClasspath | ||
| org.ow2.asm:asm-tree:9.4=spotbugs | ||
| org.ow2.asm:asm-tree:9.7.1=testRuntimeClasspath | ||
| org.ow2.asm:asm-util:9.2=instrumentPluginClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| org.ow2.asm:asm-util:9.4=spotbugs | ||
| org.ow2.asm:asm:9.2=instrumentPluginClasspath,muzzleTooling,runtimeClasspath | ||
| org.ow2.asm:asm:9.4=spotbugs | ||
| org.ow2.asm:asm:9.7.1=testRuntimeClasspath | ||
| org.slf4j:jcl-over-slf4j:1.7.30=testCompileClasspath,testRuntimeClasspath | ||
| org.slf4j:jul-to-slf4j:1.7.30=testCompileClasspath,testRuntimeClasspath | ||
| org.slf4j:log4j-over-slf4j:1.7.30=testCompileClasspath,testRuntimeClasspath | ||
| org.slf4j:slf4j-api:1.7.30=compileClasspath,instrumentPluginClasspath,muzzleBootstrap,muzzleTooling,runtimeClasspath,testCompileClasspath | ||
| org.slf4j:slf4j-api:1.7.32=testRuntimeClasspath | ||
| org.slf4j:slf4j-api:2.0.0=spotbugs,spotbugsSlf4j | ||
| org.slf4j:slf4j-simple:2.0.0=spotbugsSlf4j | ||
| org.spockframework:spock-core:2.2-groovy-3.0=testCompileClasspath,testRuntimeClasspath | ||
| org.spockframework:spock-junit4:2.2-groovy-3.0=testCompileClasspath,testRuntimeClasspath | ||
| org.testng:testng:7.5=testRuntimeClasspath | ||
| org.webjars:jquery:3.5.1=testRuntimeClasspath | ||
| org.xmlresolver:xmlresolver:4.4.3=spotbugs | ||
| xml-apis:xml-apis:1.4.01=spotbugs | ||
| empty=spotbugsPlugins |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.