-
Notifications
You must be signed in to change notification settings - Fork 304
Update config line to account for large binary files #8709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sarahchen6
merged 1 commit into
master
from
sarahchen6/update-config-for-large-binary-files
Apr 21, 2025
Merged
Update config line to account for large binary files #8709
sarahchen6
merged 1 commit into
master
from
sarahchen6/update-config-for-large-binary-files
Apr 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~05b1b2cffa, baseline=1.49.0-SNAPSHOT~368851d216
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057276
Total [baseline] (10.481 s) : 0, 10480919
Agent [candidate] (1.065 s) : 0, 1065183
Total [candidate] (10.623 s) : 0, 10622815
section appsec
Agent [baseline] (1.202 s) : 0, 1201750
Total [baseline] (10.874 s) : 0, 10874343
Agent [candidate] (1.215 s) : 0, 1215102
Total [candidate] (10.821 s) : 0, 10820675
section iast
Agent [baseline] (1.2 s) : 0, 1200190
Total [baseline] (11.167 s) : 0, 11166784
Agent [candidate] (1.189 s) : 0, 1188759
Total [candidate] (11.072 s) : 0, 11071872
section profiling
Agent [baseline] (1.324 s) : 0, 1324174
Total [baseline] (11.059 s) : 0, 11058613
Agent [candidate] (1.309 s) : 0, 1309366
Total [candidate] (11.066 s) : 0, 11065931
gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~05b1b2cffa, baseline=1.49.0-SNAPSHOT~368851d216
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.445 ms) : 0, 720445
BytebuddyAgent [candidate] (727.132 ms) : 0, 727132
GlobalTracer [baseline] (239.003 ms) : 0, 239003
GlobalTracer [candidate] (240.995 ms) : 0, 240995
AppSec [baseline] (55.834 ms) : 0, 55834
AppSec [candidate] (56.511 ms) : 0, 56511
Debugger [baseline] (4.366 ms) : 0, 4366
Debugger [candidate] (4.369 ms) : 0, 4369
Remote Config [baseline] (681.022 µs) : 0, 681
Remote Config [candidate] (688.646 µs) : 0, 689
Telemetry [baseline] (13.48 ms) : 0, 13480
Telemetry [candidate] (12.03 ms) : 0, 12030
section appsec
BytebuddyAgent [baseline] (741.238 ms) : 0, 741238
BytebuddyAgent [candidate] (750.127 ms) : 0, 750127
GlobalTracer [baseline] (236.752 ms) : 0, 236752
GlobalTracer [candidate] (239.38 ms) : 0, 239380
AppSec [baseline] (176.121 ms) : 0, 176121
AppSec [candidate] (177.453 ms) : 0, 177453
Debugger [baseline] (4.242 ms) : 0, 4242
Debugger [candidate] (4.261 ms) : 0, 4261
Remote Config [baseline] (639.291 µs) : 0, 639
Remote Config [candidate] (642.673 µs) : 0, 643
Telemetry [baseline] (8.312 ms) : 0, 8312
Telemetry [candidate] (8.3 ms) : 0, 8300
IAST [baseline] (22.015 ms) : 0, 22015
IAST [candidate] (22.402 ms) : 0, 22402
section iast
BytebuddyAgent [baseline] (852.347 ms) : 0, 852347
BytebuddyAgent [candidate] (842.331 ms) : 0, 842331
GlobalTracer [baseline] (231.316 ms) : 0, 231316
GlobalTracer [candidate] (230.518 ms) : 0, 230518
AppSec [baseline] (54.454 ms) : 0, 54454
AppSec [candidate] (55.233 ms) : 0, 55233
Debugger [baseline] (4.294 ms) : 0, 4294
Debugger [candidate] (4.224 ms) : 0, 4224
Remote Config [baseline] (621.417 µs) : 0, 621
Remote Config [candidate] (598.669 µs) : 0, 599
Telemetry [baseline] (8.774 ms) : 0, 8774
Telemetry [candidate] (8.755 ms) : 0, 8755
IAST [baseline] (24.738 ms) : 0, 24738
IAST [candidate] (23.675 ms) : 0, 23675
section profiling
BytebuddyAgent [baseline] (721.834 ms) : 0, 721834
BytebuddyAgent [candidate] (713.032 ms) : 0, 713032
GlobalTracer [baseline] (378.481 ms) : 0, 378481
GlobalTracer [candidate] (376.317 ms) : 0, 376317
AppSec [baseline] (54.862 ms) : 0, 54862
AppSec [candidate] (53.553 ms) : 0, 53553
Debugger [baseline] (4.454 ms) : 0, 4454
Debugger [candidate] (4.389 ms) : 0, 4389
Remote Config [baseline] (676.175 µs) : 0, 676
Remote Config [candidate] (673.791 µs) : 0, 674
Telemetry [baseline] (9.131 ms) : 0, 9131
Telemetry [candidate] (8.999 ms) : 0, 8999
ProfilingAgent [baseline] (103.662 ms) : 0, 103662
ProfilingAgent [candidate] (102.05 ms) : 0, 102050
Profiling [baseline] (103.687 ms) : 0, 103687
Profiling [candidate] (102.076 ms) : 0, 102076
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~05b1b2cffa, baseline=1.49.0-SNAPSHOT~368851d216
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058726
Total [baseline] (8.726 s) : 0, 8725547
Agent [candidate] (1.059 s) : 0, 1059219
Total [candidate] (8.719 s) : 0, 8719446
section iast
Agent [baseline] (1.186 s) : 0, 1186402
Total [baseline] (9.262 s) : 0, 9262451
Agent [candidate] (1.187 s) : 0, 1186713
Total [candidate] (9.284 s) : 0, 9284340
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.192 s) : 0, 1191560
Total [baseline] (9.269 s) : 0, 9268511
Agent [candidate] (1.187 s) : 0, 1187334
Total [candidate] (9.245 s) : 0, 9244946
section iast_TELEMETRY_OFF
Agent [baseline] (1.183 s) : 0, 1183320
Total [baseline] (9.289 s) : 0, 9288974
Agent [candidate] (1.185 s) : 0, 1184650
Total [candidate] (9.317 s) : 0, 9316828
gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~05b1b2cffa, baseline=1.49.0-SNAPSHOT~368851d216
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.678 ms) : 0, 722678
BytebuddyAgent [candidate] (721.692 ms) : 0, 721692
GlobalTracer [baseline] (239.73 ms) : 0, 239730
GlobalTracer [candidate] (239.78 ms) : 0, 239780
AppSec [baseline] (55.634 ms) : 0, 55634
AppSec [candidate] (55.388 ms) : 0, 55388
Debugger [baseline] (4.382 ms) : 0, 4382
Debugger [candidate] (5.104 ms) : 0, 5104
Remote Config [baseline] (2.8 ms) : 0, 2800
Remote Config [candidate] (3.776 ms) : 0, 3776
Telemetry [baseline] (9.853 ms) : 0, 9853
Telemetry [candidate] (10.027 ms) : 0, 10027
section iast
BytebuddyAgent [baseline] (840.484 ms) : 0, 840484
BytebuddyAgent [candidate] (840.244 ms) : 0, 840244
GlobalTracer [baseline] (230.462 ms) : 0, 230462
GlobalTracer [candidate] (230.565 ms) : 0, 230565
IAST [baseline] (22.782 ms) : 0, 22782
IAST [candidate] (25.274 ms) : 0, 25274
AppSec [baseline] (55.791 ms) : 0, 55791
AppSec [candidate] (52.873 ms) : 0, 52873
Debugger [baseline] (4.237 ms) : 0, 4237
Debugger [candidate] (4.254 ms) : 0, 4254
Remote Config [baseline] (613.334 µs) : 0, 613
Remote Config [candidate] (618.058 µs) : 0, 618
Telemetry [baseline] (8.606 ms) : 0, 8606
Telemetry [candidate] (8.737 ms) : 0, 8737
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (844.738 ms) : 0, 844738
BytebuddyAgent [candidate] (841.038 ms) : 0, 841038
GlobalTracer [baseline] (230.308 ms) : 0, 230308
GlobalTracer [candidate] (230.13 ms) : 0, 230130
IAST [baseline] (23.884 ms) : 0, 23884
IAST [candidate] (26.082 ms) : 0, 26082
AppSec [baseline] (55.509 ms) : 0, 55509
AppSec [candidate] (52.962 ms) : 0, 52962
Debugger [baseline] (4.269 ms) : 0, 4269
Debugger [candidate] (4.306 ms) : 0, 4306
Remote Config [baseline] (617.922 µs) : 0, 618
Remote Config [candidate] (611.163 µs) : 0, 611
Telemetry [baseline] (8.767 ms) : 0, 8767
Telemetry [candidate] (8.815 ms) : 0, 8815
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (838.713 ms) : 0, 838713
BytebuddyAgent [candidate] (839.384 ms) : 0, 839384
GlobalTracer [baseline] (229.723 ms) : 0, 229723
GlobalTracer [candidate] (230.126 ms) : 0, 230126
IAST [baseline] (22.312 ms) : 0, 22312
IAST [candidate] (22.482 ms) : 0, 22482
AppSec [baseline] (55.752 ms) : 0, 55752
AppSec [candidate] (55.882 ms) : 0, 55882
Debugger [baseline] (4.157 ms) : 0, 4157
Debugger [candidate] (4.17 ms) : 0, 4170
Remote Config [baseline] (638.099 µs) : 0, 638
Remote Config [candidate] (622.765 µs) : 0, 623
Telemetry [baseline] (8.681 ms) : 0, 8681
Telemetry [candidate] (8.648 ms) : 0, 8648
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~05b1b2cffa, baseline=1.49.0-SNAPSHOT~368851d216
dateFormat X
axisFormat %s
section baseline
no_agent (1.352 ms) : 1332, 1371
. : milestone, 1352,
appsec (1.727 ms) : 1704, 1750
. : milestone, 1727,
appsec_no_iast (1.728 ms) : 1705, 1751
. : milestone, 1728,
code_origins (1.694 ms) : 1668, 1721
. : milestone, 1694,
iast (1.517 ms) : 1493, 1542
. : milestone, 1517,
profiling (1.543 ms) : 1518, 1569
. : milestone, 1543,
tracing (1.512 ms) : 1487, 1537
. : milestone, 1512,
section candidate
no_agent (1.366 ms) : 1346, 1386
. : milestone, 1366,
appsec (1.756 ms) : 1732, 1779
. : milestone, 1756,
appsec_no_iast (1.722 ms) : 1699, 1745
. : milestone, 1722,
code_origins (1.665 ms) : 1637, 1692
. : milestone, 1665,
iast (1.502 ms) : 1478, 1526
. : milestone, 1502,
profiling (1.515 ms) : 1492, 1537
. : milestone, 1515,
tracing (1.487 ms) : 1461, 1512
. : milestone, 1487,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~05b1b2cffa, baseline=1.49.0-SNAPSHOT~368851d216
dateFormat X
axisFormat %s
section baseline
no_agent (379.4 µs) : 359, 399
. : milestone, 379,
iast (512.605 µs) : 491, 534
. : milestone, 513,
iast_FULL (729.646 µs) : 708, 751
. : milestone, 730,
iast_GLOBAL (565.807 µs) : 543, 589
. : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (507.889 µs) : 486, 529
. : milestone, 508,
iast_INACTIVE (458.925 µs) : 438, 480
. : milestone, 459,
iast_TELEMETRY_OFF (497.406 µs) : 476, 519
. : milestone, 497,
tracing (458.048 µs) : 437, 479
. : milestone, 458,
section candidate
no_agent (382.47 µs) : 363, 402
. : milestone, 382,
iast (515.318 µs) : 493, 538
. : milestone, 515,
iast_FULL (733.376 µs) : 711, 755
. : milestone, 733,
iast_GLOBAL (569.111 µs) : 545, 593
. : milestone, 569,
iast_HARDCODED_SECRET_DISABLED (512.524 µs) : 491, 534
. : milestone, 513,
iast_INACTIVE (462.796 µs) : 441, 484
. : milestone, 463,
iast_TELEMETRY_OFF (505.332 µs) : 483, 527
. : milestone, 505,
tracing (461.905 µs) : 441, 483
. : milestone, 462,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~05b1b2cffa, baseline=1.49.0-SNAPSHOT~368851d216
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.347 ms) : 2303, 2390
. : milestone, 2347,
iast (2.135 ms) : 2079, 2191
. : milestone, 2135,
iast_GLOBAL (2.172 ms) : 2116, 2228
. : milestone, 2172,
profiling (2.442 ms) : 2262, 2622
. : milestone, 2442,
tracing (1.966 ms) : 1924, 2008
. : milestone, 1966,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.36 ms) : 2317, 2404
. : milestone, 2360,
iast (2.129 ms) : 2074, 2185
. : milestone, 2129,
iast_GLOBAL (2.182 ms) : 2126, 2237
. : milestone, 2182,
profiling (1.994 ms) : 1949, 2039
. : milestone, 1994,
tracing (1.944 ms) : 1902, 1986
. : milestone, 1944,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~05b1b2cffa, baseline=1.49.0-SNAPSHOT~368851d216
dateFormat X
axisFormat %s
section baseline
no_agent (14.846 s) : 14846000, 14846000
. : milestone, 14846000,
appsec (15.017 s) : 15017000, 15017000
. : milestone, 15017000,
iast (18.448 s) : 18448000, 18448000
. : milestone, 18448000,
iast_GLOBAL (18.226 s) : 18226000, 18226000
. : milestone, 18226000,
profiling (15.013 s) : 15013000, 15013000
. : milestone, 15013000,
tracing (15.109 s) : 15109000, 15109000
. : milestone, 15109000,
section candidate
no_agent (15.548 s) : 15548000, 15548000
. : milestone, 15548000,
appsec (15.099 s) : 15099000, 15099000
. : milestone, 15099000,
iast (18.83 s) : 18830000, 18830000
. : milestone, 18830000,
iast_GLOBAL (18.306 s) : 18306000, 18306000
. : milestone, 18306000,
profiling (15.067 s) : 15067000, 15067000
. : milestone, 15067000,
tracing (14.829 s) : 14829000, 14829000
. : milestone, 14829000,
|
smola
approved these changes
Apr 21, 2025
sarahchen6
added a commit
that referenced
this pull request
Apr 24, 2025
This reverts commit 7dc621f.
sarahchen6
added a commit
that referenced
this pull request
Apr 25, 2025
This reverts commit 7dc621f.
sarahchen6
added a commit
that referenced
this pull request
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: tooling
Build & Tooling
tag: no release notes
Changes to exclude from release notes
type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR changes the way we retrieve the list of changed files in the merge commit by replacing the original
git diff
command with agit diff-tree
command.Motivation
#8657 tries to upgrade the byte-buddy version to 1.17.5 which requires the agent jar size to be increased. This increase was causing the original
git diff
command to fail due to the large binary file size. By usinggit diff-tree
, we can compare the tree objects directly and avoid problems with large binary files.Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]