-
Notifications
You must be signed in to change notification settings - Fork 304
Do not run JFR specific tests on J9 #8744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2d84c9d
to
2330db0
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~2330db0d23, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.011 s) : 0, 1011462
Total [baseline] (10.534 s) : 0, 10533960
Agent [candidate] (1.009 s) : 0, 1008708
Total [candidate] (10.507 s) : 0, 10507007
section appsec
Agent [baseline] (1.146 s) : 0, 1146464
Total [baseline] (10.63 s) : 0, 10629717
Agent [candidate] (1.153 s) : 0, 1153361
Total [candidate] (10.656 s) : 0, 10655681
section iast
Agent [baseline] (1.141 s) : 0, 1141064
Total [baseline] (10.826 s) : 0, 10826018
Agent [candidate] (1.136 s) : 0, 1135689
Total [candidate] (10.785 s) : 0, 10784544
section profiling
Agent [baseline] (1.255 s) : 0, 1254931
Total [baseline] (10.705 s) : 0, 10704624
Agent [candidate] (1.25 s) : 0, 1250042
Total [candidate] (10.645 s) : 0, 10645349
gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~2330db0d23, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.441 ms) : 0, 670441
BytebuddyAgent [candidate] (672.455 ms) : 0, 672455
GlobalTracer [baseline] (242.391 ms) : 0, 242391
GlobalTracer [candidate] (239.588 ms) : 0, 239588
AppSec [baseline] (55.153 ms) : 0, 55153
AppSec [candidate] (54.168 ms) : 0, 54168
Debugger [baseline] (6.224 ms) : 0, 6224
Debugger [candidate] (6.845 ms) : 0, 6845
Remote Config [baseline] (710.864 µs) : 0, 711
Remote Config [candidate] (710.611 µs) : 0, 711
Telemetry [baseline] (13.137 ms) : 0, 13137
Telemetry [candidate] (11.48 ms) : 0, 11480
section appsec
BytebuddyAgent [baseline] (686.916 ms) : 0, 686916
BytebuddyAgent [candidate] (691.797 ms) : 0, 691797
GlobalTracer [baseline] (235.777 ms) : 0, 235777
GlobalTracer [candidate] (237.25 ms) : 0, 237250
AppSec [baseline] (175.418 ms) : 0, 175418
AppSec [candidate] (175.949 ms) : 0, 175949
Debugger [baseline] (5.837 ms) : 0, 5837
Debugger [candidate] (5.857 ms) : 0, 5857
Remote Config [baseline] (630.076 µs) : 0, 630
Remote Config [candidate] (630.768 µs) : 0, 631
Telemetry [baseline] (7.745 ms) : 0, 7745
Telemetry [candidate] (7.409 ms) : 0, 7409
IAST [baseline] (21.729 ms) : 0, 21729
IAST [candidate] (21.94 ms) : 0, 21940
section iast
BytebuddyAgent [baseline] (793.373 ms) : 0, 793373
BytebuddyAgent [candidate] (789.43 ms) : 0, 789430
GlobalTracer [baseline] (230.303 ms) : 0, 230303
GlobalTracer [candidate] (229.667 ms) : 0, 229667
AppSec [baseline] (56.618 ms) : 0, 56618
AppSec [candidate] (56.213 ms) : 0, 56213
Debugger [baseline] (5.927 ms) : 0, 5927
Debugger [candidate] (5.851 ms) : 0, 5851
Remote Config [baseline] (599.348 µs) : 0, 599
Remote Config [candidate] (584.741 µs) : 0, 585
Telemetry [baseline] (7.922 ms) : 0, 7922
Telemetry [candidate] (7.845 ms) : 0, 7845
IAST [baseline] (22.836 ms) : 0, 22836
IAST [candidate] (22.775 ms) : 0, 22775
section profiling
BytebuddyAgent [baseline] (662.97 ms) : 0, 662970
BytebuddyAgent [candidate] (660.048 ms) : 0, 660048
GlobalTracer [baseline] (375.493 ms) : 0, 375493
GlobalTracer [candidate] (373.825 ms) : 0, 373825
AppSec [baseline] (54.388 ms) : 0, 54388
AppSec [candidate] (53.547 ms) : 0, 53547
Debugger [baseline] (6.133 ms) : 0, 6133
Debugger [candidate] (6.128 ms) : 0, 6128
Remote Config [baseline] (661.122 µs) : 0, 661
Remote Config [candidate] (655.539 µs) : 0, 656
Telemetry [baseline] (8.216 ms) : 0, 8216
Telemetry [candidate] (8.164 ms) : 0, 8164
ProfilingAgent [baseline] (97.059 ms) : 0, 97059
ProfilingAgent [candidate] (97.794 ms) : 0, 97794
Profiling [baseline] (97.084 ms) : 0, 97084
Profiling [candidate] (97.819 ms) : 0, 97819
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~2330db0d23, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.012 s) : 0, 1011519
Total [baseline] (8.638 s) : 0, 8637848
Agent [candidate] (1.01 s) : 0, 1010257
Total [candidate] (8.607 s) : 0, 8606573
section iast
Agent [baseline] (1.132 s) : 0, 1131784
Total [baseline] (9.165 s) : 0, 9165274
Agent [candidate] (1.134 s) : 0, 1134283
Total [candidate] (9.174 s) : 0, 9174269
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.131 s) : 0, 1131416
Total [baseline] (9.111 s) : 0, 9110887
Agent [candidate] (1.132 s) : 0, 1131788
Total [candidate] (9.137 s) : 0, 9137267
section iast_TELEMETRY_OFF
Agent [baseline] (1.13 s) : 0, 1129698
Total [baseline] (9.234 s) : 0, 9234489
Agent [candidate] (1.14 s) : 0, 1139923
Total [candidate] (9.269 s) : 0, 9268743
gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~2330db0d23, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.309 ms) : 0, 675309
BytebuddyAgent [candidate] (674.133 ms) : 0, 674133
GlobalTracer [baseline] (240.912 ms) : 0, 240912
GlobalTracer [candidate] (241.12 ms) : 0, 241120
AppSec [baseline] (54.907 ms) : 0, 54907
AppSec [candidate] (54.826 ms) : 0, 54826
Debugger [baseline] (6.148 ms) : 0, 6148
Debugger [candidate] (6.873 ms) : 0, 6873
Remote Config [baseline] (708.872 µs) : 0, 709
Remote Config [candidate] (696.57 µs) : 0, 697
Telemetry [baseline] (10.013 ms) : 0, 10013
Telemetry [candidate] (9.114 ms) : 0, 9114
section iast
BytebuddyAgent [baseline] (786.625 ms) : 0, 786625
BytebuddyAgent [candidate] (787.988 ms) : 0, 787988
GlobalTracer [baseline] (228.993 ms) : 0, 228993
GlobalTracer [candidate] (229.49 ms) : 0, 229490
AppSec [baseline] (56.115 ms) : 0, 56115
AppSec [candidate] (56.437 ms) : 0, 56437
Debugger [baseline] (5.796 ms) : 0, 5796
Debugger [candidate] (5.853 ms) : 0, 5853
Remote Config [baseline] (596.347 µs) : 0, 596
Remote Config [candidate] (594.846 µs) : 0, 595
Telemetry [baseline] (7.895 ms) : 0, 7895
Telemetry [candidate] (7.863 ms) : 0, 7863
IAST [baseline] (22.49 ms) : 0, 22490
IAST [candidate] (22.65 ms) : 0, 22650
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (786.116 ms) : 0, 786116
BytebuddyAgent [candidate] (786.014 ms) : 0, 786014
GlobalTracer [baseline] (229.063 ms) : 0, 229063
GlobalTracer [candidate] (229.197 ms) : 0, 229197
AppSec [baseline] (55.988 ms) : 0, 55988
AppSec [candidate] (56.377 ms) : 0, 56377
Debugger [baseline] (5.856 ms) : 0, 5856
Debugger [candidate] (5.785 ms) : 0, 5785
Remote Config [baseline] (571.216 µs) : 0, 571
Remote Config [candidate] (596.547 µs) : 0, 597
Telemetry [baseline] (7.848 ms) : 0, 7848
Telemetry [candidate] (7.863 ms) : 0, 7863
IAST [baseline] (22.643 ms) : 0, 22643
IAST [candidate] (22.665 ms) : 0, 22665
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (784.235 ms) : 0, 784235
BytebuddyAgent [candidate] (789.9 ms) : 0, 789900
GlobalTracer [baseline] (229.578 ms) : 0, 229578
GlobalTracer [candidate] (232.394 ms) : 0, 232394
AppSec [baseline] (56.088 ms) : 0, 56088
AppSec [candidate] (57.105 ms) : 0, 57105
Debugger [baseline] (5.868 ms) : 0, 5868
Debugger [candidate] (5.979 ms) : 0, 5979
Remote Config [baseline] (594.659 µs) : 0, 595
Remote Config [candidate] (676.531 µs) : 0, 677
Telemetry [baseline] (7.761 ms) : 0, 7761
Telemetry [candidate] (7.75 ms) : 0, 7750
IAST [baseline] (22.208 ms) : 0, 22208
IAST [candidate] (22.755 ms) : 0, 22755
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~2330db0d23, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section baseline
no_agent (384.81 µs) : 364, 406
. : milestone, 385,
iast (521.279 µs) : 498, 545
. : milestone, 521,
iast_FULL (734.892 µs) : 711, 758
. : milestone, 735,
iast_GLOBAL (574.493 µs) : 551, 598
. : milestone, 574,
iast_HARDCODED_SECRET_DISABLED (534.59 µs) : 512, 557
. : milestone, 535,
iast_INACTIVE (471.464 µs) : 450, 493
. : milestone, 471,
iast_TELEMETRY_OFF (521.337 µs) : 498, 544
. : milestone, 521,
tracing (466.116 µs) : 445, 487
. : milestone, 466,
section candidate
no_agent (384.565 µs) : 364, 405
. : milestone, 385,
iast (533.979 µs) : 511, 557
. : milestone, 534,
iast_FULL (737.021 µs) : 714, 760
. : milestone, 737,
iast_GLOBAL (565.233 µs) : 542, 588
. : milestone, 565,
iast_HARDCODED_SECRET_DISABLED (519.933 µs) : 497, 543
. : milestone, 520,
iast_INACTIVE (475.673 µs) : 453, 499
. : milestone, 476,
iast_TELEMETRY_OFF (520.128 µs) : 497, 543
. : milestone, 520,
tracing (465.628 µs) : 444, 487
. : milestone, 466,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~2330db0d23, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section baseline
no_agent (1.358 ms) : 1338, 1377
. : milestone, 1358,
appsec (1.742 ms) : 1718, 1766
. : milestone, 1742,
appsec_no_iast (1.73 ms) : 1707, 1754
. : milestone, 1730,
code_origins (1.68 ms) : 1654, 1706
. : milestone, 1680,
iast (1.507 ms) : 1482, 1533
. : milestone, 1507,
profiling (1.515 ms) : 1491, 1540
. : milestone, 1515,
tracing (1.485 ms) : 1460, 1511
. : milestone, 1485,
section candidate
no_agent (1.36 ms) : 1340, 1379
. : milestone, 1360,
appsec (1.745 ms) : 1721, 1768
. : milestone, 1745,
appsec_no_iast (1.722 ms) : 1698, 1745
. : milestone, 1722,
code_origins (1.697 ms) : 1669, 1724
. : milestone, 1697,
iast (1.534 ms) : 1509, 1559
. : milestone, 1534,
profiling (1.548 ms) : 1524, 1573
. : milestone, 1548,
tracing (1.501 ms) : 1475, 1527
. : milestone, 1501,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~2330db0d23, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.379 ms) : 2332, 2426
. : milestone, 2379,
iast (2.159 ms) : 2100, 2218
. : milestone, 2159,
iast_GLOBAL (2.19 ms) : 2131, 2250
. : milestone, 2190,
profiling (2.013 ms) : 1965, 2060
. : milestone, 2013,
tracing (1.995 ms) : 1949, 2042
. : milestone, 1995,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.376 ms) : 2329, 2424
. : milestone, 2376,
iast (2.162 ms) : 2102, 2222
. : milestone, 2162,
iast_GLOBAL (2.206 ms) : 2146, 2266
. : milestone, 2206,
profiling (2.021 ms) : 1972, 2070
. : milestone, 2021,
tracing (1.979 ms) : 1933, 2025
. : milestone, 1979,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~2330db0d23, baseline=1.49.0-SNAPSHOT~bd7a9c8502
dateFormat X
axisFormat %s
section baseline
no_agent (15.582 s) : 15582000, 15582000
. : milestone, 15582000,
appsec (15.046 s) : 15046000, 15046000
. : milestone, 15046000,
iast (18.733 s) : 18733000, 18733000
. : milestone, 18733000,
iast_GLOBAL (17.886 s) : 17886000, 17886000
. : milestone, 17886000,
profiling (15.055 s) : 15055000, 15055000
. : milestone, 15055000,
tracing (14.791 s) : 14791000, 14791000
. : milestone, 14791000,
section candidate
no_agent (14.978 s) : 14978000, 14978000
. : milestone, 14978000,
appsec (14.971 s) : 14971000, 14971000
. : milestone, 14971000,
iast (18.467 s) : 18467000, 18467000
. : milestone, 18467000,
iast_GLOBAL (18.114 s) : 18114000, 18114000
. : milestone, 18114000,
profiling (15.141 s) : 15141000, 15141000
. : milestone, 15141000,
tracing (15.041 s) : 15041000, 15041000
. : milestone, 15041000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
It does what it says - it will prevent unexpected test failures on J9 with JFR stub implementation.