Various Gitlab tweaks and test fixes #8847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomanderson
added
the
tag: no release notes
randomanderson
requested review from
shatzi,
pawelchcki and
amarziali
and removed request for
a team
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 15 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~78bc339fc4, baseline=1.50.0-SNAPSHOT~6a77487ae5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1022633
Total [baseline] (8.669 s) : 0, 8669343
Agent [candidate] (1.02 s) : 0, 1020420
Total [candidate] (8.659 s) : 0, 8659307
section iast
Agent [baseline] (1.157 s) : 0, 1157115
Total [baseline] (9.263 s) : 0, 9262719
Agent [candidate] (1.153 s) : 0, 1152656
Total [candidate] (9.226 s) : 0, 9226446
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.15 s) : 0, 1150178
Total [baseline] (9.199 s) : 0, 9198887
Agent [candidate] (1.157 s) : 0, 1157107
Total [candidate] (9.253 s) : 0, 9253062
section iast_TELEMETRY_OFF
Agent [baseline] (1.144 s) : 0, 1143929
Total [baseline] (9.255 s) : 0, 9255429
Agent [candidate] (1.162 s) : 0, 1162376
Total [candidate] (9.305 s) : 0, 9305126
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~78bc339fc4, baseline=1.50.0-SNAPSHOT~6a77487ae5
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.184 ms) : 0, 685184
BytebuddyAgent [candidate] (681.951 ms) : 0, 681951
GlobalTracer [baseline] (238.669 ms) : 0, 238669
GlobalTracer [candidate] (239.849 ms) : 0, 239849
AppSec [baseline] (55.039 ms) : 0, 55039
AppSec [candidate] (54.536 ms) : 0, 54536
Debugger [baseline] (9.743 ms) : 0, 9743
Debugger [candidate] (9.131 ms) : 0, 9131
Remote Config [baseline] (689.663 µs) : 0, 690
Remote Config [candidate] (695.971 µs) : 0, 696
Telemetry [baseline] (9.742 ms) : 0, 9742
Telemetry [candidate] (10.672 ms) : 0, 10672
section iast
BytebuddyAgent [baseline] (807.695 ms) : 0, 807695
BytebuddyAgent [candidate] (803.975 ms) : 0, 803975
GlobalTracer [baseline] (231.973 ms) : 0, 231973
GlobalTracer [candidate] (231.935 ms) : 0, 231935
IAST [baseline] (27.844 ms) : 0, 27844
IAST [candidate] (29.407 ms) : 0, 29407
AppSec [baseline] (51.508 ms) : 0, 51508
AppSec [candidate] (48.7 ms) : 0, 48700
Debugger [baseline] (5.962 ms) : 0, 5962
Debugger [candidate] (5.887 ms) : 0, 5887
Remote Config [baseline] (594.899 µs) : 0, 595
Remote Config [candidate] (600.405 µs) : 0, 600
Telemetry [baseline] (7.939 ms) : 0, 7939
Telemetry [candidate] (7.92 ms) : 0, 7920
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (802.638 ms) : 0, 802638
BytebuddyAgent [candidate] (807.259 ms) : 0, 807259
GlobalTracer [baseline] (230.884 ms) : 0, 230884
GlobalTracer [candidate] (231.941 ms) : 0, 231941
IAST [baseline] (30.028 ms) : 0, 30028
IAST [candidate] (28.818 ms) : 0, 28818
AppSec [baseline] (48.699 ms) : 0, 48699
AppSec [candidate] (50.781 ms) : 0, 50781
Debugger [baseline] (5.892 ms) : 0, 5892
Debugger [candidate] (6.006 ms) : 0, 6006
Remote Config [baseline] (582.978 µs) : 0, 583
Remote Config [candidate] (612.679 µs) : 0, 613
Telemetry [baseline] (7.977 ms) : 0, 7977
Telemetry [candidate] (8.044 ms) : 0, 8044
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (797.614 ms) : 0, 797614
BytebuddyAgent [candidate] (810.891 ms) : 0, 810891
GlobalTracer [baseline] (230.276 ms) : 0, 230276
GlobalTracer [candidate] (233.422 ms) : 0, 233422
IAST [baseline] (23.08 ms) : 0, 23080
IAST [candidate] (24.184 ms) : 0, 24184
AppSec [baseline] (55.173 ms) : 0, 55173
AppSec [candidate] (55.247 ms) : 0, 55247
Debugger [baseline] (5.959 ms) : 0, 5959
Debugger [candidate] (6.116 ms) : 0, 6116
Remote Config [baseline] (607.119 µs) : 0, 607
Remote Config [candidate] (640.102 µs) : 0, 640
Telemetry [baseline] (7.773 ms) : 0, 7773
Telemetry [candidate] (8.005 ms) : 0, 8005
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~78bc339fc4, baseline=1.50.0-SNAPSHOT~6a77487ae5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1017296
Total [baseline] (10.5 s) : 0, 10500341
Agent [candidate] (1.022 s) : 0, 1021861
Total [candidate] (10.506 s) : 0, 10505565
section appsec
Agent [baseline] (1.165 s) : 0, 1164919
Total [baseline] (10.673 s) : 0, 10672926
Agent [candidate] (1.16 s) : 0, 1160164
Total [candidate] (10.663 s) : 0, 10663073
section iast
Agent [baseline] (1.156 s) : 0, 1156319
Total [baseline] (10.953 s) : 0, 10952572
Agent [candidate] (1.157 s) : 0, 1157104
Total [candidate] (11.095 s) : 0, 11095010
section profiling
Agent [baseline] (1.296 s) : 0, 1295514
Total [baseline] (10.917 s) : 0, 10916701
Agent [candidate] (1.282 s) : 0, 1281785
Total [candidate] (10.854 s) : 0, 10853772
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~78bc339fc4, baseline=1.50.0-SNAPSHOT~6a77487ae5
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.241 ms) : 0, 682241
BytebuddyAgent [candidate] (682.942 ms) : 0, 682942
GlobalTracer [baseline] (239.813 ms) : 0, 239813
GlobalTracer [candidate] (240.55 ms) : 0, 240550
AppSec [baseline] (54.244 ms) : 0, 54244
AppSec [candidate] (54.489 ms) : 0, 54489
Debugger [baseline] (6.886 ms) : 0, 6886
Debugger [candidate] (9.145 ms) : 0, 9145
Remote Config [baseline] (716.331 µs) : 0, 716
Remote Config [candidate] (705.548 µs) : 0, 706
Telemetry [baseline] (9.845 ms) : 0, 9845
Telemetry [candidate] (10.429 ms) : 0, 10429
section appsec
BytebuddyAgent [baseline] (702.941 ms) : 0, 702941
BytebuddyAgent [candidate] (699.926 ms) : 0, 699926
GlobalTracer [baseline] (237.372 ms) : 0, 237372
GlobalTracer [candidate] (236.355 ms) : 0, 236355
AppSec [baseline] (176.284 ms) : 0, 176284
AppSec [candidate] (175.233 ms) : 0, 175233
Debugger [baseline] (5.926 ms) : 0, 5926
Debugger [candidate] (5.925 ms) : 0, 5925
Remote Config [baseline] (633.916 µs) : 0, 634
Remote Config [candidate] (623.08 µs) : 0, 623
Telemetry [baseline] (7.356 ms) : 0, 7356
Telemetry [candidate] (7.755 ms) : 0, 7755
IAST [baseline] (21.679 ms) : 0, 21679
IAST [candidate] (21.686 ms) : 0, 21686
section iast
BytebuddyAgent [baseline] (807.411 ms) : 0, 807411
BytebuddyAgent [candidate] (805.54 ms) : 0, 805540
GlobalTracer [baseline] (232.332 ms) : 0, 232332
GlobalTracer [candidate] (233.614 ms) : 0, 233614
AppSec [baseline] (48.613 ms) : 0, 48613
AppSec [candidate] (51.03 ms) : 0, 51030
Debugger [baseline] (5.888 ms) : 0, 5888
Debugger [candidate] (5.981 ms) : 0, 5981
Remote Config [baseline] (592.509 µs) : 0, 593
Remote Config [candidate] (605.463 µs) : 0, 605
Telemetry [baseline] (7.872 ms) : 0, 7872
Telemetry [candidate] (7.99 ms) : 0, 7990
IAST [baseline] (29.962 ms) : 0, 29962
IAST [candidate] (28.814 ms) : 0, 28814
section profiling
ProfilingAgent [baseline] (103.721 ms) : 0, 103721
ProfilingAgent [candidate] (103.212 ms) : 0, 103212
BytebuddyAgent [baseline] (683.605 ms) : 0, 683605
BytebuddyAgent [candidate] (674.705 ms) : 0, 674705
GlobalTracer [baseline] (379.165 ms) : 0, 379165
GlobalTracer [candidate] (375.209 ms) : 0, 375209
AppSec [baseline] (62.396 ms) : 0, 62396
AppSec [candidate] (62.536 ms) : 0, 62536
Debugger [baseline] (6.288 ms) : 0, 6288
Debugger [candidate] (6.252 ms) : 0, 6252
Remote Config [baseline] (673.646 µs) : 0, 674
Remote Config [candidate] (651.958 µs) : 0, 652
Telemetry [baseline] (8.278 ms) : 0, 8278
Telemetry [candidate] (8.264 ms) : 0, 8264
Profiling [baseline] (103.745 ms) : 0, 103745
Profiling [candidate] (103.236 ms) : 0, 103236
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 19 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~78bc339fc4, baseline=1.50.0-SNAPSHOT~6a77487ae5
dateFormat X
axisFormat %s
section baseline
no_agent (382.909 µs) : 363, 403
. : milestone, 383,
iast (523.292 µs) : 502, 545
. : milestone, 523,
iast_FULL (734.032 µs) : 712, 756
. : milestone, 734,
iast_GLOBAL (565.507 µs) : 544, 587
. : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (524.37 µs) : 502, 547
. : milestone, 524,
iast_INACTIVE (469.669 µs) : 447, 493
. : milestone, 470,
iast_TELEMETRY_OFF (512.342 µs) : 488, 537
. : milestone, 512,
tracing (465.282 µs) : 443, 488
. : milestone, 465,
section candidate
no_agent (386.284 µs) : 367, 406
. : milestone, 386,
iast (517.82 µs) : 496, 540
. : milestone, 518,
iast_FULL (738.55 µs) : 716, 761
. : milestone, 739,
iast_GLOBAL (569.78 µs) : 547, 592
. : milestone, 570,
iast_HARDCODED_SECRET_DISABLED (525.194 µs) : 503, 548
. : milestone, 525,
iast_INACTIVE (471.151 µs) : 449, 493
. : milestone, 471,
iast_TELEMETRY_OFF (508.779 µs) : 486, 532
. : milestone, 509,
tracing (459.617 µs) : 438, 481
. : milestone, 460,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~78bc339fc4, baseline=1.50.0-SNAPSHOT~6a77487ae5
dateFormat X
axisFormat %s
section baseline
no_agent (1.357 ms) : 1337, 1377
. : milestone, 1357,
appsec (1.743 ms) : 1720, 1766
. : milestone, 1743,
appsec_no_iast (1.72 ms) : 1697, 1743
. : milestone, 1720,
code_origins (1.678 ms) : 1651, 1706
. : milestone, 1678,
iast (1.508 ms) : 1484, 1531
. : milestone, 1508,
profiling (1.496 ms) : 1472, 1520
. : milestone, 1496,
tracing (1.496 ms) : 1471, 1520
. : milestone, 1496,
section candidate
no_agent (1.374 ms) : 1354, 1394
. : milestone, 1374,
appsec (1.729 ms) : 1706, 1752
. : milestone, 1729,
appsec_no_iast (1.738 ms) : 1715, 1761
. : milestone, 1738,
code_origins (1.679 ms) : 1652, 1706
. : milestone, 1679,
iast (1.515 ms) : 1492, 1539
. : milestone, 1515,
profiling (1.524 ms) : 1501, 1548
. : milestone, 1524,
tracing (1.497 ms) : 1472, 1521
. : milestone, 1497,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~78bc339fc4, baseline=1.50.0-SNAPSHOT~6a77487ae5
dateFormat X
axisFormat %s
section baseline
no_agent (15.237 s) : 15237000, 15237000
. : milestone, 15237000,
appsec (15.182 s) : 15182000, 15182000
. : milestone, 15182000,
iast (18.605 s) : 18605000, 18605000
. : milestone, 18605000,
iast_GLOBAL (18.045 s) : 18045000, 18045000
. : milestone, 18045000,
profiling (15.482 s) : 15482000, 15482000
. : milestone, 15482000,
tracing (14.84 s) : 14840000, 14840000
. : milestone, 14840000,
section candidate
no_agent (15.304 s) : 15304000, 15304000
. : milestone, 15304000,
appsec (15.086 s) : 15086000, 15086000
. : milestone, 15086000,
iast (19.202 s) : 19202000, 19202000
. : milestone, 19202000,
iast_GLOBAL (17.983 s) : 17983000, 17983000
. : milestone, 17983000,
profiling (15.208 s) : 15208000, 15208000
. : milestone, 15208000,
tracing (15.046 s) : 15046000, 15046000
. : milestone, 15046000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~78bc339fc4, baseline=1.50.0-SNAPSHOT~6a77487ae5
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.41 ms) : 2361, 2459
. : milestone, 2410,
iast (2.194 ms) : 2133, 2256
. : milestone, 2194,
iast_GLOBAL (2.241 ms) : 2179, 2303
. : milestone, 2241,
profiling (2.03 ms) : 1980, 2079
. : milestone, 2030,
tracing (2.014 ms) : 1966, 2062
. : milestone, 2014,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.41 ms) : 2361, 2459
. : milestone, 2410,
iast (2.188 ms) : 2126, 2250
. : milestone, 2188,
iast_GLOBAL (2.237 ms) : 2175, 2300
. : milestone, 2237,
profiling (2.067 ms) : 2016, 2119
. : milestone, 2067,
tracing (2.034 ms) : 1985, 2082
. : milestone, 2034,
|
bric3
approved these changes
May 19, 2025
| @@ -402,7 +402,7 @@ muzzle-dep-report: | |||
| export PROFILER_COMMAND="-XX:StartFlightRecording=settings=profile,filename=/tmp/${CI_JOB_NAME_SLUG}.jfr,dumponexit=true"; | |||
| fi | |||
| - *prepare_test_env | |||
| - export GRADLE_OPTS="-Dorg.gradle.jvmargs='-Xms$GRADLE_MEM -Xmx$GRADLE_MEM $PROFILER_COMMAND -XX:ErrorFile=/tmp/hs_err_pid%p.log -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/tmp' -Ddatadog.forkedMaxHeapSize=768M -Ddatadog.forkedMinHeapSize=128M" | |||
| - export GRADLE_OPTS="-Dorg.gradle.jvmargs='-Xms$GRADLE_MEM -Xmx$GRADLE_MEM $PROFILER_COMMAND -XX:ErrorFile=/tmp/hs_err_pid%p.log -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/tmp' -Ddatadog.forkedMaxHeapSize=1024M -Ddatadog.forkedMinHeapSize=128M" | |||
There was a problem hiding this comment.
suggestion: Maybe make the forkedMaxHeapSize a variable.
| @@ -402,7 +402,7 @@ muzzle-dep-report: | |||
| export PROFILER_COMMAND="-XX:StartFlightRecording=settings=profile,filename=/tmp/${CI_JOB_NAME_SLUG}.jfr,dumponexit=true"; | |||
| fi | |||
| - *prepare_test_env | |||
| - export GRADLE_OPTS="-Dorg.gradle.jvmargs='-Xms$GRADLE_MEM -Xmx$GRADLE_MEM $PROFILER_COMMAND -XX:ErrorFile=/tmp/hs_err_pid%p.log -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/tmp' -Ddatadog.forkedMaxHeapSize=768M -Ddatadog.forkedMinHeapSize=128M" | |||
| - export GRADLE_OPTS="-Dorg.gradle.jvmargs='-Xms$GRADLE_MEM -Xmx$GRADLE_MEM $PROFILER_COMMAND -XX:ErrorFile=/tmp/hs_err_pid%p.log -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/tmp' -Ddatadog.forkedMaxHeapSize=1024M -Ddatadog.forkedMinHeapSize=128M" | |||
There was a problem hiding this comment.
suggestion: On another topic, I believe we should remove -Xms param here (or reduce the minimum like 512M or 1G). I removed some during the CircleCi tweaks
sarahchen6
pushed a commit
that referenced
this pull request
Jun 12, 2025
* skip should be for entire class * bump memory to combat oom issues * bump smoketests and forked tests memory and defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
ExceptionHistogramTeston J9Motivation
I was regularly seeing OOMs on forked tests when running on all JDKs (the nightly). The
512mblimit is lower than the limit for regular tests. Some of these OOMs were nonobvious because the job would fail much laterThis PR aligns forks to use
1024mbacross all the ways tests could be forked.Additionally, I fixed the
ExceptionHistogramTest, which only failed during the nightly.Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]