-
Notifications
You must be signed in to change notification settings - Fork 304
chore: remove jmh from projects that don't have any benchmarks #8854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
…brary plugin is applied
@@ -1,13 +1,9 @@ | |||
plugins { | |||
id("me.champeau.jmh") | |||
`java-library` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this added by applying $rootDir/gradle/java.gradle
below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. It is, but in kotlin DSL scripts, the apply(from = )
style doesn't give access to generated configuration type-safe accessors like implementation
used in this project. Only the plugins
block triggers this.
Access to implementation
in particular is available only with the java-library
plugin or if another plugin depends on it like me.champeau.jmh
.
In general Gradle doesn't recommend the apply(from = )
style at all anymore (for various reasons), instead they recommend using convention plugins. Those would inherit any applied plugins.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~861e629d36, baseline=1.50.0-SNAPSHOT~0ebd52ba72
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.015 s) : 0, 1015439
Total [baseline] (8.652 s) : 0, 8652490
Agent [candidate] (1.024 s) : 0, 1024357
Total [candidate] (8.674 s) : 0, 8674002
section iast
Agent [baseline] (1.144 s) : 0, 1144279
Total [baseline] (9.23 s) : 0, 9229875
Agent [candidate] (1.156 s) : 0, 1156366
Total [candidate] (9.269 s) : 0, 9269095
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.149 s) : 0, 1148968
Total [baseline] (9.218 s) : 0, 9217589
Agent [candidate] (1.151 s) : 0, 1150905
Total [candidate] (9.201 s) : 0, 9200826
section iast_TELEMETRY_OFF
Agent [baseline] (1.146 s) : 0, 1145731
Total [baseline] (9.247 s) : 0, 9247049
Agent [candidate] (1.145 s) : 0, 1145227
Total [candidate] (9.28 s) : 0, 9279580
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~861e629d36, baseline=1.50.0-SNAPSHOT~0ebd52ba72
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (680.399 ms) : 0, 680399
BytebuddyAgent [candidate] (684.572 ms) : 0, 684572
GlobalTracer [baseline] (239.307 ms) : 0, 239307
GlobalTracer [candidate] (241.18 ms) : 0, 241180
AppSec [baseline] (54.174 ms) : 0, 54174
AppSec [candidate] (54.597 ms) : 0, 54597
Debugger [baseline] (8.298 ms) : 0, 8298
Debugger [candidate] (8.413 ms) : 0, 8413
Remote Config [baseline] (703.856 µs) : 0, 704
Remote Config [candidate] (708.034 µs) : 0, 708
Telemetry [baseline] (9.011 ms) : 0, 9011
Telemetry [candidate] (11.291 ms) : 0, 11291
section iast
BytebuddyAgent [baseline] (798.472 ms) : 0, 798472
BytebuddyAgent [candidate] (807.03 ms) : 0, 807030
GlobalTracer [baseline] (229.902 ms) : 0, 229902
GlobalTracer [candidate] (231.801 ms) : 0, 231801
IAST [baseline] (28.938 ms) : 0, 28938
IAST [candidate] (29.493 ms) : 0, 29493
AppSec [baseline] (49.276 ms) : 0, 49276
AppSec [candidate] (49.826 ms) : 0, 49826
Debugger [baseline] (5.854 ms) : 0, 5854
Debugger [candidate] (5.981 ms) : 0, 5981
Remote Config [baseline] (592.741 µs) : 0, 593
Remote Config [candidate] (595.523 µs) : 0, 596
Telemetry [baseline] (7.832 ms) : 0, 7832
Telemetry [candidate] (7.92 ms) : 0, 7920
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.986 ms) : 0, 801986
BytebuddyAgent [candidate] (801.923 ms) : 0, 801923
GlobalTracer [baseline] (230.367 ms) : 0, 230367
GlobalTracer [candidate] (231.94 ms) : 0, 231940
IAST [baseline] (28.3 ms) : 0, 28300
IAST [candidate] (27.044 ms) : 0, 27044
AppSec [baseline] (50.509 ms) : 0, 50509
AppSec [candidate] (51.92 ms) : 0, 51920
Debugger [baseline] (5.876 ms) : 0, 5876
Debugger [candidate] (5.931 ms) : 0, 5931
Remote Config [baseline] (585.205 µs) : 0, 585
Remote Config [candidate] (596.0 µs) : 0, 596
Telemetry [baseline] (7.88 ms) : 0, 7880
Telemetry [candidate] (7.937 ms) : 0, 7937
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.305 ms) : 0, 798305
BytebuddyAgent [candidate] (798.627 ms) : 0, 798627
GlobalTracer [baseline] (230.637 ms) : 0, 230637
GlobalTracer [candidate] (230.254 ms) : 0, 230254
IAST [baseline] (22.296 ms) : 0, 22296
IAST [candidate] (23.088 ms) : 0, 23088
AppSec [baseline] (56.276 ms) : 0, 56276
AppSec [candidate] (55.403 ms) : 0, 55403
Debugger [baseline] (6.065 ms) : 0, 6065
Debugger [candidate] (5.985 ms) : 0, 5985
Remote Config [baseline] (620.656 µs) : 0, 621
Remote Config [candidate] (595.563 µs) : 0, 596
Telemetry [baseline] (7.964 ms) : 0, 7964
Telemetry [candidate] (7.787 ms) : 0, 7787
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~861e629d36, baseline=1.50.0-SNAPSHOT~0ebd52ba72
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1019417
Total [baseline] (10.506 s) : 0, 10506174
Agent [candidate] (1.022 s) : 0, 1021991
Total [candidate] (10.508 s) : 0, 10508244
section appsec
Agent [baseline] (1.161 s) : 0, 1161167
Total [baseline] (10.699 s) : 0, 10699418
Agent [candidate] (1.164 s) : 0, 1163709
Total [candidate] (10.745 s) : 0, 10745166
section iast
Agent [baseline] (1.158 s) : 0, 1157603
Total [baseline] (10.872 s) : 0, 10871706
Agent [candidate] (1.15 s) : 0, 1150272
Total [candidate] (10.945 s) : 0, 10945201
section profiling
Agent [baseline] (1.286 s) : 0, 1285547
Total [baseline] (10.91 s) : 0, 10909975
Agent [candidate] (1.277 s) : 0, 1276704
Total [candidate] (10.827 s) : 0, 10827325
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~861e629d36, baseline=1.50.0-SNAPSHOT~0ebd52ba72
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.465 ms) : 0, 682465
BytebuddyAgent [candidate] (684.072 ms) : 0, 684072
GlobalTracer [baseline] (239.697 ms) : 0, 239697
GlobalTracer [candidate] (240.982 ms) : 0, 240982
AppSec [baseline] (54.866 ms) : 0, 54866
AppSec [candidate] (54.586 ms) : 0, 54586
Debugger [baseline] (8.241 ms) : 0, 8241
Debugger [candidate] (7.569 ms) : 0, 7569
Remote Config [baseline] (683.586 µs) : 0, 684
Remote Config [candidate] (704.578 µs) : 0, 705
Telemetry [baseline] (9.9 ms) : 0, 9900
Telemetry [candidate] (10.524 ms) : 0, 10524
section appsec
BytebuddyAgent [baseline] (700.313 ms) : 0, 700313
BytebuddyAgent [candidate] (702.321 ms) : 0, 702321
GlobalTracer [baseline] (236.342 ms) : 0, 236342
GlobalTracer [candidate] (236.798 ms) : 0, 236798
AppSec [baseline] (175.684 ms) : 0, 175684
AppSec [candidate] (175.757 ms) : 0, 175757
Debugger [baseline] (5.964 ms) : 0, 5964
Debugger [candidate] (5.929 ms) : 0, 5929
Remote Config [baseline] (628.342 µs) : 0, 628
Remote Config [candidate] (629.742 µs) : 0, 630
Telemetry [baseline] (7.836 ms) : 0, 7836
Telemetry [candidate] (7.794 ms) : 0, 7794
IAST [baseline] (21.576 ms) : 0, 21576
IAST [candidate] (21.684 ms) : 0, 21684
section iast
BytebuddyAgent [baseline] (808.297 ms) : 0, 808297
BytebuddyAgent [candidate] (802.127 ms) : 0, 802127
GlobalTracer [baseline] (231.812 ms) : 0, 231812
GlobalTracer [candidate] (231.588 ms) : 0, 231588
AppSec [baseline] (50.737 ms) : 0, 50737
AppSec [candidate] (50.461 ms) : 0, 50461
Debugger [baseline] (5.982 ms) : 0, 5982
Debugger [candidate] (5.909 ms) : 0, 5909
Remote Config [baseline] (606.246 µs) : 0, 606
Remote Config [candidate] (596.147 µs) : 0, 596
Telemetry [baseline] (7.999 ms) : 0, 7999
Telemetry [candidate] (7.877 ms) : 0, 7877
IAST [baseline] (27.728 ms) : 0, 27728
IAST [candidate] (27.486 ms) : 0, 27486
section profiling
BytebuddyAgent [baseline] (677.626 ms) : 0, 677626
BytebuddyAgent [candidate] (671.993 ms) : 0, 671993
GlobalTracer [baseline] (376.014 ms) : 0, 376014
GlobalTracer [candidate] (374.432 ms) : 0, 374432
AppSec [baseline] (62.159 ms) : 0, 62159
AppSec [candidate] (61.678 ms) : 0, 61678
Debugger [baseline] (6.276 ms) : 0, 6276
Debugger [candidate] (6.272 ms) : 0, 6272
Remote Config [baseline] (661.593 µs) : 0, 662
Remote Config [candidate] (655.948 µs) : 0, 656
Telemetry [baseline] (8.231 ms) : 0, 8231
Telemetry [candidate] (8.058 ms) : 0, 8058
ProfilingAgent [baseline] (103.561 ms) : 0, 103561
ProfilingAgent [candidate] (102.82 ms) : 0, 102820
Profiling [baseline] (103.586 ms) : 0, 103586
Profiling [candidate] (102.844 ms) : 0, 102844
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~861e629d36, baseline=1.50.0-SNAPSHOT~0ebd52ba72
dateFormat X
axisFormat %s
section baseline
no_agent (1.358 ms) : 1338, 1377
. : milestone, 1358,
appsec (1.737 ms) : 1714, 1761
. : milestone, 1737,
appsec_no_iast (1.733 ms) : 1709, 1756
. : milestone, 1733,
code_origins (1.664 ms) : 1636, 1691
. : milestone, 1664,
iast (1.517 ms) : 1493, 1541
. : milestone, 1517,
profiling (1.517 ms) : 1494, 1541
. : milestone, 1517,
tracing (1.479 ms) : 1454, 1503
. : milestone, 1479,
section candidate
no_agent (1.353 ms) : 1334, 1373
. : milestone, 1353,
appsec (1.736 ms) : 1713, 1760
. : milestone, 1736,
appsec_no_iast (1.718 ms) : 1695, 1742
. : milestone, 1718,
code_origins (1.676 ms) : 1649, 1704
. : milestone, 1676,
iast (1.501 ms) : 1477, 1525
. : milestone, 1501,
profiling (1.527 ms) : 1502, 1552
. : milestone, 1527,
tracing (1.475 ms) : 1450, 1500
. : milestone, 1475,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~861e629d36, baseline=1.50.0-SNAPSHOT~0ebd52ba72
dateFormat X
axisFormat %s
section baseline
no_agent (379.767 µs) : 359, 401
. : milestone, 380,
iast (510.384 µs) : 488, 532
. : milestone, 510,
iast_FULL (737.262 µs) : 715, 759
. : milestone, 737,
iast_GLOBAL (560.989 µs) : 539, 583
. : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (526.811 µs) : 503, 550
. : milestone, 527,
iast_INACTIVE (464.827 µs) : 442, 488
. : milestone, 465,
iast_TELEMETRY_OFF (503.12 µs) : 480, 526
. : milestone, 503,
tracing (457.741 µs) : 435, 480
. : milestone, 458,
section candidate
no_agent (379.731 µs) : 360, 399
. : milestone, 380,
iast (520.045 µs) : 497, 543
. : milestone, 520,
iast_FULL (731.046 µs) : 709, 753
. : milestone, 731,
iast_GLOBAL (564.884 µs) : 543, 587
. : milestone, 565,
iast_HARDCODED_SECRET_DISABLED (524.872 µs) : 502, 548
. : milestone, 525,
iast_INACTIVE (458.881 µs) : 437, 481
. : milestone, 459,
iast_TELEMETRY_OFF (512.395 µs) : 489, 535
. : milestone, 512,
tracing (458.501 µs) : 436, 481
. : milestone, 459,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~861e629d36, baseline=1.50.0-SNAPSHOT~0ebd52ba72
dateFormat X
axisFormat %s
section baseline
no_agent (15.422 s) : 15422000, 15422000
. : milestone, 15422000,
appsec (14.93 s) : 14930000, 14930000
. : milestone, 14930000,
iast (19.173 s) : 19173000, 19173000
. : milestone, 19173000,
iast_GLOBAL (18.12 s) : 18120000, 18120000
. : milestone, 18120000,
profiling (14.89 s) : 14890000, 14890000
. : milestone, 14890000,
tracing (15.072 s) : 15072000, 15072000
. : milestone, 15072000,
section candidate
no_agent (15.447 s) : 15447000, 15447000
. : milestone, 15447000,
appsec (15.055 s) : 15055000, 15055000
. : milestone, 15055000,
iast (18.553 s) : 18553000, 18553000
. : milestone, 18553000,
iast_GLOBAL (18.258 s) : 18258000, 18258000
. : milestone, 18258000,
profiling (15.085 s) : 15085000, 15085000
. : milestone, 15085000,
tracing (15.181 s) : 15181000, 15181000
. : milestone, 15181000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~861e629d36, baseline=1.50.0-SNAPSHOT~0ebd52ba72
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1486
. : milestone, 1475,
appsec (2.403 ms) : 2354, 2452
. : milestone, 2403,
iast (2.185 ms) : 2123, 2247
. : milestone, 2185,
iast_GLOBAL (2.228 ms) : 2166, 2291
. : milestone, 2228,
profiling (2.029 ms) : 1979, 2078
. : milestone, 2029,
tracing (2.02 ms) : 1972, 2068
. : milestone, 2020,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.405 ms) : 2356, 2454
. : milestone, 2405,
iast (2.185 ms) : 2122, 2247
. : milestone, 2185,
iast_GLOBAL (2.226 ms) : 2164, 2289
. : milestone, 2226,
profiling (2.505 ms) : 2325, 2686
. : milestone, 2505,
tracing (2.006 ms) : 1958, 2054
. : milestone, 2006,
|
What Does This Do
Remove jmh gradle plugin when the project actually has no benchmarks
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]