-
Notifications
You must be signed in to change notification settings - Fork 304
add documentation note about how to add instrumentation tests to CI [LANGPLAT-352] #9029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~41fc85d783, baseline=1.51.0-SNAPSHOT~faeb62cfb1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (995.138 ms) : 0, 995138
Total [baseline] (8.568 s) : 0, 8567876
Agent [candidate] (995.047 ms) : 0, 995047
Total [candidate] (8.562 s) : 0, 8562106
section iast
Agent [baseline] (1.137 s) : 0, 1136841
Total [baseline] (9.315 s) : 0, 9315482
Agent [candidate] (1.129 s) : 0, 1129137
Total [candidate] (9.307 s) : 0, 9306530
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~41fc85d783, baseline=1.51.0-SNAPSHOT~faeb62cfb1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.694 ms) : 0, 686694
BytebuddyAgent [candidate] (686.297 ms) : 0, 686297
GlobalTracer [baseline] (242.661 ms) : 0, 242661
GlobalTracer [candidate] (242.919 ms) : 0, 242919
AppSec [baseline] (29.944 ms) : 0, 29944
AppSec [candidate] (29.953 ms) : 0, 29953
Debugger [baseline] (6.07 ms) : 0, 6070
Debugger [candidate] (6.064 ms) : 0, 6064
Remote Config [baseline] (648.7 µs) : 0, 649
Remote Config [candidate] (649.917 µs) : 0, 650
Telemetry [baseline] (8.17 ms) : 0, 8170
Telemetry [candidate] (8.198 ms) : 0, 8198
section iast
BytebuddyAgent [baseline] (813.233 ms) : 0, 813233
BytebuddyAgent [candidate] (807.15 ms) : 0, 807150
GlobalTracer [baseline] (233.519 ms) : 0, 233519
GlobalTracer [candidate] (232.168 ms) : 0, 232168
AppSec [baseline] (27.2 ms) : 0, 27200
AppSec [candidate] (28.995 ms) : 0, 28995
Debugger [baseline] (5.792 ms) : 0, 5792
Debugger [candidate] (5.757 ms) : 0, 5757
Remote Config [baseline] (573.596 µs) : 0, 574
Remote Config [candidate] (578.542 µs) : 0, 579
Telemetry [baseline] (7.826 ms) : 0, 7826
Telemetry [candidate] (7.813 ms) : 0, 7813
IAST [baseline] (27.768 ms) : 0, 27768
IAST [candidate] (25.769 ms) : 0, 25769
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~41fc85d783, baseline=1.51.0-SNAPSHOT~faeb62cfb1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.007 s) : 0, 1006740
Total [baseline] (10.807 s) : 0, 10806955
Agent [candidate] (998.499 ms) : 0, 998499
Total [candidate] (10.769 s) : 0, 10768631
section appsec
Agent [baseline] (1.171 s) : 0, 1171398
Total [baseline] (10.795 s) : 0, 10794914
Agent [candidate] (1.185 s) : 0, 1184877
Total [candidate] (10.767 s) : 0, 10766696
section iast
Agent [baseline] (1.146 s) : 0, 1145807
Total [baseline] (10.888 s) : 0, 10887979
Agent [candidate] (1.129 s) : 0, 1128719
Total [candidate] (10.872 s) : 0, 10872180
section profiling
Agent [baseline] (1.241 s) : 0, 1241244
Total [baseline] (11.0 s) : 0, 11000132
Agent [candidate] (1.243 s) : 0, 1243321
Total [candidate] (11.103 s) : 0, 11102617
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~41fc85d783, baseline=1.51.0-SNAPSHOT~faeb62cfb1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.229 ms) : 0, 695229
BytebuddyAgent [candidate] (688.293 ms) : 0, 688293
GlobalTracer [baseline] (244.927 ms) : 0, 244927
GlobalTracer [candidate] (243.42 ms) : 0, 243420
AppSec [baseline] (30.416 ms) : 0, 30416
AppSec [candidate] (30.133 ms) : 0, 30133
Debugger [baseline] (6.124 ms) : 0, 6124
Debugger [candidate] (6.071 ms) : 0, 6071
Remote Config [baseline] (649.192 µs) : 0, 649
Remote Config [candidate] (645.883 µs) : 0, 646
Telemetry [baseline] (8.319 ms) : 0, 8319
Telemetry [candidate] (8.966 ms) : 0, 8966
section appsec
BytebuddyAgent [baseline] (708.941 ms) : 0, 708941
BytebuddyAgent [candidate] (719.019 ms) : 0, 719019
GlobalTracer [baseline] (236.03 ms) : 0, 236030
GlobalTracer [candidate] (237.65 ms) : 0, 237650
AppSec [baseline] (168.997 ms) : 0, 168997
AppSec [candidate] (170.39 ms) : 0, 170390
Debugger [baseline] (5.908 ms) : 0, 5908
Debugger [candidate] (5.907 ms) : 0, 5907
Remote Config [baseline] (604.841 µs) : 0, 605
Remote Config [candidate] (599.994 µs) : 0, 600
Telemetry [baseline] (8.155 ms) : 0, 8155
Telemetry [candidate] (8.168 ms) : 0, 8168
IAST [baseline] (21.937 ms) : 0, 21937
IAST [candidate] (22.063 ms) : 0, 22063
section iast
BytebuddyAgent [baseline] (819.419 ms) : 0, 819419
BytebuddyAgent [candidate] (806.134 ms) : 0, 806134
GlobalTracer [baseline] (234.952 ms) : 0, 234952
GlobalTracer [candidate] (232.283 ms) : 0, 232283
AppSec [baseline] (28.779 ms) : 0, 28779
AppSec [candidate] (29.857 ms) : 0, 29857
Debugger [baseline] (5.858 ms) : 0, 5858
Debugger [candidate] (5.779 ms) : 0, 5779
Remote Config [baseline] (586.194 µs) : 0, 586
Remote Config [candidate] (574.335 µs) : 0, 574
Telemetry [baseline] (7.999 ms) : 0, 7999
Telemetry [candidate] (7.852 ms) : 0, 7852
IAST [baseline] (27.145 ms) : 0, 27145
IAST [candidate] (25.323 ms) : 0, 25323
section profiling
ProfilingAgent [baseline] (102.136 ms) : 0, 102136
ProfilingAgent [candidate] (102.17 ms) : 0, 102170
BytebuddyAgent [baseline] (676.43 ms) : 0, 676430
BytebuddyAgent [candidate] (677.942 ms) : 0, 677942
GlobalTracer [baseline] (361.72 ms) : 0, 361720
GlobalTracer [candidate] (362.159 ms) : 0, 362159
AppSec [baseline] (32.602 ms) : 0, 32602
AppSec [candidate] (30.554 ms) : 0, 30554
Debugger [baseline] (8.972 ms) : 0, 8972
Debugger [candidate] (13.124 ms) : 0, 13124
Remote Config [baseline] (662.591 µs) : 0, 663
Remote Config [candidate] (658.061 µs) : 0, 658
Telemetry [baseline] (10.198 ms) : 0, 10198
Telemetry [candidate] (7.975 ms) : 0, 7975
Profiling [baseline] (102.162 ms) : 0, 102162
Profiling [candidate] (102.195 ms) : 0, 102195
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~41fc85d783, baseline=1.51.0-SNAPSHOT~faeb62cfb1
dateFormat X
axisFormat %s
section baseline
no_agent (4.298 ms) : 4249, 4347
. : milestone, 4298,
iast (8.927 ms) : 8784, 9071
. : milestone, 8927,
iast_FULL (14.012 ms) : 13730, 14293
. : milestone, 14012,
iast_GLOBAL (9.775 ms) : 9600, 9950
. : milestone, 9775,
profiling (8.716 ms) : 8580, 8852
. : milestone, 8716,
tracing (7.655 ms) : 7540, 7769
. : milestone, 7655,
section candidate
no_agent (4.396 ms) : 4347, 4445
. : milestone, 4396,
iast (8.876 ms) : 8733, 9019
. : milestone, 8876,
iast_FULL (13.796 ms) : 13518, 14075
. : milestone, 13796,
iast_GLOBAL (9.913 ms) : 9739, 10087
. : milestone, 9913,
profiling (9.139 ms) : 8996, 9282
. : milestone, 9139,
tracing (7.836 ms) : 7721, 7950
. : milestone, 7836,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~41fc85d783, baseline=1.51.0-SNAPSHOT~faeb62cfb1
dateFormat X
axisFormat %s
section baseline
no_agent (36.211 ms) : 35929, 36494
. : milestone, 36211,
appsec (47.437 ms) : 47018, 47857
. : milestone, 47437,
code_origins (45.406 ms) : 45019, 45794
. : milestone, 45406,
iast (44.628 ms) : 44239, 45018
. : milestone, 44628,
profiling (48.358 ms) : 47908, 48807
. : milestone, 48358,
tracing (44.609 ms) : 44224, 44994
. : milestone, 44609,
section candidate
no_agent (37.766 ms) : 37448, 38084
. : milestone, 37766,
appsec (47.564 ms) : 47141, 47987
. : milestone, 47564,
code_origins (43.598 ms) : 43250, 43946
. : milestone, 43598,
iast (43.146 ms) : 42758, 43534
. : milestone, 43146,
profiling (50.137 ms) : 49613, 50661
. : milestone, 50137,
tracing (43.782 ms) : 43428, 44137
. : milestone, 43782,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~41fc85d783, baseline=1.51.0-SNAPSHOT~faeb62cfb1
dateFormat X
axisFormat %s
section baseline
no_agent (15.213 s) : 15213000, 15213000
. : milestone, 15213000,
appsec (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
iast (18.448 s) : 18448000, 18448000
. : milestone, 18448000,
iast_GLOBAL (17.963 s) : 17963000, 17963000
. : milestone, 17963000,
profiling (15.35 s) : 15350000, 15350000
. : milestone, 15350000,
tracing (15.114 s) : 15114000, 15114000
. : milestone, 15114000,
section candidate
no_agent (15.462 s) : 15462000, 15462000
. : milestone, 15462000,
appsec (14.819 s) : 14819000, 14819000
. : milestone, 14819000,
iast (18.618 s) : 18618000, 18618000
. : milestone, 18618000,
iast_GLOBAL (18.023 s) : 18023000, 18023000
. : milestone, 18023000,
profiling (14.925 s) : 14925000, 14925000
. : milestone, 14925000,
tracing (15.298 s) : 15298000, 15298000
. : milestone, 15298000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~41fc85d783, baseline=1.51.0-SNAPSHOT~faeb62cfb1
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.411 ms) : 2362, 2460
. : milestone, 2411,
iast (2.188 ms) : 2127, 2250
. : milestone, 2188,
iast_GLOBAL (2.236 ms) : 2174, 2298
. : milestone, 2236,
profiling (2.47 ms) : 2308, 2632
. : milestone, 2470,
tracing (1.997 ms) : 1950, 2045
. : milestone, 1997,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.408 ms) : 2359, 2457
. : milestone, 2408,
iast (2.195 ms) : 2134, 2256
. : milestone, 2195,
iast_GLOBAL (2.231 ms) : 2169, 2293
. : milestone, 2231,
profiling (2.024 ms) : 1975, 2073
. : milestone, 2024,
tracing (2.011 ms) : 1963, 2058
. : milestone, 2011,
|
@@ -677,6 +677,8 @@ Tests are written in Groovy using the [Spock framework](http://spockframework.or | |||
instrumentations, `AgentTestRunner` must be extended. For example, HTTP server frameworks use base tests which enforce | |||
consistency between different implementations ( | |||
see [HttpServerTest](../dd-java-agent/testing/src/main/groovy/datadog/trace/agent/test/base/HttpServerTest.groovy)). | |||
Such Groovy-based tests are included by default in the CI instrumentation test jobs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have said that test marked as @Flaky
are not executed by the CI
What Does This Do
Adds a direct mention of how instrumentation tests get added to CI
Motivation
To make it easier for first-time contributors to become effective
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]