-
Notifications
You must be signed in to change notification settings - Fork 440
chore(iast): reduce telemetry error messages #13600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 272 ± 2 ms. The average import time from base is: 273 ± 2 ms. The import time difference between this PR and base is: -0.75 ± 0.09 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-06-05 14:17:33 Comparing candidate commit e8ec2d9 in PR branch Found 4 performance improvements and 2 performance regressions! Performance is the same for 551 metrics, 7 unstable metrics. scenario:iastaspects-ljust_aspect
scenario:iastaspects-lstrip_aspect
scenario:iastaspects-rstrip_aspect
scenario:iastaspects-strip_aspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:iastaspectsospath-ospathsplitdrive_aspect
|
…C-57578-iast_telemetry_logs
…C-57578-iast_telemetry_logs
Fix IAST validation in fstring aspect. We're considering as unexpected error, format errors like: `Unknown format code 'd' for object of type 'str'` this PR fixes an error in https://github.com/DataDog/dd-trace-py/pull/13600/files#r2128401733 part of #13600 APPSEC-57578 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
This PR changes how IAST reports errors when an exception occurs, especially in cases where execution happens outside of context. This was originally implemented to analyze which services were triggering this issue, and we used that insight to refactor how IAST creates and destroys context.
However, after that refactor, this information no longer provides value and only adds noise. So now, those telemetry metrics are only emitted if IAST is in debug mode.
Checklist
Reviewer Checklist