-
Notifications
You must be signed in to change notification settings - Fork 439
feat(dsm): context support for sns #13605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 287 ± 7 ms. The average import time from base is: 288 ± 6 ms. The import time difference between this PR and base is: -1.5 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-06-05 14:23:49 Comparing candidate commit 9039d15 in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 549 metrics, 3 unstable metrics. scenario:iastaspects-lstrip_aspect
scenario:iastaspects-rstrip_aspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:iastaspectsospath-ospathsplitext_aspect
|
context_json = json.loads(datadog_attr["stringValue"]) | ||
elif "BinaryValue" in datadog_attr: | ||
# Raw message delivery | ||
context_json = json.loads(datadog_attr["BinaryValue"].decode()) | ||
elif "binaryValue" in datadog_attr: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it actually valid to expect both this and line 185? Seems like they could be condensed into a single condition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that binaryValue is needed for sns -> sqs -> lambda but am worried about getting rid of the previous condition of BinaryValue, there are too many configurations that could result in the other state being accurate, if possible I would appreciate keeping both conditions
Added the proper support based on AWS message event format for sns -> lambda, as well as sns -> sqs -> lambda
This allows dsm to properly extract the neccessary context for lambda support
Checklist
Reviewer Checklist