Skip to content

chore(ci): move the selenium ci step to riot #13611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

juanjux
Copy link
Collaborator

@juanjux juanjux commented Jun 6, 2025

Move selenium from hatch to riot.

Signed-off-by: Juanjo Alvarez [email protected]## Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

juanjux added 3 commits June 6, 2025 13:51
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
@juanjux juanjux self-assigned this Jun 6, 2025
@juanjux juanjux added changelog/no-changelog A changelog entry is not required for this PR. CI labels Jun 6, 2025
@juanjux juanjux requested review from a team as code owners June 6, 2025 12:41
Copy link
Contributor

github-actions bot commented Jun 6, 2025

CODEOWNERS have been resolved as:

.riot/requirements/19a8285.txt                                          @DataDog/apm-python
.riot/requirements/1f438b0.txt                                          @DataDog/apm-python
hatch.toml                                                              @DataDog/python-guild
lib-injection/sources/min_compatible_versions.csv                       @DataDog/apm-core-python
min_compatible_versions.csv                                             @DataDog/apm-core-python
riotfile.py                                                             @DataDog/apm-python
tests/ci_visibility/suitespec.yml                                       @DataDog/ci-app-libraries

Copy link
Contributor

github-actions bot commented Jun 6, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 276 ± 3 ms.

The average import time from base is: 278 ± 4 ms.

The import time difference between this PR and base is: -2.2 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.960 ms (0.71%)
ddtrace.bootstrap.sitecustomize 1.286 ms (0.47%)
ddtrace.bootstrap.preload 1.286 ms (0.47%)
ddtrace.internal.remoteconfig.client 0.635 ms (0.23%)
ddtrace 0.674 ms (0.24%)
ddtrace.internal._unpatched 0.023 ms (0.01%)

Signed-off-by: Juanjo Alvarez <[email protected]>
@pr-commenter
Copy link

pr-commenter bot commented Jun 6, 2025

Benchmarks

Benchmark execution time: 2025-06-06 13:56:21

Comparing candidate commit aa0fcae in PR branch juanjux/selenium-from-hatch-to-riot with baseline commit d066cd9 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 528 metrics, 3 unstable metrics.

scenario:iastaspectsospath-ospathsplit_aspect

  • 🟥 execution_time [+651.148ns; +840.690ns] or [+13.407%; +17.310%]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these changes intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.21 changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants