Skip to content

[APPSEC-57738] Add API Security sampler #4699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jun 23, 2025

Conversation

Strech
Copy link
Member

@Strech Strech commented Jun 2, 2025

What does this PR do?

Add API security sampling logic required for API Security RFC

Motivation:

API Security RFC

Change log entry

Yes. AppSec: Add API Security to the rack, rails, sinatra and grape contribs.

Additional Notes:

I have adjusted LRU cache to give it store method.

How to test the change?

We have ST + CI to cover 99.9%

@github-actions github-actions bot added integrations Involves tracing integrations appsec Application Security monitoring product labels Jun 2, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jun 2, 2025

Datadog Report

Branch report: appsec-57738-add-api-security-sampler
Commit report: 648b7eb
Test service: dd-trace-rb

✅ 0 Failed, 21767 Passed, 1304 Skipped, 4m 53.07s Total Time

@Strech Strech force-pushed the appsec-57738-add-api-security-sampler branch from 1df22b0 to 99aff41 Compare June 2, 2025 12:56
@pr-commenter
Copy link

pr-commenter bot commented Jun 2, 2025

Benchmarks

Benchmark execution time: 2025-06-23 10:55:56

Comparing candidate commit 648b7eb in PR branch appsec-57738-add-api-security-sampler with baseline commit 748314c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 2 unstable metrics.

@Strech Strech force-pushed the appsec-57738-add-api-security-sampler branch 5 times, most recently from 0ab4de7 to 8332d0a Compare June 10, 2025 10:25
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 78.71486% with 106 lines in your changes missing coverage. Please review.

Project coverage is 97.52%. Comparing base (748314c) to head (648b7eb).

Files with missing lines Patch % Lines
...integration/api_security/schema_extraction_spec.rb 29.05% 105 Missing ⚠️
...contrib/devise/signin_single_user_tracking_spec.rb 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4699      +/-   ##
==========================================
- Coverage   97.63%   97.52%   -0.12%     
==========================================
  Files        1478     1485       +7     
  Lines       88083    88567     +484     
  Branches     4564     4584      +20     
==========================================
+ Hits        86002    86371     +369     
- Misses       2081     2196     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Strech Strech marked this pull request as ready for review June 10, 2025 11:20
@Strech Strech requested review from a team as code owners June 10, 2025 11:20
@Strech Strech force-pushed the appsec-57738-add-api-security-sampler branch 2 times, most recently from 6bfcecc to 4505626 Compare June 18, 2025 09:34
@Strech Strech force-pushed the appsec-57738-add-api-security-sampler branch from 8c1574a to 8817183 Compare June 23, 2025 09:33
@Strech Strech merged commit e55b643 into master Jun 23, 2025
445 checks passed
@Strech Strech deleted the appsec-57738-add-api-security-sampler branch June 23, 2025 11:25
@github-actions github-actions bot added this to the 2.18.0 milestone Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants