-
Notifications
You must be signed in to change notification settings - Fork 394
[APPSEC-57738] Add API Security sampler #4699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 21767 Passed, 1304 Skipped, 4m 53.07s Total Time |
1df22b0
to
99aff41
Compare
BenchmarksBenchmark execution time: 2025-06-23 10:55:56 Comparing candidate commit 648b7eb in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 2 unstable metrics. |
0ab4de7
to
8332d0a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4699 +/- ##
==========================================
- Coverage 97.63% 97.52% -0.12%
==========================================
Files 1478 1485 +7
Lines 88083 88567 +484
Branches 4564 4584 +20
==========================================
+ Hits 86002 86371 +369
- Misses 2081 2196 +115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6bfcecc
to
4505626
Compare
* Add api_security.enabled? alias
* Exclude appsec from all cops of rubocop
This is a quick-fix to address changes with sampling. All adjusted tests will be refactored
8c1574a
to
8817183
Compare
What does this PR do?
Add API security sampling logic required for API Security RFC
Motivation:
API Security RFC
Change log entry
Yes. AppSec: Add API Security to the
rack
,rails
,sinatra
andgrape
contribs.Additional Notes:
I have adjusted LRU cache to give it
store
method.How to test the change?
We have ST + CI to cover 99.9%