Skip to content

Add surefire tracer telemetry config rule #4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

daniel-mohedano
Copy link
Contributor

Motivation

Fixing system tests for DataDog/dd-trace-java#8650 and following up on https://github.com/DataDog/dd-go/pull/177450

Changes

Changes obtained by running ./utils/telemetry/intake/update.sh. Some other files where also modified (mainly removals) but only kept the relevant change for this PR.

        modified:   utils/telemetry/intake/static/config_norm_rules.json
        modified:   utils/telemetry/intake/static/config_prefix_block_list.json
        modified:   utils/telemetry/intake/static/dotnet_config_rules.json
        modified:   utils/telemetry/intake/static/go_config_rules.json
        modified:   utils/telemetry/intake/static/jvm_config_rules.json
        modified:   utils/telemetry/intake/static/nodejs_config_rules.json
        modified:   utils/telemetry/intake/static/php_config_rules.json
        modified:   utils/telemetry/intake/static/python_config_rules.json
        modified:   utils/telemetry/intake/static/ruby_config_rules.json

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@daniel-mohedano daniel-mohedano marked this pull request as ready for review April 3, 2025 09:10
@daniel-mohedano daniel-mohedano requested a review from a team as a code owner April 3, 2025 09:10
@daniel-mohedano daniel-mohedano requested review from ZStriker19 and removed request for a team April 3, 2025 09:10
@daniel-mohedano daniel-mohedano merged commit 2799fa9 into main Apr 3, 2025
430 checks passed
@daniel-mohedano daniel-mohedano deleted the daniel.mohedano/add-surefire-tracer-telemetry-config-rule branch April 3, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants