Skip to content

Add a regression test for extracting and injecting the parent_id under the p tracestate key #4595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

zacharycmontoya
Copy link
Contributor

@zacharycmontoya zacharycmontoya commented May 5, 2025

Motivation

We learned that Java fails to do a correct propagation of the parent_id p when the scenarios is:

  • Incoming tracestate has a p value
  • A local span is generated that is a child span of the remote trace context
  • The local span is injected into downstream headers

This new test asserts that the correct p value is injected downstream, which is the span-id of the local span.

Changes

Adds a new test tests/parametric/test_headers_tracecontext.py::test_tracestate_w3c_p_extract_and_inject that executes for all languages, except for Java where it is skipped due to nonconformance.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

…r the p tracestate key. Only Java fails the new test
@zacharycmontoya zacharycmontoya marked this pull request as ready for review May 6, 2025 20:13
@zacharycmontoya zacharycmontoya requested review from mabdinur and a team as code owners May 6, 2025 20:13
@zacharycmontoya zacharycmontoya merged commit b0b2e1f into main May 6, 2025
439 checks passed
@zacharycmontoya zacharycmontoya deleted the zach.montoya/w3c-p-inject-new-tests branch May 6, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants