Add App Key Registration Resource #3054
Conversation
| go 1.23.0 | ||
|
|
||
| replace github.com/DataDog/datadog-api-client-go/v2 => ../datadog-api-client-go |
There was a problem hiding this comment.
Remove once public API PR gets merged.
| _ resource.ResourceWithImportState = &appKeyRegistrationResource{} | ||
| ) | ||
|
|
||
| type appKeyRegistrationResource struct { |
There was a problem hiding this comment.
should we have a data source for this too? up to you if it makes sense or not.
There was a problem hiding this comment.
It doesn't make sense there is nothing to read the only property is the ID
There was a problem hiding this comment.
It might be useful if someone wants to reference an App Key that isn't TF-managed from another TF resource. If that's not useful then yea a data source wouldn't make sense.
There was a problem hiding this comment.
My thought was that this would be done by the app key data source then, not a app key registration data source.
There was a problem hiding this comment.
can you add tests for this?
| Attributes: map[string]schema.Attribute{ | ||
| "id": schema.StringAttribute{ | ||
| Description: "The Application Key ID to register.", | ||
| Required: true, |
There was a problem hiding this comment.
shouldn't this be set as Computed instead? unless the user is expected to provide their own UUID.
There was a problem hiding this comment.
This should not be computed. We need them to enter the ID it is the only property.
There was a problem hiding this comment.
kk that's fine we just usually generate IDs on the server that's why I asked
| return | ||
| } | ||
|
|
||
| // If the app key registration is not found, we log a warning and remove the resource from state. This may be due to changes in the UI or attempting to import an app key that is not registered. |
There was a problem hiding this comment.
I think having a "read" remove the resource from state is unintuitive. I think we should keep it as a 404 and it'll be on the customer to remove any non-existent registrations from their TF config.
There was a problem hiding this comment.
No I don't think so. This actually standard I believe. The reason is if the customer deletes it in the UI and you run any terraform command (like plan) your commands will fail and it is unrecoverable unless they reregister in the UI. The plan will display the user that the terraform resource will be deleted on the next apply.
|
@embeaken thanks for taking a look. |
| @@ -31,7 +31,7 @@ func (d *actionConnectionDatasource) Metadata(_ context.Context, request datasou | |||
|
|
|||
| func (d *actionConnectionDatasource) Schema(_ context.Context, request datasource.SchemaRequest, response *datasource.SchemaResponse) { | |||
| response.Schema = schema.Schema{ | |||
| Description: "A connection that can be used in Actions, including in the Workflow Automation and App Builder products.", | |||
| Description: "A connection that can be used in Actions, including in the Workflow Automation and App Builder products. This data source requires a [registered application key](https://registry.terraform.io/providers/DataDog/datadog/latest/docs/resources/app_key_registration).", | |||
There was a problem hiding this comment.
This link gives me a Page Not Found error on the Terraform site. I assume the link is not ready yet?
There was a problem hiding this comment.
Yes the link will only work once this is merged.
GabeWM
added
changelog/no-changelog
changelog/feature
and removed
changelog/feature
changelog/no-changelog
labels
Ticket: 10685
Motivation: https://docs.google.com/document/d/1GxqhcJLP2RTxqZZBed5lLp2mEehDA1K_Lu_FNgKH0qM/edit?tab=t.0#heading=h.g96a7txsgj2p
Dependent on public API release. This PR adds the new app key registration resource.