Skip to content

[SEC-22123] Update TF Provider Edit Default rule with custom fields. #3068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

cpatel24
Copy link
Contributor

@cpatel24 cpatel24 commented Jun 23, 2025

Update TF Provider Edit Default rule with custom fields.

Testing Terraform Provider

Unit Test:

  • Running tests locally passes fine:
$ RECORD=false TESTARGS="-run TestAccDatadogSecurityMonitoringDefaultRule_Basic" make testacc
  gotestsum --version || go install gotest.tools/gotestsum@latest
  gotestsum version dev
  which goimports || go install golang.org/x/tools/cmd/goimports@latest
  .
  .
  2025/06/25 00:08:12 DD_AGENT_HOST is not configured. Tests are executed without tracer and profiler.
  PASS datadog/tests.TestAccDatadogSecurityMonitoringDefaultRule_Basic (7.30s)
  PASS datadog/tests

$ RECORD=false TESTARGS="-run TestAccDatadogSecurityMonitoringDefaultRule_DeprecationWarning" make testacc
  gotestsum --version || go install gotest.tools/gotestsum@latest
  .
  .
  2025/06/25 00:07:51 DD_AGENT_HOST is not configured. Tests are executed without tracer and profiler.
  PASS datadog/tests.TestAccDatadogSecurityMonitoringDefaultRule_DeprecationWarning (6.62s)
  PASS datadog/tests

@cpatel24 cpatel24 requested review from a team as code owners June 23, 2025 19:39
Copy link
Contributor

@jhgilbert jhgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one comment, thanks!

@cpatel24 cpatel24 force-pushed the chirag.patel/SEC-22123_UpdateTFDoc branch from e2b3362 to 553d65f Compare June 24, 2025 16:11
@cpatel24 cpatel24 force-pushed the chirag.patel/SEC-22123_UpdateTFDoc branch from 70fc018 to af8cb39 Compare June 27, 2025 20:47
@cpatel24 cpatel24 force-pushed the chirag.patel/SEC-22123_UpdateTFDoc branch from af8cb39 to fa32b93 Compare June 27, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants