Skip to content

Refactoring and updating #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 21, 2016
Merged

Conversation

NinjaLikesCheez
Copy link
Contributor

Hey,

Please let me know if any of this isn't to your liking and I can change it! Also if this breaks all your stuff feel free to trash the PR and ignore me :)

  • Removed sample JSON and rejigged file saving to work across UNIX (hopefully windows too - I can't test but should work)
  • Added a config file containing API keys, data paths, default gamertags (for testing/pulling data)
  • Moved each API section out to it's own class under PiousAcademic (sick name btw) e.g. PiousAcademic16807.Metadata()
  • Added docstrings to some classes (not fully complete)
  • Refactored samples (getmeta) to getmeta, getprofile, and getstats
  • Tried to kill as many PEP8 warnings as I could

@David4Danger David4Danger merged commit 11ba989 into David4Danger:master Apr 21, 2016
@David4Danger
Copy link
Owner

Looks beautiful - I'll go through some tests later to make sure things still run well but after a quick skim everything looks great; a lot better than my original mess (what was I thinking with one giant class for all the methods haha)

Thanks for the contribution!

@NinjaLikesCheez
Copy link
Contributor Author

No worries.

Now lets hope they open up the bloody req apis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants